From patchwork Tue Jan 19 21:50:21 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 43232 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4DDE3B7C33 for ; Wed, 20 Jan 2010 08:46:07 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481Ab0ASVp2 (ORCPT ); Tue, 19 Jan 2010 16:45:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753384Ab0ASVp2 (ORCPT ); Tue, 19 Jan 2010 16:45:28 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:52013 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753371Ab0ASVp0 (ORCPT ); Tue, 19 Jan 2010 16:45:26 -0500 Received: by ewy19 with SMTP id 19so315883ewy.21 for ; Tue, 19 Jan 2010 13:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=OyEkoqmnRsybVXfnkw5dIXV6onqbguQZ+3YMBCDSnHQ=; b=FU8ViEE5U5rjQI1KroUa4mCfuWwrqqDufv4qUwC5oPj3Oasq/fMMwrVLKcyOYcmY7C V8XEq+FKuFYgHD0/dLs+OO9KdocREW2PwbEpoiPqHtGDreoXcfGMg7c0HRM2hwZGDMv8 1fL9XKnHSiurh0qTCmcfoJ/v8GMkoWXAROR/Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=nnSUi+CuhOn1EVEFn3SQ04TTPBZWwalyY9YsoCNZmNHVRd68K19I/4dkE1Md59B4T+ 34avaUl87Kug59+jFxerYQbR1yej7hoj2OCqoTsWyXOwarvrrstFDOCGk+pCG2UAjY2/ Xh9rRZYN/mCDTcNPifehZ7H5ekx6ob1U0CuKM= Received: by 10.213.45.131 with SMTP id e3mr1550143ebf.84.1263937524669; Tue, 19 Jan 2010 13:45:24 -0800 (PST) Received: from zoinx.mars (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id 7sm8374858eyb.34.2010.01.19.13.45.23 (version=SSLv3 cipher=RC4-MD5); Tue, 19 Jan 2010 13:45:24 -0800 (PST) Message-ID: <4B56291D.2000304@gmail.com> Date: Tue, 19 Jan 2010 22:50:21 +0100 From: Roel Kluin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 MIME-Version: 1.0 To: "David S. Miller" , netdev@vger.kernel.org, Andrew Morton , Alexey Kuznetsov , James Morris , Patrick McHardy , LKML Subject: [PATCH] [NETLINK]: With opcode INET_DIAG_BC_S_LE dport was compared in inet_diag_bc_run() Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The s-port should be compared. Signed-off-by: Roel Kluin --- I presume? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c index bdb78dd..1aaa811 100644 --- a/net/ipv4/inet_diag.c +++ b/net/ipv4/inet_diag.c @@ -368,7 +368,7 @@ static int inet_diag_bc_run(const void *bc, int len, yes = entry->sport >= op[1].no; break; case INET_DIAG_BC_S_LE: - yes = entry->dport <= op[1].no; + yes = entry->sport <= op[1].no; break; case INET_DIAG_BC_D_GE: yes = entry->dport >= op[1].no;