| Message ID | 20190425002140.208523-1-edumazet@google.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] tipc: remove rcu_read_unlock() left in tipc_udp_recv() | expand |
From: Eric Dumazet <edumazet@google.com> Date: Wed, 24 Apr 2019 17:21:40 -0700 > I forgot to remove one rcu_read_unlock() before a return statement. > > Joy of mixing goto and return styles in a function :) > > Fixes: 4109a2c3b91e ("tipc: tipc_udp_recv() cleanup vs rcu verbs") > Signed-off-by: Eric Dumazet <edumazet@google.com> > Reported-by: kbuild test robot <lkp@intel.com> Applied, thanks Eric.
diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index 7413cbc9b638af492d6a592df957a3229fa6a3fa..0884a1b8ad12595cabca71229789c55a14f24659 100644 --- a/net/tipc/udp_media.c +++ b/net/tipc/udp_media.c @@ -360,7 +360,6 @@ static int tipc_udp_recv(struct sock *sk, struct sk_buff *skb) if (b && test_bit(0, &b->up)) { tipc_rcv(sock_net(sk), skb, b); - rcu_read_unlock(); return 0; }
I forgot to remove one rcu_read_unlock() before a return statement. Joy of mixing goto and return styles in a function :) Fixes: 4109a2c3b91e ("tipc: tipc_udp_recv() cleanup vs rcu verbs") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: kbuild test robot <lkp@intel.com> --- net/tipc/udp_media.c | 1 - 1 file changed, 1 deletion(-)