From patchwork Thu Apr 25 00:21:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 1090566 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="PYXluP/G"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44qHtP4Ddgz9s3Z for ; Thu, 25 Apr 2019 10:21:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728635AbfDYAVo (ORCPT ); Wed, 24 Apr 2019 20:21:44 -0400 Received: from mail-pl1-f202.google.com ([209.85.214.202]:55074 "EHLO mail-pl1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728605AbfDYAVo (ORCPT ); Wed, 24 Apr 2019 20:21:44 -0400 Received: by mail-pl1-f202.google.com with SMTP id ba11so5282437plb.21 for ; Wed, 24 Apr 2019 17:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=BgK9JfG9eZy6XcO6x+TWikqsG+92t5ODqwxAVIJcwwk=; b=PYXluP/GlHZljG/7qLQ5u3Vzv2IQ9ItmhZw99fJICAxf3wiUBPQpi8Txf5Zx5H/YZG gqaPxveZsu1GUB/Ng8Ll1boW0NnvoFXqKr7fEH6YB5TLWY70bGK+GLKbiS0YDXR3Bnnl 5ZvaykryKLCtJWWcnIfW0uq6rcE/6y6145J9QekPa90snikn2me069FUkLnYcF1Sg7mA 1p1VAHI50E8+t+coLjvtNrBv+bQY+COsYycIG9yHvJmfwM5opU59IDK54Wk2LfDPzonA 5PzaJWa5PGBmex6zDs33GiZFRA1i6qIztiO2isj2u2nj9dyKUEMwsaSK3ldtpB92O3v1 qqxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=BgK9JfG9eZy6XcO6x+TWikqsG+92t5ODqwxAVIJcwwk=; b=ujjVxMHNkCm0bPI4ggjA4sDYx5iLtgufQXolhlMxXPWus0cnsfnepqAm9p9wwLV1gw 7U7fn77FwCGlNons6PQp2hV0b04r6m5ZbS6RP378xA9/LYDtvxs6OJlrAhP6XjcSU2id Yn4IVrCGerrxCQkTfxjQqHAl3+bicXt3O2Bylfd3y0apbWF8KeyX1SlLpivzDVkxvyMk VjZluHH6gH0UDvj9RKyE2hUZcxKRjhuC0UKovZKIpvIVBmK2cT1RgtaVSM+FrqM+8Mfv vhlr/M1wCrlABrvB5cE3dQOrGCaH+seSXfTsqWGJIVcxK1ZCAXfCVBUaI7Ir+WqWcv/e qTow== X-Gm-Message-State: APjAAAUUT9yJcQWhLxyY9TDDQr8b+dN/h/DnlvPM1XGhQ/k/NunN78sZ i5Seq/iaGyDP+am1F9lvPQlT0o8RAKUUAw== X-Google-Smtp-Source: APXvYqwaPUAA+6enfyn4IFsjjb4sBylVel6H26v6wMB8A3o4ZSHZcZh5+D4ZxQHc2dDMG0tEgcJLDUwUX1/DBg== X-Received: by 2002:a63:1058:: with SMTP id 24mr29157838pgq.297.1556151703474; Wed, 24 Apr 2019 17:21:43 -0700 (PDT) Date: Wed, 24 Apr 2019 17:21:40 -0700 Message-Id: <20190425002140.208523-1-edumazet@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.21.0.593.g511ec345e18-goog Subject: [PATCH net-next] tipc: remove rcu_read_unlock() left in tipc_udp_recv() From: Eric Dumazet To: "David S . Miller" Cc: netdev , Eric Dumazet , Eric Dumazet , kbuild test robot Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I forgot to remove one rcu_read_unlock() before a return statement. Joy of mixing goto and return styles in a function :) Fixes: 4109a2c3b91e ("tipc: tipc_udp_recv() cleanup vs rcu verbs") Signed-off-by: Eric Dumazet Reported-by: kbuild test robot --- net/tipc/udp_media.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index 7413cbc9b638af492d6a592df957a3229fa6a3fa..0884a1b8ad12595cabca71229789c55a14f24659 100644 --- a/net/tipc/udp_media.c +++ b/net/tipc/udp_media.c @@ -360,7 +360,6 @@ static int tipc_udp_recv(struct sock *sk, struct sk_buff *skb) if (b && test_bit(0, &b->up)) { tipc_rcv(sock_net(sk), skb, b); - rcu_read_unlock(); return 0; }