[iproute2,v2,1/9] bridge: avoid snprint truncation on time

Message ID	20180320202909.22166-2-stephen@networkplumber.org
State	Accepted, archived
Delegated to:	stephen hemminger
Headers	show Return-Path: <netdev-owner@vger.kernel.org> From: Stephen Hemminger <stephen@networkplumber.org> To: netdev@vger.kernel.org Cc: Stephen Hemminger <stephen@networkplumber.org> Subject: [PATCH iproute2 v2 1/9] bridge: avoid snprint truncation on time Date: Tue, 20 Mar 2018 13:29:01 -0700 Message-Id: <20180320202909.22166-2-stephen@networkplumber.org> In-Reply-To: <20180320202909.22166-1-stephen@networkplumber.org> References: <20180320202909.22166-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	gcc-8 warning fixes \| expand [iproute2,v2,0/9] gcc-8 warning fixes [iproute2,v2,1/9] bridge: avoid snprint truncation on time [iproute2,v2,2/9] pedit: fix strncpy warning [iproute2,v2,3/9] ip: use strlcpy() to avoid truncation [iproute2,v2,4/9] tunnel: use strlcpy to avoid strncpy warnings [iproute2,v2,5/9] namespace: fix warning snprintf buffer [iproute2,v2,6/9] tc_class: fix snprintf warning [iproute2,v2,7/9] ematch: fix possible snprintf overflow [iproute2,v2,8/9] misc: avoid snprintf warnings in ss and nstat [iproute2,v2,9/9] bpf: avoid compiler warnings about strncpy

Message ID

20180320202909.22166-2-stephen@networkplumber.org

State

Accepted, archived

Delegated to:

stephen hemminger

Headers

From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH iproute2 v2 1/9] bridge: avoid snprint truncation on time
Date: Tue, 20 Mar 2018 13:29:01 -0700
Message-Id: <20180320202909.22166-2-stephen@networkplumber.org>
In-Reply-To: <20180320202909.22166-1-stephen@networkplumber.org>
References: <20180320202909.22166-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: netdev-owner@vger.kernel.org
Precedence: bulk

Series

gcc-8 warning fixes | expand

Commit Message

Stephen Hemminger March 20, 2018, 8:29 p.m. UTC

This fixes new gcc warning about possible string overflow.

mdb.c: In function ‘__print_router_port_stats’:
mdb.c:61:11: warning: ‘%.2i’ directive output may be truncated
 writing between 2 and 7 bytes into a region of size
 between 0 and 4 [-Wformat-truncation=]
      "%4i.%.2i", (int)tv.tv_sec,
           ^~~~
Note: already fixed in iproute2-next.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 bridge/mdb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bridge/mdb.c b/bridge/mdb.c
index 58c20b82b8a6..659cac3ff20a 100644
--- a/bridge/mdb.c
+++ b/bridge/mdb.c
@@ -55,7 +55,7 @@  static void __print_router_port_stats(FILE *f, struct rtattr *pattr)
 		__jiffies_to_tv(&tv,
 				rta_getattr_u32(tb[MDBA_ROUTER_PATTR_TIMER]));
 		if (jw_global) {
-			char formatted_time[9];
+			char formatted_time[32];
 
 			snprintf(formatted_time, sizeof(formatted_time),
 				 "%4i.%.2i", (int)tv.tv_sec,
@@ -184,7 +184,7 @@  static void print_mdb_entry(FILE *f, int ifindex, struct br_mdb_entry *e,
 
 		__jiffies_to_tv(&tv, rta_getattr_u32(tb[MDBA_MDB_EATTR_TIMER]));
 		if (jw_global) {
-			char formatted_time[9];
+			char formatted_time[32];
 
 			snprintf(formatted_time, sizeof(formatted_time),
 				 "%4i.%.2i", (int)tv.tv_sec,

[iproute2,v2,1/9] bridge: avoid snprint truncation on time

Commit Message

Patch