From patchwork Tue Mar 20 20:29:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 888415 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="0DFg1Ncb"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 405Pfm47Wpz9ryk for ; Wed, 21 Mar 2018 07:29:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751539AbeCTU3S (ORCPT ); Tue, 20 Mar 2018 16:29:18 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:45458 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269AbeCTU3O (ORCPT ); Tue, 20 Mar 2018 16:29:14 -0400 Received: by mail-pl0-f68.google.com with SMTP id n15-v6so1715211plp.12 for ; Tue, 20 Mar 2018 13:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l72ZjGiZ5FotRL5KPrXM2WdONwjyd6cnLTL0rt4WfcA=; b=0DFg1Ncb3JzMro+RsYSY022Wf0K4uJRkQcFebRSOspVu6/dsAL/Pmr/TPXYauTTxrG aJIbIGCbMgDdrRVsq2v0hYOcJpiappmzgEqPoeZ0/MAStbsKbA7Ulu1bGOxxu8Jkclt5 XFEIdlaKp7GBML/l2PI99BvQuEQ1zbzk5k2XPj6a50cbFf/0aEXmNBj0VbVDzzdnQfvY Qz+SzoIPJ1nXCyR3xVim7pV709jC+Wv959NyzTpJ2Vzr9tNmVO6KQ3qwZ9fBVw5jKLhU op+CsMXG5q0j3/j1FXg/+EKJMXydAxwXu68JuCHpRIkVYo8/iP7YY1YFHhhzjkr/h65r 1JZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l72ZjGiZ5FotRL5KPrXM2WdONwjyd6cnLTL0rt4WfcA=; b=D0bz4vK+6w52xm2IxbBxiInIjYNRZh8sa2ym4E+H4V5aJ+ibkzEyRxSD+LVYtKqiG/ 67F0Zn/V3tlfkPF6U6l2wjRVL6X/5XBlePV3ffANVj1ClY1TvIXXd2RuCAB5BVIAjgBP DD8C49ISAWCsp+pqTFpFb2cVn9aFRQWe4UNttaK/A39iZxEgta42fgfNbWUnNQWiF8cC AeWi5OfQZ25Hy3VF62QAkV7pNX1ekf49CEFKh6J8fT7y/vl+fMxy1iS8g3OT2AlKyTVZ NYqS/ukwT2fzJ0kWV1d82ynqs4+fq8xisz54rGOiDmStBxHsgBUSbwSnb0v8eL0igD0g klRQ== X-Gm-Message-State: AElRT7FlBMC6kZ+IMfjYOXKSK+xrlj76+y8TwAHuy7xodFInKUXz3CMk UIeSlPxIx+iXmULsNdVjls8nJ3eB1lk= X-Google-Smtp-Source: AG47ELsUrRLb7FJumAJ2soNx/pn4ZWnGulnEm76vdavUcTH4+ENXzm4mRjx1RJOxPbQlg/rJsPVqsw== X-Received: by 2002:a17:902:6b0c:: with SMTP id o12-v6mr18298536plk.295.1521577753370; Tue, 20 Mar 2018 13:29:13 -0700 (PDT) Received: from xeon-e3.lan (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id u68sm5343597pfu.167.2018.03.20.13.29.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Mar 2018 13:29:12 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger Subject: [PATCH iproute2 v2 1/9] bridge: avoid snprint truncation on time Date: Tue, 20 Mar 2018 13:29:01 -0700 Message-Id: <20180320202909.22166-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180320202909.22166-1-stephen@networkplumber.org> References: <20180320202909.22166-1-stephen@networkplumber.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This fixes new gcc warning about possible string overflow. mdb.c: In function ‘__print_router_port_stats’: mdb.c:61:11: warning: ‘%.2i’ directive output may be truncated writing between 2 and 7 bytes into a region of size between 0 and 4 [-Wformat-truncation=] "%4i.%.2i", (int)tv.tv_sec, ^~~~ Note: already fixed in iproute2-next. Signed-off-by: Stephen Hemminger --- bridge/mdb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bridge/mdb.c b/bridge/mdb.c index 58c20b82b8a6..659cac3ff20a 100644 --- a/bridge/mdb.c +++ b/bridge/mdb.c @@ -55,7 +55,7 @@ static void __print_router_port_stats(FILE *f, struct rtattr *pattr) __jiffies_to_tv(&tv, rta_getattr_u32(tb[MDBA_ROUTER_PATTR_TIMER])); if (jw_global) { - char formatted_time[9]; + char formatted_time[32]; snprintf(formatted_time, sizeof(formatted_time), "%4i.%.2i", (int)tv.tv_sec, @@ -184,7 +184,7 @@ static void print_mdb_entry(FILE *f, int ifindex, struct br_mdb_entry *e, __jiffies_to_tv(&tv, rta_getattr_u32(tb[MDBA_MDB_EATTR_TIMER])); if (jw_global) { - char formatted_time[9]; + char formatted_time[32]; snprintf(formatted_time, sizeof(formatted_time), "%4i.%.2i", (int)tv.tv_sec,