| Message ID | 20130904150727.GA32327@elgon.mountain |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, 2013-09-04 at 18:07 +0300, Dan Carpenter wrote: > It upsets static analyzers when we don't check for allocation failure. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Ben Hutchings <bhutchings@solarflare.com> > --- > v2: rebased on latest linux-next > > diff --git a/drivers/net/ethernet/sfc/falcon.c b/drivers/net/ethernet/sfc/falcon.c > index 38d179c..75799f8 100644 > --- a/drivers/net/ethernet/sfc/falcon.c > +++ b/drivers/net/ethernet/sfc/falcon.c > @@ -894,6 +894,8 @@ static int falcon_mtd_probe(struct efx_nic *efx) > > /* Allocate space for maximum number of partitions */ > parts = kcalloc(2, sizeof(*parts), GFP_KERNEL); > + if (!parts) > + return -ENOMEM; > n_parts = 0; > > spi = &nic_data->spi_flash;
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Wed, 4 Sep 2013 18:07:27 +0300 > It upsets static analyzers when we don't check for allocation failure. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > v2: rebased on latest linux-next Applied, thanks Dan. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/sfc/falcon.c b/drivers/net/ethernet/sfc/falcon.c index 38d179c..75799f8 100644 --- a/drivers/net/ethernet/sfc/falcon.c +++ b/drivers/net/ethernet/sfc/falcon.c @@ -894,6 +894,8 @@ static int falcon_mtd_probe(struct efx_nic *efx) /* Allocate space for maximum number of partitions */ parts = kcalloc(2, sizeof(*parts), GFP_KERNEL); + if (!parts) + return -ENOMEM; n_parts = 0; spi = &nic_data->spi_flash;
It upsets static analyzers when we don't check for allocation failure. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- v2: rebased on latest linux-next -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html