From patchwork Wed Sep 4 15:07:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 272647 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 393F02C0040 for ; Thu, 5 Sep 2013 01:07:44 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934998Ab3IDPHk (ORCPT ); Wed, 4 Sep 2013 11:07:40 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:36257 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934731Ab3IDPHj (ORCPT ); Wed, 4 Sep 2013 11:07:39 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r84F7XID027679 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 4 Sep 2013 15:07:34 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r84F7WVh003365 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 4 Sep 2013 15:07:32 GMT Received: from abhmt114.oracle.com (abhmt114.oracle.com [141.146.116.66]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r84F7W1q015018; Wed, 4 Sep 2013 15:07:32 GMT Received: from elgon.mountain (/41.210.129.9) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 04 Sep 2013 08:07:31 -0700 Date: Wed, 4 Sep 2013 18:07:27 +0300 From: Dan Carpenter To: Solarflare linux maintainers Cc: Ben Hutchings , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch v2] sfc: check for allocation failure Message-ID: <20130904150727.GA32327@elgon.mountain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130903.224939.866623192858217581.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org It upsets static analyzers when we don't check for allocation failure. Signed-off-by: Dan Carpenter Acked-by: Ben Hutchings --- v2: rebased on latest linux-next -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/sfc/falcon.c b/drivers/net/ethernet/sfc/falcon.c index 38d179c..75799f8 100644 --- a/drivers/net/ethernet/sfc/falcon.c +++ b/drivers/net/ethernet/sfc/falcon.c @@ -894,6 +894,8 @@ static int falcon_mtd_probe(struct efx_nic *efx) /* Allocate space for maximum number of partitions */ parts = kcalloc(2, sizeof(*parts), GFP_KERNEL); + if (!parts) + return -ENOMEM; n_parts = 0; spi = &nic_data->spi_flash;