| Message ID | 1378639438-27686-5-git-send-email-mugunthanvnm@ti.com |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 09/08/2013 03:23 PM, Mugunthan V N wrote: > Add DT entries for the phy mode selection in AM33xx SoC using cpsw-phy-sel > driver. > Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> > --- > arch/arm/boot/dts/am33xx.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index f9c5da9..4359672 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -594,6 +594,12 @@ > /* Filled in by U-Boot */ > mac-address = [ 00 00 00 00 00 00 ]; > }; > + > + phy_sel: cpsw_phy_sel@44e10650 { Dashes are preferred to uderscores in the device tree names. > + compatible = "ti,am3352-cpsw-phy-sel"; > + reg= <0x44e10650 0x4>; > + reg-names = "gmii-sel"; > + }; WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sunday 08 September 2013 11:34 PM, Sergei Shtylyov wrote: > Hello. > > On 09/08/2013 03:23 PM, Mugunthan V N wrote: > >> Add DT entries for the phy mode selection in AM33xx SoC using >> cpsw-phy-sel >> driver. > >> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> >> --- >> arch/arm/boot/dts/am33xx.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) > >> diff --git a/arch/arm/boot/dts/am33xx.dtsi >> b/arch/arm/boot/dts/am33xx.dtsi >> index f9c5da9..4359672 100644 >> --- a/arch/arm/boot/dts/am33xx.dtsi >> +++ b/arch/arm/boot/dts/am33xx.dtsi >> @@ -594,6 +594,12 @@ >> /* Filled in by U-Boot */ >> mac-address = [ 00 00 00 00 00 00 ]; >> }; >> + >> + phy_sel: cpsw_phy_sel@44e10650 { > > Dashes are preferred to uderscores in the device tree names. I tried with dashes but i get the below error. $ make CROSS_COMPILE=arm-linux-gnueabihf- ARCH=arm dtbs DTC arch/arm/boot/dts/am335x-evm.dtb Error: arch/arm/boot/dts/am33xx.dtsi:598.11-12 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [arch/arm/boot/dts/am335x-evm.dtb] Error 1 make: *** [dtbs] Error 2 Regards Mugunthan V N -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 09-09-2013 10:42, Mugunthan V N wrote: >>> Add DT entries for the phy mode selection in AM33xx SoC using >>> cpsw-phy-sel >>> driver. >>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> >>> --- >>> arch/arm/boot/dts/am33xx.dtsi | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> diff --git a/arch/arm/boot/dts/am33xx.dtsi >>> b/arch/arm/boot/dts/am33xx.dtsi >>> index f9c5da9..4359672 100644 >>> --- a/arch/arm/boot/dts/am33xx.dtsi >>> +++ b/arch/arm/boot/dts/am33xx.dtsi >>> @@ -594,6 +594,12 @@ >>> /* Filled in by U-Boot */ >>> mac-address = [ 00 00 00 00 00 00 ]; >>> }; >>> + >>> + phy_sel: cpsw_phy_sel@44e10650 { >> Dashes are preferred to uderscores in the device tree names. > I tried with dashes but i get the below error. > $ make CROSS_COMPILE=arm-linux-gnueabihf- ARCH=arm dtbs > DTC arch/arm/boot/dts/am335x-evm.dtb > Error: arch/arm/boot/dts/am33xx.dtsi:598.11-12 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [arch/arm/boot/dts/am335x-evm.dtb] Error 1 > make: *** [dtbs] Error 2 Hm, perhaps the dashes can't be used in the labels but I was talking of the names. Dashes in the node names should be definitely valid. > Regards > Mugunthan V N WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index f9c5da9..4359672 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -594,6 +594,12 @@ /* Filled in by U-Boot */ mac-address = [ 00 00 00 00 00 00 ]; }; + + phy_sel: cpsw_phy_sel@44e10650 { + compatible = "ti,am3352-cpsw-phy-sel"; + reg= <0x44e10650 0x4>; + reg-names = "gmii-sel"; + }; }; ocmcram: ocmcram@40300000 {
Add DT entries for the phy mode selection in AM33xx SoC using cpsw-phy-sel driver. Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> --- arch/arm/boot/dts/am33xx.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)