| Message ID | 1584463806-15788-1-git-send-email-martin.fuzzey@flowbird.group |
|---|---|
| Headers | show |
| Series | Fix Wake on lan with FEC on i.MX6 | expand |
From: Martin Fuzzey <martin.fuzzey@flowbird.group> Sent: Wednesday, March 18, 2020 12:50 AM > This series fixes WoL support with the FEC on i.MX6 The support was already > in mainline but seems to have bitrotted somewhat. > > Only tested with i.MX6DL The most of code is reused from nxp internal tree, If you refer the patches from nxp kernel tree, please keep the signed-off with original author. > > > Martin Fuzzey (4): > net: fec: set GPR bit on suspend by DT connfiguration. > ARM: dts: imx6: Use gpc for FEC interrupt controller to fix wake on > LAN. > dt-bindings: fec: document the new fsl,stop-mode property > ARM: dts: imx6: add fsl,stop-mode property. > > Documentation/devicetree/bindings/net/fsl-fec.txt | 5 ++ > arch/arm/boot/dts/imx6qdl.dtsi | 6 +- > drivers/net/ethernet/freescale/fec.h | 7 +++ > drivers/net/ethernet/freescale/fec_main.c | 72 > ++++++++++++++++++++--- > 4 files changed, 80 insertions(+), 10 deletions(-) > > -- > 1.9.1
Hi Andy, On Wed, 18 Mar 2020 at 07:28, Andy Duan <fugang.duan@nxp.com> wrote: > > > The most of code is reused from nxp internal tree, > If you refer the patches from nxp kernel tree, please > keep the signed-off with original author. > Ok, looks like it was originally from you, should I add your current email address or the one at the time (B38611@freescale.com)? Actually I don't have the NXP tree but a Digi tree, which is probably based on it. I think, generally, this is a bit of a grey area. While I would always keep a SoB if I base a patch on an old mailing list patch submission (and contact the person if possible first to ask) I'm not sure if a SoB from a "random git tree" indicates they wish a mainline submission with their name (some people may want credit and others not want to be considered responsible for bugs...). I didn't see a submission of this version (with the gpr information coming from the DT) on the mailing lists, only the initial version using the platform callback that was NAKd (I may have missed it though). Regards, Martin
From: Fuzzey, Martin <martin.fuzzey@flowbird.group> Sent: Wednesday, March 18, 2020 4:28 PM > Hi Andy, > > > On Wed, 18 Mar 2020 at 07:28, Andy Duan <fugang.duan@nxp.com> wrote: > > > > > > The most of code is reused from nxp internal tree, If you refer the > > patches from nxp kernel tree, please keep the signed-off with original > > author. > > It doesn't matter, I am happy you upstream the patch. Just keep: Signed-off-by: Fugang Duan <fugang.duan@nxp.com> > > Ok, looks like it was originally from you, should I add your current email > address or the one at the time (B38611@freescale.com)? > > Actually I don't have the NXP tree but a Digi tree, which is probably based on > it. > > I think, generally, this is a bit of a grey area. > > While I would always keep a SoB if I base a patch on an old mailing list patch > submission (and contact the person if possible first to > ask) I'm not sure if a SoB from a "random git tree" indicates they wish a > mainline submission with their name (some people may want credit and > others not want to be considered responsible for bugs...). > I didn't see a submission of this version (with the gpr information coming from > the DT) on the mailing lists, only the initial version using the platform callback > that was NAKd (I may have missed it though). > > Regards, > > Martin
This series fixes WoL support with the FEC on i.MX6 The support was already in mainline but seems to have bitrotted somewhat. Only tested with i.MX6DL Martin Fuzzey (4): net: fec: set GPR bit on suspend by DT connfiguration. ARM: dts: imx6: Use gpc for FEC interrupt controller to fix wake on LAN. dt-bindings: fec: document the new fsl,stop-mode property ARM: dts: imx6: add fsl,stop-mode property. Documentation/devicetree/bindings/net/fsl-fec.txt | 5 ++ arch/arm/boot/dts/imx6qdl.dtsi | 6 +- drivers/net/ethernet/freescale/fec.h | 7 +++ drivers/net/ethernet/freescale/fec_main.c | 72 ++++++++++++++++++++--- 4 files changed, 80 insertions(+), 10 deletions(-)