From patchwork Tue Mar 17 16:50:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Fuzzey X-Patchwork-Id: 1256688 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=flowbird.group Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=flowbird.group header.i=@flowbird.group header.a=rsa-sha256 header.s=google header.b=Vkeii+Ts; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48hfKy1nwMz9sSL for ; Wed, 18 Mar 2020 03:50:14 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726881AbgCQQuM (ORCPT ); Tue, 17 Mar 2020 12:50:12 -0400 Received: from mail-wm1-f100.google.com ([209.85.128.100]:51091 "EHLO mail-wm1-f100.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726819AbgCQQuM (ORCPT ); Tue, 17 Mar 2020 12:50:12 -0400 Received: by mail-wm1-f100.google.com with SMTP id z13so46239wml.0 for ; Tue, 17 Mar 2020 09:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/qLuw9eKcX9ERX0e5EbOyuV/VdB/pnRMXE+XeLVt+RA=; b=Vkeii+TsYFOKtKlBrkWuKOyWMEOh5M4Ia9DiFJY/d8mTfO0Fg6cka2LyLO8KG1XbwI Edr2CRomRUDRPmY28odQz/yq8/YXjINK3i9Ut+vpHiD0weV4ZPL0SCSWY/hImVFMPMHf GKNaPAGhb4tFrFPe9UK+tr6UWSz2lOo2LETVdEpuC1H09zaTQvn6DBlelOkIm3uisFlt HctESooxOqv83AOldGlxJXfq8o/mOvy6Sy7px2BsbS1Jc/fN7S7bzG7m9OpiSHTUPW3f PBJGss9rFHlZxX1u/hFSc67lqyl/vMavM9Fsw3dWVS3AkvI73La2lpLQzS9SQsgfwdu/ ci3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/qLuw9eKcX9ERX0e5EbOyuV/VdB/pnRMXE+XeLVt+RA=; b=KmirLe/CB4FNlOEmzeVEKbt2L4zXK0Hp8t/WtZj4R+HjKqaadH9Fn3f3R1jfQkgEMy iez03TxpkYckuIDeeuVCw5qCRoPdfN0/F8UVup01tGPS1Lxft6NVlnHX8TU0bLD9dxpb ASRjhW4gkopPapiiyPKQvdcizBt73QHNHqHkI17AqPFwIdnhaqhd2zkiY2QZ4/nIf439 kNK5/XAjMlYaNLtHVKJpb3811qEfcd9YasAXkOnAbVSQXyCYJBaa9OpRXEp/NtaFGdq3 ucg5R504QA7WlVbnu7JViXIZg4CXvw8HlY/L1dDd95dHOvvlg4bLWyxlmRPzQjmvHhGm N5Lw== X-Gm-Message-State: ANhLgQ2Xgv49uwlp8i6iAyTLVymSjeToTTlnKPJFziZQslUWIe6YGJRn F3smxZn+08ruwlmWyY7+hH7NcExdnHHp2WIPqyoQXibyLYWS X-Google-Smtp-Source: ADFU+vuDoHCGd3/qo1wkUNqXABgauZq3sw0Ba2Nx2etnwHKoCA+NhfAit5NN9dwlZwzS9pmx1kILV23Al5PC X-Received: by 2002:a1c:f008:: with SMTP id a8mr178661wmb.81.1584463808751; Tue, 17 Mar 2020 09:50:08 -0700 (PDT) Received: from mail.besancon.parkeon.com ([185.149.63.251]) by smtp-relay.gmail.com with ESMTPS id i203sm44306wma.51.2020.03.17.09.50.08 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 17 Mar 2020 09:50:08 -0700 (PDT) X-Relaying-Domain: flowbird.group Received: from [172.16.13.134] (port=56876 helo=PC12445-BES.dynamic.besancon.parkeon.com) by mail.besancon.parkeon.com with esmtp (Exim 4.71) (envelope-from ) id 1jEFPs-0000dJ-AU; Tue, 17 Mar 2020 17:50:08 +0100 From: Martin Fuzzey To: Fugang Duan , Rob Herring , Shawn Guo , "David S. Miller" Cc: netdev@vger.kernel.org, Fabio Estevam , linux-kernel@vger.kernel.org, Sascha Hauer , NXP Linux Team , devicetree@vger.kernel.org Subject: [PATCH 1/4] net: fec: set GPR bit on suspend by DT connfiguration. Date: Tue, 17 Mar 2020 17:50:03 +0100 Message-Id: <1584463806-15788-2-git-send-email-martin.fuzzey@flowbird.group> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1584463806-15788-1-git-send-email-martin.fuzzey@flowbird.group> References: <1584463806-15788-1-git-send-email-martin.fuzzey@flowbird.group> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On some SoCs, such as the i.MX6, it is necessary to set a bit in the SoC level GPR register before suspending for wake on lan to work. The fec platform callback sleep_mode_enable was intended to allow this but the platform implementation was NAK'd back in 2015 [1] This means that, currently, wake on lan is broken on mainline for the i.MX6 at least. So implement the required bit setting in the fec driver by itself by adding a new optional DT property indicating the register and bit to set. [1] https://www.spinics.net/lists/netdev/msg310922.html Signed-off-by: Martin Fuzzey --- drivers/net/ethernet/freescale/fec.h | 7 +++ drivers/net/ethernet/freescale/fec_main.c | 72 ++++++++++++++++++++++++++++--- 2 files changed, 72 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h index f79e57f..d89568f 100644 --- a/drivers/net/ethernet/freescale/fec.h +++ b/drivers/net/ethernet/freescale/fec.h @@ -488,6 +488,12 @@ struct fec_enet_priv_rx_q { struct sk_buff *rx_skbuff[RX_RING_SIZE]; }; +struct fec_stop_mode_gpr { + struct regmap *gpr; + u8 reg; + u8 bit; +}; + /* The FEC buffer descriptors track the ring buffers. The rx_bd_base and * tx_bd_base always point to the base of the buffer descriptors. The * cur_rx and cur_tx point to the currently available buffer. @@ -562,6 +568,7 @@ struct fec_enet_private { int hwts_tx_en; struct delayed_work time_keep; struct regulator *reg_phy; + struct fec_stop_mode_gpr stop_gpr; unsigned int tx_align; unsigned int rx_align; diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 23c5fef..3c78124 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -62,6 +62,8 @@ #include #include #include +#include +#include #include #include @@ -1092,11 +1094,28 @@ static void fec_enet_reset_skb(struct net_device *ndev) } +static void fec_enet_stop_mode(struct fec_enet_private *fep, bool enabled) +{ + struct fec_platform_data *pdata = fep->pdev->dev.platform_data; + struct fec_stop_mode_gpr *stop_gpr = &fep->stop_gpr; + + if (stop_gpr->gpr) { + if (enabled) + regmap_update_bits(stop_gpr->gpr, stop_gpr->reg, + BIT(stop_gpr->bit), + BIT(stop_gpr->bit)); + else + regmap_update_bits(stop_gpr->gpr, stop_gpr->reg, + BIT(stop_gpr->bit), 0); + } else if (pdata && pdata->sleep_mode_enable) { + pdata->sleep_mode_enable(enabled); + } +} + static void fec_stop(struct net_device *ndev) { struct fec_enet_private *fep = netdev_priv(ndev); - struct fec_platform_data *pdata = fep->pdev->dev.platform_data; u32 rmii_mode = readl(fep->hwp + FEC_R_CNTRL) & (1 << 8); u32 val; @@ -1125,9 +1144,7 @@ static void fec_enet_reset_skb(struct net_device *ndev) val = readl(fep->hwp + FEC_ECNTRL); val |= (FEC_ECR_MAGICEN | FEC_ECR_SLEEP); writel(val, fep->hwp + FEC_ECNTRL); - - if (pdata && pdata->sleep_mode_enable) - pdata->sleep_mode_enable(true); + fec_enet_stop_mode(fep, true); } writel(fep->phy_speed, fep->hwp + FEC_MII_SPEED); @@ -3397,6 +3414,43 @@ static int fec_enet_get_irq_cnt(struct platform_device *pdev) return irq_cnt; } +static int fec_enet_of_parse_stop_mode(struct fec_enet_private *fep, + struct device_node *np) +{ + static const char prop[] = "fsl,stop-mode"; + struct of_phandle_args args; + int ret; + + ret = of_parse_phandle_with_fixed_args(np, prop, 2, 0, &args); + if (ret == -ENOENT) + return 0; + if (ret) + return ret; + + if (args.args_count != 2) { + dev_err(&fep->pdev->dev, + "Bad %s args want gpr offset, bit\n", prop); + ret = -EINVAL; + goto out; + } + + fep->stop_gpr.gpr = syscon_node_to_regmap(args.np); + if (IS_ERR(fep->stop_gpr.gpr)) { + dev_err(&fep->pdev->dev, "could not find gpr regmap\n"); + ret = PTR_ERR(fep->stop_gpr.gpr); + fep->stop_gpr.gpr = NULL; + goto out; + } + + fep->stop_gpr.reg = args.args[0]; + fep->stop_gpr.bit = args.args[1]; + +out: + of_node_put(args.np); + + return ret; +} + static int fec_probe(struct platform_device *pdev) { @@ -3463,6 +3517,10 @@ static int fec_enet_get_irq_cnt(struct platform_device *pdev) if (of_get_property(np, "fsl,magic-packet", NULL)) fep->wol_flag |= FEC_WOL_HAS_MAGIC_PACKET; + ret = fec_enet_of_parse_stop_mode(fep, np); + if (ret) + goto failed_stop_mode; + phy_node = of_parse_phandle(np, "phy-handle", 0); if (!phy_node && of_phy_is_fixed_link(np)) { ret = of_phy_register_fixed_link(np); @@ -3631,6 +3689,7 @@ static int fec_enet_get_irq_cnt(struct platform_device *pdev) if (of_phy_is_fixed_link(np)) of_phy_deregister_fixed_link(np); of_node_put(phy_node); +failed_stop_mode: failed_phy: dev_id--; failed_ioremap: @@ -3708,7 +3767,6 @@ static int __maybe_unused fec_resume(struct device *dev) { struct net_device *ndev = dev_get_drvdata(dev); struct fec_enet_private *fep = netdev_priv(ndev); - struct fec_platform_data *pdata = fep->pdev->dev.platform_data; int ret; int val; @@ -3726,8 +3784,8 @@ static int __maybe_unused fec_resume(struct device *dev) goto failed_clk; } if (fep->wol_flag & FEC_WOL_FLAG_ENABLE) { - if (pdata && pdata->sleep_mode_enable) - pdata->sleep_mode_enable(false); + fec_enet_stop_mode(fep, false); + val = readl(fep->hwp + FEC_ECNTRL); val &= ~(FEC_ECR_MAGICEN | FEC_ECR_SLEEP); writel(val, fep->hwp + FEC_ECNTRL); From patchwork Tue Mar 17 16:50:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Fuzzey X-Patchwork-Id: 1256690 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=flowbird.group Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=flowbird.group header.i=@flowbird.group header.a=rsa-sha256 header.s=google header.b=MQR3s3pr; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48hfL16FwGz9sSM for ; Wed, 18 Mar 2020 03:50:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726903AbgCQQuO (ORCPT ); Tue, 17 Mar 2020 12:50:14 -0400 Received: from mail-wr1-f99.google.com ([209.85.221.99]:45606 "EHLO mail-wr1-f99.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726824AbgCQQuN (ORCPT ); Tue, 17 Mar 2020 12:50:13 -0400 Received: by mail-wr1-f99.google.com with SMTP id t2so16567960wrx.12 for ; Tue, 17 Mar 2020 09:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=B45/nUfOtmmwVmpZUX1HJqLwFm+AFKdfWI8i6Ywg6f8=; b=MQR3s3prG83alxU3D/Cb53vMjAZpfe3c+nj12l08b+Iv4fGHT824TkeGL5LTwFw0ff 5VIfeHCzUni9GRAW7Kylhm52QsqygNISP19LOB7y3+TWJ3S5PGz58rqOKu4FK01DRXcM 25oQ1BKMyDJC349vdU/J5s2pwqGtZ0Urq9zKu+/yCqERvyStILze4KqcXMgdYd4bsBt6 lrLeTDmRMDKr9tdakHKvtAQU370zYrlJNmX5Bz4PZHqU/prgdL7wD1APvD8d3cgJ+jaE 4qjO/UYF3T9dZKFuKx1UzjVPo9cA3b6AXVw1pCvtqbU8lV7aKgq4CYOSXyI+hNB7ACWr BC5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=B45/nUfOtmmwVmpZUX1HJqLwFm+AFKdfWI8i6Ywg6f8=; b=aeK2z6KzJ6oeeWZ90oGmLHwhON8KNeHnypzuyx9yhcJFrxQWpljIg79t6ykLiX6rkR NOE9b4fXDT9PcA2S0m3tISfSmZDthLq0RKcTYMTCnSygsDGVSfcv5bTftD4RGfVScPKJ p8ICIrKc2uCgtjo7a0vKVG6CSO9gySU/sQ+z1+1dHKbgGe4Xyh5VsH/N3yCaR+MvYRAi fiDnsYhFQ43OjwuVBaDSSTSi9oplazlq4X+VpJyTVRMHsKKIwSCHlTMkIehT2/yItEKG X/3IHpnRLov3jCovHiGfxIjnfBBMy9CcUkWQsvU9WYD0fdZpldDIJAcfwUcSUbkV8Sbs Jg+w== X-Gm-Message-State: ANhLgQ22ii401DQH6/bWSO/bl8Omffngygry3ZurDP5IXmXOkP95viMG BOvv79kKCuq2QthllOCmsMqmCQZDihL99c1YzDV1sl8zHqk3 X-Google-Smtp-Source: ADFU+vtKvfOkBmGNK9FyHWUoAyk6vdyfZ1ec0Ho5dvQeINcuYSl4oJMECGNCB9ibYkr3JmuiaRGCOH7ZRSyi X-Received: by 2002:adf:d0c2:: with SMTP id z2mr6857642wrh.223.1584463809425; Tue, 17 Mar 2020 09:50:09 -0700 (PDT) Received: from mail.besancon.parkeon.com ([185.149.63.251]) by smtp-relay.gmail.com with ESMTPS id s14sm59992wru.87.2020.03.17.09.50.09 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 17 Mar 2020 09:50:09 -0700 (PDT) X-Relaying-Domain: flowbird.group Received: from [172.16.13.134] (port=56876 helo=PC12445-BES.dynamic.besancon.parkeon.com) by mail.besancon.parkeon.com with esmtp (Exim 4.71) (envelope-from ) id 1jEFPt-0000dJ-1N; Tue, 17 Mar 2020 17:50:09 +0100 From: Martin Fuzzey To: Fugang Duan , Rob Herring , Shawn Guo , "David S. Miller" Cc: netdev@vger.kernel.org, Fabio Estevam , linux-kernel@vger.kernel.org, Sascha Hauer , NXP Linux Team , devicetree@vger.kernel.org Subject: [PATCH 2/4] ARM: dts: imx6: Use gpc for FEC interrupt controller to fix wake on LAN. Date: Tue, 17 Mar 2020 17:50:04 +0100 Message-Id: <1584463806-15788-3-git-send-email-martin.fuzzey@flowbird.group> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1584463806-15788-1-git-send-email-martin.fuzzey@flowbird.group> References: <1584463806-15788-1-git-send-email-martin.fuzzey@flowbird.group> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In order to wake from suspend by ethernet magic packets the GPC must be used as intc does not have wakeup functionality. But the FEC DT node currently uses interrupt-extended, specificying intc, this breaking WoL. This problem is probably fallout from the stacked domain conversion as intc used to chain to GPC. So replace "interrupts-extended" by "interrupts" to use the default parent which is GPC. Fixes: b923ff6af0d5 ("ARM: imx6: convert GPC to stacked domains") Signed-off-by: Martin Fuzzey --- arch/arm/boot/dts/imx6qdl.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index e6b4b85..bc488df 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -1039,9 +1039,8 @@ compatible = "fsl,imx6q-fec"; reg = <0x02188000 0x4000>; interrupt-names = "int0", "pps"; - interrupts-extended = - <&intc 0 118 IRQ_TYPE_LEVEL_HIGH>, - <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <0 118 IRQ_TYPE_LEVEL_HIGH>, + <0 119 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6QDL_CLK_ENET>, <&clks IMX6QDL_CLK_ENET>, <&clks IMX6QDL_CLK_ENET_REF>; From patchwork Tue Mar 17 16:50:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Fuzzey X-Patchwork-Id: 1256689 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=flowbird.group Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=flowbird.group header.i=@flowbird.group header.a=rsa-sha256 header.s=google header.b=SCcPbUq3; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48hfL10jq3z9sRY for ; Wed, 18 Mar 2020 03:50:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726913AbgCQQuO (ORCPT ); Tue, 17 Mar 2020 12:50:14 -0400 Received: from mail-wr1-f100.google.com ([209.85.221.100]:41522 "EHLO mail-wr1-f100.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726864AbgCQQuN (ORCPT ); Tue, 17 Mar 2020 12:50:13 -0400 Received: by mail-wr1-f100.google.com with SMTP id f11so9839270wrp.8 for ; Tue, 17 Mar 2020 09:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=W+6ZKJBJf+pKwV43v7D0zXLM6cx+OowEeRYTF5Vw6ZI=; b=SCcPbUq30tR/prj61InCo+jM2BXD3s60F25UdjYzuRQplgzUsltf69ymeBoRzIGEb0 vtE9HsnpsSoXPVDZlyYzcw0wOTWlg+LFQ3J4cmoAKvVe2lIGr1AME+wH9LWyl6ECdkVM dZcR0yu7xcpgcBAEYF7/IBr6ljO+51N+9D4OUq42XvchQ3rXDK5Z1yO6tMJ3fkuRyrrQ 8H5jtFeTC+UJNRqFXAqh6mSFAYuiHM6dAeoGBu3GAcae6jdbEIyeO5GKH9FcAUYcCzxe BOU+9LH9hJZ2j+o6OLA4qyPooBafGPTkK1WeCO4ri4Q0nEz8bIKVfXgGSOrW91M54usT ps9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=W+6ZKJBJf+pKwV43v7D0zXLM6cx+OowEeRYTF5Vw6ZI=; b=rYIqd5Z2jfc3hYzEP3GsDMASdAS0apLhnqbxIYNITuMv3OPhzQHTBcqSvJcLT9P7h7 CletcOmO5ZkgRKRx7DKjRdhsaZcDAtC24oqFke/YMB6GEjOE+1X+q4ZHirueAo5eFpHB IMlBW5A+7VjFjbFkxp8nKxkxXtofuYIGnHLdHenevcPdwbQdfNubZQgSt+juj4U1ihqQ qoyHCtQQI6fH2oRVCgunyQNOePlNOQ/K56k10Ye7RX9r1Y9M1EGpU6kFXX1fvwctybo6 7LSBNKMNjgwy/lad72lUm0wdA23Ytj/1ZOO85qHFYeTTQaMpT7hFOIw67EW+HkQXkAbf A+bg== X-Gm-Message-State: ANhLgQ3wPAqccXeu3ujZ+goevAmbep64RYzxpsQgbZyMHxhvnkCvanC0 w6dtar/mKNzQv247pAIZMbMNsdfERfXBT7FMRE8Py5e8TlX1 X-Google-Smtp-Source: ADFU+vszNHfESmANhggvCujeZijt/jiQU/OqttiEYWULD0g88JMltQ686sxPnonItDyeMlLJfLJPdRvN4SRh X-Received: by 2002:a5d:52d0:: with SMTP id r16mr6758202wrv.379.1584463810086; Tue, 17 Mar 2020 09:50:10 -0700 (PDT) Received: from mail.besancon.parkeon.com ([185.149.63.251]) by smtp-relay.gmail.com with ESMTPS id r5sm64059wrt.7.2020.03.17.09.50.09 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 17 Mar 2020 09:50:10 -0700 (PDT) X-Relaying-Domain: flowbird.group Received: from [172.16.13.134] (port=56876 helo=PC12445-BES.dynamic.besancon.parkeon.com) by mail.besancon.parkeon.com with esmtp (Exim 4.71) (envelope-from ) id 1jEFPt-0000dJ-Ml; Tue, 17 Mar 2020 17:50:09 +0100 From: Martin Fuzzey To: Fugang Duan , Rob Herring , Shawn Guo , "David S. Miller" Cc: netdev@vger.kernel.org, Fabio Estevam , linux-kernel@vger.kernel.org, Sascha Hauer , NXP Linux Team , devicetree@vger.kernel.org Subject: [PATCH 3/4] dt-bindings: fec: document the new fsl, stop-mode property Date: Tue, 17 Mar 2020 17:50:05 +0100 Message-Id: <1584463806-15788-4-git-send-email-martin.fuzzey@flowbird.group> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1584463806-15788-1-git-send-email-martin.fuzzey@flowbird.group> References: <1584463806-15788-1-git-send-email-martin.fuzzey@flowbird.group> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This property allows the appropriate GPR register bit to be set for wake on lan support. Signed-off-by: Martin Fuzzey --- Documentation/devicetree/bindings/net/fsl-fec.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt index 5b88fae0..bd0ef5e 100644 --- a/Documentation/devicetree/bindings/net/fsl-fec.txt +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt @@ -19,6 +19,11 @@ Optional properties: number to 1. - fsl,magic-packet : If present, indicates that the hardware supports waking up via magic packet. +- fsl,stop-mode: register bits of stop mode control, the format is + <&gpr reg bit>. + gpr is the phandle to general purpose register node. + reg is the gpr register offset for the stop request. + bit is the bit offset for the stop request. - fsl,err006687-workaround-present: If present indicates that the system has the hardware workaround for ERR006687 applied and does not need a software workaround. From patchwork Tue Mar 17 16:50:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Fuzzey X-Patchwork-Id: 1256692 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=flowbird.group Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=flowbird.group header.i=@flowbird.group header.a=rsa-sha256 header.s=google header.b=LKMnOP59; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48hfL75zd1z9sSL for ; Wed, 18 Mar 2020 03:50:23 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726922AbgCQQuU (ORCPT ); Tue, 17 Mar 2020 12:50:20 -0400 Received: from mail-lj1-f228.google.com ([209.85.208.228]:35718 "EHLO mail-lj1-f228.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726856AbgCQQuN (ORCPT ); Tue, 17 Mar 2020 12:50:13 -0400 Received: by mail-lj1-f228.google.com with SMTP id u12so23728782ljo.2 for ; Tue, 17 Mar 2020 09:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=evj4d0V6zpXsfSXOnl0C5Tn/QOdwXKQU5BTSPlnFegk=; b=LKMnOP59KoyxHHgA43wSg0vYtKMMlf+6CHG7yVovbtWy7miYzxYL1Uhgm7eYcIn7nm D95mX62KcwLQg10mi9DsMSXdhLDICSZ8kXioMF49aS1UnGT9pheUV4KBEgZHt0cAXwY6 WC1vmMn4K+J7INIslhfFR+uxZMJKz1GGsaUY78K8FQgPj7jYoq0sLXKd6jro1oaIxuYe 6w20mlkNGYKDFjktFijUHswhMSgs8cpUQQRf4je9oP6+3R7jKNIEGyAN9mC/Ad++ecWj NACNurJhQa3CCrCFwxVYKPvIDQZPaZkJcWLdoHRIiJLUap7itpslyz2ehw/wxUzrwpXh Zkpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=evj4d0V6zpXsfSXOnl0C5Tn/QOdwXKQU5BTSPlnFegk=; b=ekQU6CCgMfnEXe5GcO/ySTu95qrRB+3qLxXtrtZ4m951bitYz+xH4np7uOueU0kCf/ 1Cr03Rp5YV1oL8AQIH0Q6TzHE9ogloHCwH0YSl3WfkAAVmxsMwtpN8+abT41estOSDAb KcVxlbOdzntdYeIHGCCGWun8p3Sl1MIRPna1B+z2q3mmFh+hdCQ99hLToSxoU0tixxfB J0hhBJB558uAUpNOAurTAvD+QspXHNrJhswR5dkDP6BPO0+cf4LN/iIje64rGXUUZnLs iKhNVNdvEhhjzd1S6FxJUcUagc5GcaqbC0s/QuIhNOWqIo1sxEFBskK/+5ZkTCLAiNRC secg== X-Gm-Message-State: ANhLgQ2kw3uR38od9v75qbdP8TiyPT9DddrCawPyuwxSTORvcLzd/48W ZZtxsrWrJ5YMp++yFNCb+NeSPm2q8199j5AutY2fQtYkbuvw X-Google-Smtp-Source: ADFU+vst4+YLm4+TecIAr8Y9a4YBFV0tjg8Q0cTN8eC53ZXZGkwdowxtmQVzVsRMuQLu+vq3/hq480X3rORk X-Received: by 2002:a2e:89c9:: with SMTP id c9mr3483335ljk.181.1584463811099; Tue, 17 Mar 2020 09:50:11 -0700 (PDT) Received: from mail.besancon.parkeon.com ([185.149.63.251]) by smtp-relay.gmail.com with ESMTPS id e20sm13727lfn.29.2020.03.17.09.50.10 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 17 Mar 2020 09:50:11 -0700 (PDT) X-Relaying-Domain: flowbird.group Received: from [172.16.13.134] (port=56876 helo=PC12445-BES.dynamic.besancon.parkeon.com) by mail.besancon.parkeon.com with esmtp (Exim 4.71) (envelope-from ) id 1jEFPu-0000dJ-BW; Tue, 17 Mar 2020 17:50:10 +0100 From: Martin Fuzzey To: Fugang Duan , Rob Herring , Shawn Guo , "David S. Miller" Cc: netdev@vger.kernel.org, Fabio Estevam , linux-kernel@vger.kernel.org, Sascha Hauer , NXP Linux Team , devicetree@vger.kernel.org Subject: [PATCH 4/4] ARM: dts: imx6: add fsl,stop-mode property. Date: Tue, 17 Mar 2020 17:50:06 +0100 Message-Id: <1584463806-15788-5-git-send-email-martin.fuzzey@flowbird.group> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1584463806-15788-1-git-send-email-martin.fuzzey@flowbird.group> References: <1584463806-15788-1-git-send-email-martin.fuzzey@flowbird.group> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is required for wake on lan on i.MX6 Signed-off-by: Martin Fuzzey --- arch/arm/boot/dts/imx6qdl.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index bc488df..49c0527 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -1045,6 +1045,7 @@ <&clks IMX6QDL_CLK_ENET>, <&clks IMX6QDL_CLK_ENET_REF>; clock-names = "ipg", "ahb", "ptp"; + fsl,stop-mode = <&gpr 0x34 27>; status = "disabled"; };