| Message ID | be07403806abc56ec027f6d47468411876e18bb5.1560267983.git.christophe.leroy@c-s.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b7f8b440f3001cc1775c028f0a783786113c2ae3 |
| Headers | show |
| Series | powerpc/32s: fix initial setup of segment registers on secondary CPU | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (a3bf9fbdad600b1e4335dd90979f8d6072e4f602) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
Le 11/06/2019 à 17:47, Christophe Leroy a écrit : > The patch referenced below moved the loading of segment registers > out of load_up_mmu() in order to do it earlier in the boot sequence. > However, the secondary CPU still needs it to be done when loading up > the MMU. > > Reported-by: Erhard F. <erhard_f@mailbox.org> > Fixes: 215b823707ce ("powerpc/32s: set up an early static hash table for KASAN") Cc: stable@vger.kernel.org > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> > --- > arch/powerpc/kernel/head_32.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S > index 1d5f1bd0dacd..f255e22184b4 100644 > --- a/arch/powerpc/kernel/head_32.S > +++ b/arch/powerpc/kernel/head_32.S > @@ -752,6 +752,7 @@ __secondary_start: > stw r0,0(r3) > > /* load up the MMU */ > + bl load_segment_registers > bl load_up_mmu > > /* ptr to phys current thread */ >
Christophe Leroy <christophe.leroy@c-s.fr> writes: > Le 11/06/2019 à 17:47, Christophe Leroy a écrit : >> The patch referenced below moved the loading of segment registers >> out of load_up_mmu() in order to do it earlier in the boot sequence. >> However, the secondary CPU still needs it to be done when loading up >> the MMU. >> >> Reported-by: Erhard F. <erhard_f@mailbox.org> >> Fixes: 215b823707ce ("powerpc/32s: set up an early static hash table for KASAN") > > Cc: stable@vger.kernel.org Sorry patchwork didn't pick that up and I missed it. The AUTOSEL bot will probably pick it up anyway though. cheers >> diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S >> index 1d5f1bd0dacd..f255e22184b4 100644 >> --- a/arch/powerpc/kernel/head_32.S >> +++ b/arch/powerpc/kernel/head_32.S >> @@ -752,6 +752,7 @@ __secondary_start: >> stw r0,0(r3) >> >> /* load up the MMU */ >> + bl load_segment_registers >> bl load_up_mmu >> >> /* ptr to phys current thread */ >>
Le 18/06/2019 à 14:31, Michael Ellerman a écrit : > Christophe Leroy <christophe.leroy@c-s.fr> writes: >> Le 11/06/2019 à 17:47, Christophe Leroy a écrit : >>> The patch referenced below moved the loading of segment registers >>> out of load_up_mmu() in order to do it earlier in the boot sequence. >>> However, the secondary CPU still needs it to be done when loading up >>> the MMU. >>> >>> Reported-by: Erhard F. <erhard_f@mailbox.org> >>> Fixes: 215b823707ce ("powerpc/32s: set up an early static hash table for KASAN") >> >> Cc: stable@vger.kernel.org > > Sorry patchwork didn't pick that up and I missed it. The AUTOSEL bot > will probably pick it up anyway though. Don't worry, this was unneeded because we added KASAN in 5.2. My mistake. Christophe > > cheers > >>> diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S >>> index 1d5f1bd0dacd..f255e22184b4 100644 >>> --- a/arch/powerpc/kernel/head_32.S >>> +++ b/arch/powerpc/kernel/head_32.S >>> @@ -752,6 +752,7 @@ __secondary_start: >>> stw r0,0(r3) >>> >>> /* load up the MMU */ >>> + bl load_segment_registers >>> bl load_up_mmu >>> >>> /* ptr to phys current thread */ >>>
diff --git a/arch/powerpc/kernel/head_32.S b/arch/powerpc/kernel/head_32.S index 1d5f1bd0dacd..f255e22184b4 100644 --- a/arch/powerpc/kernel/head_32.S +++ b/arch/powerpc/kernel/head_32.S @@ -752,6 +752,7 @@ __secondary_start: stw r0,0(r3) /* load up the MMU */ + bl load_segment_registers bl load_up_mmu /* ptr to phys current thread */
The patch referenced below moved the loading of segment registers out of load_up_mmu() in order to do it earlier in the boot sequence. However, the secondary CPU still needs it to be done when loading up the MMU. Reported-by: Erhard F. <erhard_f@mailbox.org> Fixes: 215b823707ce ("powerpc/32s: set up an early static hash table for KASAN") Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> --- arch/powerpc/kernel/head_32.S | 1 + 1 file changed, 1 insertion(+)