| Message ID | 2fed79b1154c872194f98bac4422c23918325e61.1611039590.git.christophe.leroy@csgroup.eu (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/47x: Disable 256k page size | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (41d8cb7ece7c81e4eb897ed7ec7d3c3d72fd0af4) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| snowpatch_ozlabs/needsstable | warning | Please consider tagging this patch for stable! |
Christophe Leroy <christophe.leroy@csgroup.eu> writes: > PPC47x_TLBE_SIZE isn't defined for 256k pages, so > this size of page shall not be selected for 47x. > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: e7f75ad01d59 ("powerpc/47x: Base ppc476 support") > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> > --- > arch/powerpc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index 107bb4319e0e..a685e42d3993 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -772,7 +772,7 @@ config PPC_64K_PAGES > > config PPC_256K_PAGES > bool "256k page size" > - depends on 44x && !STDBINUTILS > + depends on 44x && !STDBINUTILS && !PPC_47x Do we still need this STDBINUTILS thing? It's pretty gross, and I notice we have zero defconfigs which disable it, meaning it's only randconfig builds that will ever test 256K pages. Can we just drop it and say if you enable 256K pages you need to know what you're doing? cheers
Le 20/01/2021 à 06:45, Michael Ellerman a écrit : > Christophe Leroy <christophe.leroy@csgroup.eu> writes: >> PPC47x_TLBE_SIZE isn't defined for 256k pages, so >> this size of page shall not be selected for 47x. >> >> Reported-by: kernel test robot <lkp@intel.com> >> Fixes: e7f75ad01d59 ("powerpc/47x: Base ppc476 support") >> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> >> --- >> arch/powerpc/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig >> index 107bb4319e0e..a685e42d3993 100644 >> --- a/arch/powerpc/Kconfig >> +++ b/arch/powerpc/Kconfig >> @@ -772,7 +772,7 @@ config PPC_64K_PAGES >> >> config PPC_256K_PAGES >> bool "256k page size" >> - depends on 44x && !STDBINUTILS >> + depends on 44x && !STDBINUTILS && !PPC_47x > > Do we still need this STDBINUTILS thing? > > It's pretty gross, and I notice we have zero defconfigs which disable > it, meaning it's only randconfig builds that will ever test 256K pages. > > Can we just drop it and say if you enable 256K pages you need to know > what you're doing? I guess we can, yes. I'll send a patch for that. Christophe >
On Tue, 19 Jan 2021 07:00:00 +0000 (UTC), Christophe Leroy wrote: > PPC47x_TLBE_SIZE isn't defined for 256k pages, so > this size of page shall not be selected for 47x. Applied to powerpc/next. [1/1] powerpc/47x: Disable 256k page size https://git.kernel.org/powerpc/c/910a0cb6d259736a0c86e795d4c2f42af8d0d775 cheers
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 107bb4319e0e..a685e42d3993 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -772,7 +772,7 @@ config PPC_64K_PAGES config PPC_256K_PAGES bool "256k page size" - depends on 44x && !STDBINUTILS + depends on 44x && !STDBINUTILS && !PPC_47x help Make the page size 256k.
PPC47x_TLBE_SIZE isn't defined for 256k pages, so this size of page shall not be selected for 47x. Reported-by: kernel test robot <lkp@intel.com> Fixes: e7f75ad01d59 ("powerpc/47x: Base ppc476 support") Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> --- arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)