| Message ID | 20231129131919.2528517-1-mpe@ellerman.id.au (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 360f051d82ee0cc580edfffe9e8c0b93011ab86d |
| Headers | show |
| Series | [1/5] powerpc/suspend: Add prototype for do_after_copyback() | expand |
On Wed, Nov 29, 2023, at 14:19, Michael Ellerman wrote: > With HIBERNATION=y the build breaks with: > > arch/powerpc/kernel/swsusp_64.c:14:6: error: no previous prototype > for ‘do_after_copyback’ [-Werror=missing-prototypes] > 14 | void do_after_copyback(void) > | ^~~~~~~~~~~~~~~~~ > > do_after_copyback() is only called from asm, so there is no prototype, > nor any header where it makes sense to place one. Just add a prototype > in the C file to fix the build error. > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Thanks for helping out with the rest. For the series (aside from the very minor comment): Reviewed-by: Arnd Bergmann <arnd@arndb.de>
On Thu, 30 Nov 2023 00:19:15 +1100, Michael Ellerman wrote: > With HIBERNATION=y the build breaks with: > > arch/powerpc/kernel/swsusp_64.c:14:6: error: no previous prototype for ‘do_after_copyback’ [-Werror=missing-prototypes] > 14 | void do_after_copyback(void) > | ^~~~~~~~~~~~~~~~~ > > do_after_copyback() is only called from asm, so there is no prototype, > nor any header where it makes sense to place one. Just add a prototype > in the C file to fix the build error. > > [...] Applied to powerpc/next. [1/5] powerpc/suspend: Add prototype for do_after_copyback() https://git.kernel.org/powerpc/c/360f051d82ee0cc580edfffe9e8c0b93011ab86d [2/5] powerpc/512x: Make pdm360ng_init() static https://git.kernel.org/powerpc/c/24afc61990de29dd47be7642c196a173f6cc21fc [3/5] powerpc/512x: Fix missing prototype warnings https://git.kernel.org/powerpc/c/10feb8f9612239b665815807e950bcd999a75dd2 [4/5] powerpc/44x: Make ppc44x_idle_init() static https://git.kernel.org/powerpc/c/b90ad501715f2feb1b0bf97aa700adb39c78deb3 [5/5] powerpc/64s: Fix CONFIG_NUMA=n build https://git.kernel.org/powerpc/c/ede66cd22441820cbd399936bf84fdc4294bc7fa cheers
diff --git a/arch/powerpc/kernel/swsusp_64.c b/arch/powerpc/kernel/swsusp_64.c index 16ee3baaf09a..50fa8fc9ef95 100644 --- a/arch/powerpc/kernel/swsusp_64.c +++ b/arch/powerpc/kernel/swsusp_64.c @@ -11,6 +11,8 @@ #include <linux/interrupt.h> #include <linux/nmi.h> +void do_after_copyback(void); + void do_after_copyback(void) { iommu_restore();
With HIBERNATION=y the build breaks with: arch/powerpc/kernel/swsusp_64.c:14:6: error: no previous prototype for ‘do_after_copyback’ [-Werror=missing-prototypes] 14 | void do_after_copyback(void) | ^~~~~~~~~~~~~~~~~ do_after_copyback() is only called from asm, so there is no prototype, nor any header where it makes sense to place one. Just add a prototype in the C file to fix the build error. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- arch/powerpc/kernel/swsusp_64.c | 2 ++ 1 file changed, 2 insertions(+)