| Message ID | 20230613164145.50488-2-atrajeev@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | tool/perf/test: Fix shellcheck coding/formatting issues of test shell scripts | expand |
Em Tue, Jun 13, 2023 at 10:11:29PM +0530, Athira Rajeev escreveu: > From: Sourabh Jain <sourabhjain@linux.ibm.com> > > Script doesn't use sys library, so remove it. Please Cc the persons working on that file, I added Leo to the CC list of this message. Thanks, applied. - Arnaldo > Report by pylint: > W0611: Unused import sys (unused-import) > > Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> > Signed-off-by: Kajol Jain <kjain@linux.ibm.com> > Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com> > --- > tools/perf/scripts/python/arm-cs-trace-disasm.py | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/perf/scripts/python/arm-cs-trace-disasm.py b/tools/perf/scripts/python/arm-cs-trace-disasm.py > index 4339692a8d0b..d59ff53f1d94 100755 > --- a/tools/perf/scripts/python/arm-cs-trace-disasm.py > +++ b/tools/perf/scripts/python/arm-cs-trace-disasm.py > @@ -9,7 +9,6 @@ > from __future__ import print_function > import os > from os import path > -import sys > import re > from subprocess import * > from optparse import OptionParser, make_option > -- > 2.39.1 >
On Tue, Jun 13, 2023 at 04:54:08PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 13, 2023 at 10:11:29PM +0530, Athira Rajeev escreveu: > > From: Sourabh Jain <sourabhjain@linux.ibm.com> > > > > Script doesn't use sys library, so remove it. > > Please Cc the persons working on that file, I added Leo to the CC list > of this message. Thanks, Arnaldo & Athira. The change looks good to me. > Thanks, applied. Since have applied this patch, it's no need to give my review tag :) Thanks, Leo > - Arnaldo > > > Report by pylint: > > W0611: Unused import sys (unused-import) > > > > Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> > > Signed-off-by: Kajol Jain <kjain@linux.ibm.com> > > Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com> > > --- > > tools/perf/scripts/python/arm-cs-trace-disasm.py | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/tools/perf/scripts/python/arm-cs-trace-disasm.py b/tools/perf/scripts/python/arm-cs-trace-disasm.py > > index 4339692a8d0b..d59ff53f1d94 100755 > > --- a/tools/perf/scripts/python/arm-cs-trace-disasm.py > > +++ b/tools/perf/scripts/python/arm-cs-trace-disasm.py > > @@ -9,7 +9,6 @@ > > from __future__ import print_function > > import os > > from os import path > > -import sys > > import re > > from subprocess import * > > from optparse import OptionParser, make_option > > -- > > 2.39.1 > > > > -- > > - Arnaldo
Em Wed, Jun 14, 2023 at 09:59:14AM +0800, Leo Yan escreveu: > On Tue, Jun 13, 2023 at 04:54:08PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jun 13, 2023 at 10:11:29PM +0530, Athira Rajeev escreveu: > > > From: Sourabh Jain <sourabhjain@linux.ibm.com> > > > > > > Script doesn't use sys library, so remove it. > > > > Please Cc the persons working on that file, I added Leo to the CC list > > of this message. > > Thanks, Arnaldo & Athira. The change looks good to me. > > > Thanks, applied. > > Since have applied this patch, it's no need to give my review tag :) No, I usually can add a Reviewed-by tag even after having applied it to my local tree, as I still need to run tests before making it available via perf-tools-next, when I should not make any further changes. - Arnaldo > Thanks, > Leo > > > - Arnaldo > > > > > Report by pylint: > > > W0611: Unused import sys (unused-import) > > > > > > Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> > > > Signed-off-by: Kajol Jain <kjain@linux.ibm.com> > > > Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com> > > > --- > > > tools/perf/scripts/python/arm-cs-trace-disasm.py | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/tools/perf/scripts/python/arm-cs-trace-disasm.py b/tools/perf/scripts/python/arm-cs-trace-disasm.py > > > index 4339692a8d0b..d59ff53f1d94 100755 > > > --- a/tools/perf/scripts/python/arm-cs-trace-disasm.py > > > +++ b/tools/perf/scripts/python/arm-cs-trace-disasm.py > > > @@ -9,7 +9,6 @@ > > > from __future__ import print_function > > > import os > > > from os import path > > > -import sys > > > import re > > > from subprocess import * > > > from optparse import OptionParser, make_option > > > -- > > > 2.39.1 > > > > > > > -- > > > > - Arnaldo
On Tue, Jun 13, 2023 at 11:34:11PM -0300, Arnaldo Carvalho de Melo wrote: [...] > > Since have applied this patch, it's no need to give my review tag :) > > No, I usually can add a Reviewed-by tag even after having applied it to > my local tree, as I still need to run tests before making it available > via perf-tools-next, when I should not make any further changes. Understand now. Here is my review tag: Reviewed-by: Leo Yan <leo.yan@linaro.org>
diff --git a/tools/perf/scripts/python/arm-cs-trace-disasm.py b/tools/perf/scripts/python/arm-cs-trace-disasm.py index 4339692a8d0b..d59ff53f1d94 100755 --- a/tools/perf/scripts/python/arm-cs-trace-disasm.py +++ b/tools/perf/scripts/python/arm-cs-trace-disasm.py @@ -9,7 +9,6 @@ from __future__ import print_function import os from os import path -import sys import re from subprocess import * from optparse import OptionParser, make_option