diff mbox series

[1/7] MIPS: Remove DMA_PERDEV_COHERENT

Message ID 20230221124613.2859-2-jiaxun.yang@flygoat.com (mailing list archive)
State Handled Elsewhere
Headers show
Series MIPS DMA coherence fixes | expand

Commit Message

Jiaxun Yang Feb. 21, 2023, 12:46 p.m. UTC
As now we are always managing DMA coherence on per dev bias,
there is no need to have such option. And it's not selected
by any platform.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 arch/mips/Kconfig | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Christoph Hellwig Feb. 21, 2023, 5:56 p.m. UTC | #1
On Tue, Feb 21, 2023 at 12:46:07PM +0000, Jiaxun Yang wrote:
> As now we are always managing DMA coherence on per dev bias,
> there is no need to have such option. And it's not selected
> by any platform.

I think the real point here is that this is dead code, so it can
obviously go away, but:

>  config MIPS_GENERIC_KERNEL
>  	bool "Generic board-agnostic MIPS kernel"
> -	select ARCH_HAS_SETUP_DMA_OPS
>  	select MIPS_GENERIC
>  	select BOOT_RAW
>  	select BUILTIN_DTB
> @@ -1079,11 +1078,6 @@ config FW_CFE
>  config ARCH_SUPPORTS_UPROBES
>  	bool

> @@ -1097,6 +1091,7 @@ config DMA_NONCOHERENT
>  	select ARCH_HAS_DMA_PREP_COHERENT
>  	select ARCH_HAS_SYNC_DMA_FOR_DEVICE
>  	select ARCH_HAS_DMA_SET_UNCACHED
> +	select ARCH_HAS_SETUP_DMA_OPS

This is an unrelated und undocument change.  If you want to do it,
please do that as a separate patch with a commit log documenting
the rationale.
diff mbox series

Patch

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 15cb692b0a09..c6f3ad51f741 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -134,7 +134,6 @@  choice
 
 config MIPS_GENERIC_KERNEL
 	bool "Generic board-agnostic MIPS kernel"
-	select ARCH_HAS_SETUP_DMA_OPS
 	select MIPS_GENERIC
 	select BOOT_RAW
 	select BUILTIN_DTB
@@ -1079,11 +1078,6 @@  config FW_CFE
 config ARCH_SUPPORTS_UPROBES
 	bool
 
-config DMA_PERDEV_COHERENT
-	bool
-	select ARCH_HAS_SETUP_DMA_OPS
-	select DMA_NONCOHERENT
-
 config DMA_NONCOHERENT
 	bool
 	#
@@ -1097,6 +1091,7 @@  config DMA_NONCOHERENT
 	select ARCH_HAS_DMA_PREP_COHERENT
 	select ARCH_HAS_SYNC_DMA_FOR_DEVICE
 	select ARCH_HAS_DMA_SET_UNCACHED
+	select ARCH_HAS_SETUP_DMA_OPS
 	select DMA_NONCOHERENT_MMAP
 	select NEED_DMA_MAP_STATE