| Message ID | 20221216122708.182154-1-sourabhjain@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b0ae5b6f3c298a005b73556740526c0e24a5633c |
| Headers | show |
| Series | powerpc/kexec_file: print error string on usable memory property update failure | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
On 16/12/22 5:57 pm, Sourabh Jain wrote: > Print the FDT error description along with the error message if failed > to set the "linux,drconf-usable-memory" property in the kdump kernel's > FDT. > > Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com> LGTM Acked-by: Hari Bathini <hbathini@linux.ibm.com> > --- > arch/powerpc/kexec/file_load_64.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c > index 349a781cea0b3..7602f7e1e634e 100644 > --- a/arch/powerpc/kexec/file_load_64.c > +++ b/arch/powerpc/kexec/file_load_64.c > @@ -687,7 +687,8 @@ static int update_usable_mem_fdt(void *fdt, struct crash_mem *usable_mem) > ret = fdt_setprop(fdt, node, "linux,drconf-usable-memory", > um_info.buf, (um_info.idx * sizeof(u64))); > if (ret) { > - pr_err("Failed to update fdt with linux,drconf-usable-memory property"); > + pr_err("Failed to update fdt with linux,drconf-usable-memory property: %s", > + fdt_strerror(ret)); > goto out; > } > }
On 19/12/22 14:16, Hari Bathini wrote: > > > On 16/12/22 5:57 pm, Sourabh Jain wrote: >> Print the FDT error description along with the error message if failed >> to set the "linux,drconf-usable-memory" property in the kdump kernel's >> FDT. >> >> Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com> > > LGTM > > Acked-by: Hari Bathini <hbathini@linux.ibm.com> Thanks! - Sourabh Jain
The only place on kexec/kdump path where we don't print reason for FDT operation failure. This patch fix that. Will this be a good candidate for next rc? Thanks, Sourabh On 16/12/22 17:57, Sourabh Jain wrote: > Print the FDT error description along with the error message if failed > to set the "linux,drconf-usable-memory" property in the kdump kernel's > FDT. > > Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com> > --- > arch/powerpc/kexec/file_load_64.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c > index 349a781cea0b3..7602f7e1e634e 100644 > --- a/arch/powerpc/kexec/file_load_64.c > +++ b/arch/powerpc/kexec/file_load_64.c > @@ -687,7 +687,8 @@ static int update_usable_mem_fdt(void *fdt, struct crash_mem *usable_mem) > ret = fdt_setprop(fdt, node, "linux,drconf-usable-memory", > um_info.buf, (um_info.idx * sizeof(u64))); > if (ret) { > - pr_err("Failed to update fdt with linux,drconf-usable-memory property"); > + pr_err("Failed to update fdt with linux,drconf-usable-memory property: %s", > + fdt_strerror(ret)); > goto out; > } > }
On Fri, 16 Dec 2022 17:57:08 +0530, Sourabh Jain wrote: > Print the FDT error description along with the error message if failed > to set the "linux,drconf-usable-memory" property in the kdump kernel's > FDT. > > Applied to powerpc/next. [1/1] powerpc/kexec_file: print error string on usable memory property update failure https://git.kernel.org/powerpc/c/b0ae5b6f3c298a005b73556740526c0e24a5633c cheers
diff --git a/arch/powerpc/kexec/file_load_64.c b/arch/powerpc/kexec/file_load_64.c index 349a781cea0b3..7602f7e1e634e 100644 --- a/arch/powerpc/kexec/file_load_64.c +++ b/arch/powerpc/kexec/file_load_64.c @@ -687,7 +687,8 @@ static int update_usable_mem_fdt(void *fdt, struct crash_mem *usable_mem) ret = fdt_setprop(fdt, node, "linux,drconf-usable-memory", um_info.buf, (um_info.idx * sizeof(u64))); if (ret) { - pr_err("Failed to update fdt with linux,drconf-usable-memory property"); + pr_err("Failed to update fdt with linux,drconf-usable-memory property: %s", + fdt_strerror(ret)); goto out; } }
Print the FDT error description along with the error message if failed to set the "linux,drconf-usable-memory" property in the kdump kernel's FDT. Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com> --- arch/powerpc/kexec/file_load_64.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)