| Message ID | 20220112112459.1033754-1-troglobit@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] powerpc/e500/qemu-e500: allow core to idle without waiting | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
On Wed, 2022-01-12 at 12:24 +0100, Joachim Wiberg wrote: > From: Tobias Waldekranz <tobias@waldekranz.com> > > This means an idle guest won't needlessly consume an entire core on > the host, waiting for work to show up. > > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> > Signed-off-by: Joachim Wiberg <troglobit@gmail.com> > --- > arch/powerpc/platforms/85xx/qemu_e500.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/powerpc/platforms/85xx/qemu_e500.c > b/arch/powerpc/platforms/85xx/qemu_e500.c > index a4127b0b161f..4c4d577effd9 100644 > --- a/arch/powerpc/platforms/85xx/qemu_e500.c > +++ b/arch/powerpc/platforms/85xx/qemu_e500.c > @@ -67,4 +67,9 @@ define_machine(qemu_e500) { > .get_irq = mpic_get_coreint_irq, > .calibrate_decr = generic_calibrate_decr, > .progress = udbg_progress, > +#ifdef CONFIG_PPC64 > + .power_save = book3e_idle, > +#else > + .power_save = e500_idle, > +#endif > }; In the 32-bit case shouldn't this already be getting added by setup_power_save()? Though I see corenet_generic.c doing the same thing... -Scott
On Wed, Jan 12, 2022 at 06:36, Scott Wood <oss@buserror.net> wrote: > On Wed, 2022-01-12 at 12:24 +0100, Joachim Wiberg wrote: >> [snip] >> +#ifdef CONFIG_PPC64 >> + .power_save = book3e_idle, >> +#else >> + .power_save = e500_idle, >> +#endif >> }; > In the 32-bit case shouldn't this already be getting added by > setup_power_save()? Though I see corenet_generic.c doing the same thing... We went for consistency with the corenet_generic.c setup, which as you noted does the same thing. Best regards /Joachim
On Wed, 2022-01-12 at 12:24 +0100, Joachim Wiberg wrote: > From: Tobias Waldekranz <tobias@waldekranz.com> > > This means an idle guest won't needlessly consume an entire core on > the host, waiting for work to show up. > > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> > Signed-off-by: Joachim Wiberg <troglobit@gmail.com> > --- > arch/powerpc/platforms/85xx/qemu_e500.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/powerpc/platforms/85xx/qemu_e500.c > b/arch/powerpc/platforms/85xx/qemu_e500.c > index a4127b0b161f..4c4d577effd9 100644 > --- a/arch/powerpc/platforms/85xx/qemu_e500.c > +++ b/arch/powerpc/platforms/85xx/qemu_e500.c > @@ -67,4 +67,9 @@ define_machine(qemu_e500) { > .get_irq = mpic_get_coreint_irq, > .calibrate_decr = generic_calibrate_decr, > .progress = udbg_progress, > +#ifdef CONFIG_PPC64 > + .power_save = book3e_idle, > +#else > + .power_save = e500_idle, > +#endif > }; Acked-by: Scott Wood <oss@buserror.net> -Scott
On Wed, 12 Jan 2022 12:24:59 +0100, Joachim Wiberg wrote: > From: Tobias Waldekranz <tobias@waldekranz.com> > > This means an idle guest won't needlessly consume an entire core on > the host, waiting for work to show up. > > Applied to powerpc/next. [1/1] powerpc/e500/qemu-e500: allow core to idle without waiting https://git.kernel.org/powerpc/c/f529edd1b69ddf832c3257dcd34e15100038d6b7 cheers
diff --git a/arch/powerpc/platforms/85xx/qemu_e500.c b/arch/powerpc/platforms/85xx/qemu_e500.c index a4127b0b161f..4c4d577effd9 100644 --- a/arch/powerpc/platforms/85xx/qemu_e500.c +++ b/arch/powerpc/platforms/85xx/qemu_e500.c @@ -67,4 +67,9 @@ define_machine(qemu_e500) { .get_irq = mpic_get_coreint_irq, .calibrate_decr = generic_calibrate_decr, .progress = udbg_progress, +#ifdef CONFIG_PPC64 + .power_save = book3e_idle, +#else + .power_save = e500_idle, +#endif };