| Message ID | 20210416125750.49550-1-ganeshgr@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | powerpc/pseries/mce: Fix a typo in error type assignment | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (0702e74703f57173e70cfab2a79a3e682e9e96ec) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
Ganesh Goudar <ganeshgr@linux.ibm.com> writes: > The error type is ICACHE and DCACHE, for case MCE_ERROR_TYPE_ICACHE. Do you mean "is ICACHE not DCACHE" ? cheers > Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com> > --- > arch/powerpc/platforms/pseries/ras.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c > index f8b390a9d9fb..9d4ef65da7f3 100644 > --- a/arch/powerpc/platforms/pseries/ras.c > +++ b/arch/powerpc/platforms/pseries/ras.c > @@ -699,7 +699,7 @@ static int mce_handle_err_virtmode(struct pt_regs *regs, > mce_err.error_type = MCE_ERROR_TYPE_DCACHE; > break; > case MC_ERROR_TYPE_I_CACHE: > - mce_err.error_type = MCE_ERROR_TYPE_DCACHE; > + mce_err.error_type = MCE_ERROR_TYPE_ICACHE; > break; > case MC_ERROR_TYPE_UNKNOWN: > default: > -- > 2.26.2
On 4/17/21 6:06 PM, Michael Ellerman wrote: > Ganesh Goudar <ganeshgr@linux.ibm.com> writes: >> The error type is ICACHE and DCACHE, for case MCE_ERROR_TYPE_ICACHE. > Do you mean "is ICACHE not DCACHE" ? Right :), Should I send v2 ? > > cheers > >> Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com> >> --- >> arch/powerpc/platforms/pseries/ras.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c >> index f8b390a9d9fb..9d4ef65da7f3 100644 >> --- a/arch/powerpc/platforms/pseries/ras.c >> +++ b/arch/powerpc/platforms/pseries/ras.c >> @@ -699,7 +699,7 @@ static int mce_handle_err_virtmode(struct pt_regs *regs, >> mce_err.error_type = MCE_ERROR_TYPE_DCACHE; >> break; >> case MC_ERROR_TYPE_I_CACHE: >> - mce_err.error_type = MCE_ERROR_TYPE_DCACHE; >> + mce_err.error_type = MCE_ERROR_TYPE_ICACHE; >> break; >> case MC_ERROR_TYPE_UNKNOWN: >> default: >> -- >> 2.26.2
Ganesh <ganeshgr@linux.ibm.com> writes: > On 4/17/21 6:06 PM, Michael Ellerman wrote: > >> Ganesh Goudar <ganeshgr@linux.ibm.com> writes: >>> The error type is ICACHE and DCACHE, for case MCE_ERROR_TYPE_ICACHE. >> Do you mean "is ICACHE not DCACHE" ? > > Right :), Should I send v2 ? No I can fix it up :) cheers >>> Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com> >>> --- >>> arch/powerpc/platforms/pseries/ras.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c >>> index f8b390a9d9fb..9d4ef65da7f3 100644 >>> --- a/arch/powerpc/platforms/pseries/ras.c >>> +++ b/arch/powerpc/platforms/pseries/ras.c >>> @@ -699,7 +699,7 @@ static int mce_handle_err_virtmode(struct pt_regs *regs, >>> mce_err.error_type = MCE_ERROR_TYPE_DCACHE; >>> break; >>> case MC_ERROR_TYPE_I_CACHE: >>> - mce_err.error_type = MCE_ERROR_TYPE_DCACHE; >>> + mce_err.error_type = MCE_ERROR_TYPE_ICACHE; >>> break; >>> case MC_ERROR_TYPE_UNKNOWN: >>> default: >>> -- >>> 2.26.2
On Fri, 16 Apr 2021 18:27:50 +0530, Ganesh Goudar wrote:
> The error type is ICACHE and DCACHE, for case MCE_ERROR_TYPE_ICACHE.
Applied to powerpc/next.
[1/1] powerpc/pseries/mce: Fix a typo in error type assignment
https://git.kernel.org/powerpc/c/864ec4d40c83365b16483d88990e7e579537635c
cheers
diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c index f8b390a9d9fb..9d4ef65da7f3 100644 --- a/arch/powerpc/platforms/pseries/ras.c +++ b/arch/powerpc/platforms/pseries/ras.c @@ -699,7 +699,7 @@ static int mce_handle_err_virtmode(struct pt_regs *regs, mce_err.error_type = MCE_ERROR_TYPE_DCACHE; break; case MC_ERROR_TYPE_I_CACHE: - mce_err.error_type = MCE_ERROR_TYPE_DCACHE; + mce_err.error_type = MCE_ERROR_TYPE_ICACHE; break; case MC_ERROR_TYPE_UNKNOWN: default:
The error type is ICACHE and DCACHE, for case MCE_ERROR_TYPE_ICACHE. Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com> --- arch/powerpc/platforms/pseries/ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)