| Message ID | 20210324140752.11320-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] powerpc/smp: Remove unused inline functions | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (87d76f542a24ecfa797e9bd3bb56c0f19aabff57) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | warning | total: 0 errors, 1 warnings, 0 checks, 8 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
Hi, > commit 441c19c8a290 ("powerpc/kvm/book3s_hv: Rework the secondary inhibit code") > left behind this, so can remove it. > Interesting: that commit removed some instances of (un)inhibit_secondary_onlining, but it seems to have missed the ones for the uni-processor case, which your patch removes. This seems like a good change. Checkpatch does have one small complaint about your commit message: | WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) | #6: | commit 441c19c8a290 ("powerpc/kvm/book3s_hv: Rework the secondary inhibit code") I don't think this warrants another revision, I think leaving the commit name on one line makes sense. Reviewed-by: Daniel Axtens <dja@axtens.net> Kind regards, Daniel > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > arch/powerpc/include/asm/smp.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/powerpc/include/asm/smp.h b/arch/powerpc/include/asm/smp.h > index 7a13bc20f0a0..ad7129a19e8f 100644 > --- a/arch/powerpc/include/asm/smp.h > +++ b/arch/powerpc/include/asm/smp.h > @@ -189,8 +189,6 @@ extern void __cpu_die(unsigned int cpu); > #define hard_smp_processor_id() get_hard_smp_processor_id(0) > #define smp_setup_cpu_maps() > #define thread_group_shares_l2 0 > -static inline void inhibit_secondary_onlining(void) {} > -static inline void uninhibit_secondary_onlining(void) {} > static inline const struct cpumask *cpu_sibling_mask(int cpu) > { > return cpumask_of(cpu); > -- > 2.17.1
diff --git a/arch/powerpc/include/asm/smp.h b/arch/powerpc/include/asm/smp.h index 7a13bc20f0a0..ad7129a19e8f 100644 --- a/arch/powerpc/include/asm/smp.h +++ b/arch/powerpc/include/asm/smp.h @@ -189,8 +189,6 @@ extern void __cpu_die(unsigned int cpu); #define hard_smp_processor_id() get_hard_smp_processor_id(0) #define smp_setup_cpu_maps() #define thread_group_shares_l2 0 -static inline void inhibit_secondary_onlining(void) {} -static inline void uninhibit_secondary_onlining(void) {} static inline const struct cpumask *cpu_sibling_mask(int cpu) { return cpumask_of(cpu);
commit 441c19c8a290 ("powerpc/kvm/book3s_hv: Rework the secondary inhibit code") left behind this, so can remove it. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- arch/powerpc/include/asm/smp.h | 2 -- 1 file changed, 2 deletions(-)