| Message ID | 20210225031006.1204774-8-dja@axtens.net (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | WIP support for the LLVM integrated assembler | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (626a6c3d2e20da80aaa710104f34ea6037b28b33) |
| snowpatch_ozlabs/checkpatch | warning | total: 0 errors, 1 warnings, 0 checks, 8 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On Thu, Feb 25, 2021 at 02:10:05PM +1100, Daniel Axtens wrote: > It's ignored by future versions of llvm's integrated assembler (by not -11). > I'm not sure what it does for us in gas. It enables all insns that exist on 620 (the first 64-bit PowerPC CPU). > --- a/arch/powerpc/purgatory/trampoline_64.S > +++ b/arch/powerpc/purgatory/trampoline_64.S > @@ -12,7 +12,7 @@ > #include <asm/asm-compat.h> > #include <asm/crashdump-ppc64.h> > > - .machine ppc64 > +//upgrade clang, gets ignored .machine ppc64 Why delete it if it is ignored? Why add a cryptic comment? Segher
Segher Boessenkool <segher@kernel.crashing.org> writes: > On Thu, Feb 25, 2021 at 02:10:05PM +1100, Daniel Axtens wrote: >> It's ignored by future versions of llvm's integrated assembler (by not -11). >> I'm not sure what it does for us in gas. > > It enables all insns that exist on 620 (the first 64-bit PowerPC CPU). > >> --- a/arch/powerpc/purgatory/trampoline_64.S >> +++ b/arch/powerpc/purgatory/trampoline_64.S >> @@ -12,7 +12,7 @@ >> #include <asm/asm-compat.h> >> #include <asm/crashdump-ppc64.h> >> >> - .machine ppc64 >> +//upgrade clang, gets ignored .machine ppc64 > > Why delete it if it is ignored? Why add a cryptic comment? Sorry, poor form on my part. I think I will give up on having llvm-11 work and target llvm HEAD, which means I can drop this. > > > Segher
Excerpts from Segher Boessenkool's message of February 26, 2021 1:58 am: > On Thu, Feb 25, 2021 at 02:10:05PM +1100, Daniel Axtens wrote: >> It's ignored by future versions of llvm's integrated assembler (by not -11). >> I'm not sure what it does for us in gas. > > It enables all insns that exist on 620 (the first 64-bit PowerPC CPU). Same question for this, why do we have it at all? Thanks, Nick
Nicholas Piggin <npiggin@gmail.com> writes: > Excerpts from Segher Boessenkool's message of February 26, 2021 1:58 am: >> On Thu, Feb 25, 2021 at 02:10:05PM +1100, Daniel Axtens wrote: >>> It's ignored by future versions of llvm's integrated assembler (by not -11). >>> I'm not sure what it does for us in gas. >> >> It enables all insns that exist on 620 (the first 64-bit PowerPC CPU). > > Same question for this, why do we have it at all? I sent a patch to drop it. https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210315034159.315675-1-mpe@ellerman.id.au/ cheers
diff --git a/arch/powerpc/purgatory/trampoline_64.S b/arch/powerpc/purgatory/trampoline_64.S index d956b8a35fd1..e6a2740a5da0 100644 --- a/arch/powerpc/purgatory/trampoline_64.S +++ b/arch/powerpc/purgatory/trampoline_64.S @@ -12,7 +12,7 @@ #include <asm/asm-compat.h> #include <asm/crashdump-ppc64.h> - .machine ppc64 +//upgrade clang, gets ignored .machine ppc64 .balign 256 .globl purgatory_start purgatory_start:
It's ignored by future versions of llvm's integrated assembler (by not -11). I'm not sure what it does for us in gas. Signed-off-by: Daniel Axtens <dja@axtens.net> --- arch/powerpc/purgatory/trampoline_64.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)