| Message ID | 20200727171112.2781-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cf1ae052e073c7ef6cf1a783a6427f7228253bd3 |
| Headers | show |
| Series | [-next] powerpc/powernv/sriov: Remove unused but set variable 'phb' | expand |
On Tue, Jul 28, 2020 at 3:01 AM Wei Yongjun <weiyongjun1@huawei.com> wrote: > > Gcc report warning as follows: > > arch/powerpc/platforms/powernv/pci-sriov.c:602:25: warning: > variable 'phb' set but not used [-Wunused-but-set-variable] > 602 | struct pnv_phb *phb; > | ^~~ > > This variable is not used, so this commit removing it. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > arch/powerpc/platforms/powernv/pci-sriov.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/pci-sriov.c b/arch/powerpc/platforms/powernv/pci-sriov.c > index 8404d8c3901d..7894745fd4f8 100644 > --- a/arch/powerpc/platforms/powernv/pci-sriov.c > +++ b/arch/powerpc/platforms/powernv/pci-sriov.c > @@ -599,10 +599,8 @@ static int pnv_pci_vf_resource_shift(struct pci_dev *dev, int offset) > static void pnv_pci_sriov_disable(struct pci_dev *pdev) > { > u16 num_vfs, base_pe; > - struct pnv_phb *phb; > struct pnv_iov_data *iov; > > - phb = pci_bus_to_pnvhb(pdev->bus); > iov = pnv_iov_get(pdev); > num_vfs = iov->num_vfs; > base_pe = iov->vf_pe_arr[0].pe_number; > Acked-by: Oliver O'Halloran <oohall@gmail.com>
On Tue, 28 Jul 2020 01:11:12 +0800, Wei Yongjun wrote: > Gcc report warning as follows: > > arch/powerpc/platforms/powernv/pci-sriov.c:602:25: warning: > variable 'phb' set but not used [-Wunused-but-set-variable] > 602 | struct pnv_phb *phb; > | ^~~ > > [...] Applied to powerpc/next. [1/1] powerpc/powernv/sriov: Remove unused but set variable 'phb' https://git.kernel.org/powerpc/c/cf1ae052e073c7ef6cf1a783a6427f7228253bd3 cheers
diff --git a/arch/powerpc/platforms/powernv/pci-sriov.c b/arch/powerpc/platforms/powernv/pci-sriov.c index 8404d8c3901d..7894745fd4f8 100644 --- a/arch/powerpc/platforms/powernv/pci-sriov.c +++ b/arch/powerpc/platforms/powernv/pci-sriov.c @@ -599,10 +599,8 @@ static int pnv_pci_vf_resource_shift(struct pci_dev *dev, int offset) static void pnv_pci_sriov_disable(struct pci_dev *pdev) { u16 num_vfs, base_pe; - struct pnv_phb *phb; struct pnv_iov_data *iov; - phb = pci_bus_to_pnvhb(pdev->bus); iov = pnv_iov_get(pdev); num_vfs = iov->num_vfs; base_pe = iov->vf_pe_arr[0].pe_number;
Gcc report warning as follows: arch/powerpc/platforms/powernv/pci-sriov.c:602:25: warning: variable 'phb' set but not used [-Wunused-but-set-variable] 602 | struct pnv_phb *phb; | ^~~ This variable is not used, so this commit removing it. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- arch/powerpc/platforms/powernv/pci-sriov.c | 2 -- 1 file changed, 2 deletions(-)