| Message ID | 20200715031939.31968-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | powerpc: Fix inconsistent function names | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (3a60e5fbdc3520d429d7cd6affed5a8daf120c6b) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch fixes a commit that hasn't been released yet |
YueHaibing <yuehaibing@huawei.com> writes: > The stub helpers name should be consistent with prototypes. > > mm_context_add_vas_windows() --> mm_context_add_vas_window() > mm_context_remove_vas_windows() --> mm_context_remove_vas_window() > > Fixes: c420644c0a8f ("powerpc: Use mm_context vas_windows counter to issue CP_ABORT") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > arch/powerpc/include/asm/mmu_context.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/include/asm/mmu_context.h b/arch/powerpc/include/asm/mmu_context.h > index 1a474f6b1992..00fd1d44731a 100644 > --- a/arch/powerpc/include/asm/mmu_context.h > +++ b/arch/powerpc/include/asm/mmu_context.h > @@ -218,8 +218,8 @@ static inline void inc_mm_active_cpus(struct mm_struct *mm) { } > static inline void dec_mm_active_cpus(struct mm_struct *mm) { } > static inline void mm_context_add_copro(struct mm_struct *mm) { } > static inline void mm_context_remove_copro(struct mm_struct *mm) { } > -static inline void mm_context_add_vas_windows(struct mm_struct *mm) { } > -static inline void mm_context_remove_vas_windows(struct mm_struct *mm) { } > +static inline void mm_context_add_vas_window(struct mm_struct *mm) { } > +static inline void mm_context_remove_vas_window(struct mm_struct *mm) { } > #endif Both of those functions are only called from 64-bit only code, so the stubs should not be needed at all. Which explains why we haven't seen a build break. So just dropping them would be better IMO. cheers
diff --git a/arch/powerpc/include/asm/mmu_context.h b/arch/powerpc/include/asm/mmu_context.h index 1a474f6b1992..00fd1d44731a 100644 --- a/arch/powerpc/include/asm/mmu_context.h +++ b/arch/powerpc/include/asm/mmu_context.h @@ -218,8 +218,8 @@ static inline void inc_mm_active_cpus(struct mm_struct *mm) { } static inline void dec_mm_active_cpus(struct mm_struct *mm) { } static inline void mm_context_add_copro(struct mm_struct *mm) { } static inline void mm_context_remove_copro(struct mm_struct *mm) { } -static inline void mm_context_add_vas_windows(struct mm_struct *mm) { } -static inline void mm_context_remove_vas_windows(struct mm_struct *mm) { } +static inline void mm_context_add_vas_window(struct mm_struct *mm) { } +static inline void mm_context_remove_vas_window(struct mm_struct *mm) { } #endif
The stub helpers name should be consistent with prototypes. mm_context_add_vas_windows() --> mm_context_add_vas_window() mm_context_remove_vas_windows() --> mm_context_remove_vas_window() Fixes: c420644c0a8f ("powerpc: Use mm_context vas_windows counter to issue CP_ABORT") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- arch/powerpc/include/asm/mmu_context.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)