| Message ID | 20200703141327.1732550-3-mpe@ellerman.id.au (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/5] selftests/powerpc: Add test of stack expansion logic | expand |
Le 03/07/2020 à 16:13, Michael Ellerman a écrit : > Update the stack expansion load/store test to take into account the > new allowance of 4096 bytes below the stack pointer. [I didn't receive patch 2, don't know why, hence commenting patch 2 here.] Shouldn't patch 2 carry a fixes tag and be Cced to stable for application to previous kernel releases ? Christophe > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > --- > .../selftests/powerpc/mm/stack_expansion_ldst.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c b/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c > index 0587e11437f5..95c3f3de16a1 100644 > --- a/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c > +++ b/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c > @@ -186,17 +186,17 @@ static void test_one_type(enum access_type type, unsigned long page_size, unsign > // But if we go past the rlimit it should fail > assert(test_one(DEFAULT_SIZE, rlim_cur + 1, type) != 0); > > - // Above 1MB powerpc only allows accesses within 2048 bytes of > + // Above 1MB powerpc only allows accesses within 4096 bytes of > // r1 for accesses that aren't stdu > - assert(test_one(1 * _MB + page_size - 128, -2048, type) == 0); > + assert(test_one(1 * _MB + page_size - 128, -4096, type) == 0); > #ifdef __powerpc__ > - assert(test_one(1 * _MB + page_size - 128, -2049, type) != 0); > + assert(test_one(1 * _MB + page_size - 128, -4097, type) != 0); > #else > - assert(test_one(1 * _MB + page_size - 128, -2049, type) == 0); > + assert(test_one(1 * _MB + page_size - 128, -4097, type) == 0); > #endif > > // By consuming 2MB of stack we test the stdu case > - assert(test_one(2 * _MB + page_size - 128, -2048, type) == 0); > + assert(test_one(2 * _MB + page_size - 128, -4096, type) == 0); > } > > static int test(void) >
Christophe Leroy <christophe.leroy@csgroup.eu> writes: > Le 03/07/2020 à 16:13, Michael Ellerman a écrit : >> Update the stack expansion load/store test to take into account the >> new allowance of 4096 bytes below the stack pointer. > > [I didn't receive patch 2, don't know why, hence commenting patch 2 here.] > > Shouldn't patch 2 carry a fixes tag and be Cced to stable for > application to previous kernel releases ? Yes it should. cheers
diff --git a/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c b/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c index 0587e11437f5..95c3f3de16a1 100644 --- a/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c +++ b/tools/testing/selftests/powerpc/mm/stack_expansion_ldst.c @@ -186,17 +186,17 @@ static void test_one_type(enum access_type type, unsigned long page_size, unsign // But if we go past the rlimit it should fail assert(test_one(DEFAULT_SIZE, rlim_cur + 1, type) != 0); - // Above 1MB powerpc only allows accesses within 2048 bytes of + // Above 1MB powerpc only allows accesses within 4096 bytes of // r1 for accesses that aren't stdu - assert(test_one(1 * _MB + page_size - 128, -2048, type) == 0); + assert(test_one(1 * _MB + page_size - 128, -4096, type) == 0); #ifdef __powerpc__ - assert(test_one(1 * _MB + page_size - 128, -2049, type) != 0); + assert(test_one(1 * _MB + page_size - 128, -4097, type) != 0); #else - assert(test_one(1 * _MB + page_size - 128, -2049, type) == 0); + assert(test_one(1 * _MB + page_size - 128, -4097, type) == 0); #endif // By consuming 2MB of stack we test the stdu case - assert(test_one(2 * _MB + page_size - 128, -2048, type) == 0); + assert(test_one(2 * _MB + page_size - 128, -4096, type) == 0); } static int test(void)
Update the stack expansion load/store test to take into account the new allowance of 4096 bytes below the stack pointer. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- .../selftests/powerpc/mm/stack_expansion_ldst.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)