| Message ID | 20200426124356.3929682-1-mpe@ellerman.id.au (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | clocksource/drivers/timer-microchip-pit64b: Select CONFIG_TIMER_OF | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (54dc28ff5e0b3585224d49a31b53e030342ca5c3) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | warning | Upstream build failed, couldn't test patch |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch is tagged for stable |
On 26/04/2020 14:43, Michael Ellerman wrote: > This driver is an OF driver, it depends on OF, and uses > TIMER_OF_DECLARE, so it should select CONFIG_TIMER_OF. > > Without CONFIG_TIMER_OF enabled this can lead to warnings such as: > > powerpc-linux-ld: warning: orphan section `__timer_of_table' from > `drivers/clocksource/timer-microchip-pit64b.o' being placed in > section `__timer_of_table'. > > Because TIMER_OF_TABLES in vmlinux.lds.h doesn't emit anything into > the linker script when CONFIG_TIMER_OF is not enabled. > > Fixes: 625022a5f160 ("clocksource/drivers/timer-microchip-pit64b: Add Microchip PIT64B support") > Cc: stable@vger.kernel.org # v5.6+ > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > --- Applied, thanks > drivers/clocksource/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index f2142e6bbea3..f225c27b70f7 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -709,6 +709,7 @@ config MICROCHIP_PIT64B > bool "Microchip PIT64B support" > depends on OF || COMPILE_TEST > select CLKSRC_MMIO > + select TIMER_OF > help > This option enables Microchip PIT64B timer for Atmel > based system. It supports the oneshot, the periodic >
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index f2142e6bbea3..f225c27b70f7 100644 --- a/drivers/clocksource/Kconfig +++ b/drivers/clocksource/Kconfig @@ -709,6 +709,7 @@ config MICROCHIP_PIT64B bool "Microchip PIT64B support" depends on OF || COMPILE_TEST select CLKSRC_MMIO + select TIMER_OF help This option enables Microchip PIT64B timer for Atmel based system. It supports the oneshot, the periodic
This driver is an OF driver, it depends on OF, and uses TIMER_OF_DECLARE, so it should select CONFIG_TIMER_OF. Without CONFIG_TIMER_OF enabled this can lead to warnings such as: powerpc-linux-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-microchip-pit64b.o' being placed in section `__timer_of_table'. Because TIMER_OF_TABLES in vmlinux.lds.h doesn't emit anything into the linker script when CONFIG_TIMER_OF is not enabled. Fixes: 625022a5f160 ("clocksource/drivers/timer-microchip-pit64b: Add Microchip PIT64B support") Cc: stable@vger.kernel.org # v5.6+ Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- drivers/clocksource/Kconfig | 1 + 1 file changed, 1 insertion(+)