| Message ID | 20190903101605.2890-7-oohall@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 50554533358571d0c23a88fa1fe3d0b44c6fc7b5 |
| Headers | show |
| Series | [01/14] powerpc/eeh: Clean up EEH PEs after recovery finishes | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (c317052c95bef1f977b023158e5aa929215f443d) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 13 lines checked |
On 3/9/19 8:15 pm, Oliver O'Halloran wrote: > Support for switching CAPI cards into and out of CAPI mode was removed a > while ago. Drop the comment since it's no longer relevant. > > Cc: Andrew Donnellan <ajd@linux.ibm.com> > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> Oliver looked... unimpressed with the hackiness of the design of our mode-switching as he yelled at me to come explain this comment. Acked-by: Andrew Donnellan <ajd@linux.ibm.com> > --- > arch/powerpc/platforms/powernv/eeh-powernv.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c > index e7b867912f24..94e26d56ecd2 100644 > --- a/arch/powerpc/platforms/powernv/eeh-powernv.c > +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c > @@ -1125,13 +1125,6 @@ static int pnv_eeh_reset(struct eeh_pe *pe, int option) > return -EIO; > } > > - /* > - * If dealing with the root bus (or the bus underneath the > - * root port), we reset the bus underneath the root port. > - * > - * The cxl driver depends on this behaviour for bi-modal card > - * switching. > - */ > if (pci_is_root_bus(bus) || > pci_is_root_bus(bus->parent)) > return pnv_eeh_root_reset(hose, option); >
On Tue, Sep 03, 2019 at 08:15:57PM +1000, Oliver O'Halloran wrote: > Support for switching CAPI cards into and out of CAPI mode was removed a > while ago. Drop the comment since it's no longer relevant. > > Cc: Andrew Donnellan <ajd@linux.ibm.com> > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> LGTM Reviewed-by: Sam Bobroff <sbobroff@linux.ibm.com> > --- > arch/powerpc/platforms/powernv/eeh-powernv.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c > index e7b867912f24..94e26d56ecd2 100644 > --- a/arch/powerpc/platforms/powernv/eeh-powernv.c > +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c > @@ -1125,13 +1125,6 @@ static int pnv_eeh_reset(struct eeh_pe *pe, int option) > return -EIO; > } > > - /* > - * If dealing with the root bus (or the bus underneath the > - * root port), we reset the bus underneath the root port. > - * > - * The cxl driver depends on this behaviour for bi-modal card > - * switching. > - */ > if (pci_is_root_bus(bus) || > pci_is_root_bus(bus->parent)) > return pnv_eeh_root_reset(hose, option); > -- > 2.21.0 >
diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c index e7b867912f24..94e26d56ecd2 100644 --- a/arch/powerpc/platforms/powernv/eeh-powernv.c +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c @@ -1125,13 +1125,6 @@ static int pnv_eeh_reset(struct eeh_pe *pe, int option) return -EIO; } - /* - * If dealing with the root bus (or the bus underneath the - * root port), we reset the bus underneath the root port. - * - * The cxl driver depends on this behaviour for bi-modal card - * switching. - */ if (pci_is_root_bus(bus) || pci_is_root_bus(bus->parent)) return pnv_eeh_root_reset(hose, option);
Support for switching CAPI cards into and out of CAPI mode was removed a while ago. Drop the comment since it's no longer relevant. Cc: Andrew Donnellan <ajd@linux.ibm.com> Signed-off-by: Oliver O'Halloran <oohall@gmail.com> --- arch/powerpc/platforms/powernv/eeh-powernv.c | 7 ------- 1 file changed, 7 deletions(-)