| Message ID | 20190715085612.8802-5-oohall@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 758b423275f0738fa4d382057c03f3d45c12905d |
| Headers | show |
| Series | [1/5] powerpc/eeh_cache: Don't use pci_dn when inserting new ranges | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (f5c20693d8edcd665f1159dc941b9e7f87c17647) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
On Mon, Jul 15, 2019 at 06:56:11PM +1000, Oliver O'Halloran wrote: > In eeh_notify_resume_show() the pci_dn for the device is looked up once in > the declaration block and then once after checking for a NULL eeh_dev. > Remove the second lookup since it's pointless. > > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> Reviewed-by: Sam Bobroff <sbobroff@linux.ibm.com> Tested-by: Sam Bobroff <sbobroff@linux.ibm.com> > --- > arch/powerpc/kernel/eeh_sysfs.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/kernel/eeh_sysfs.c b/arch/powerpc/kernel/eeh_sysfs.c > index 3adf8cd..c4cc8fc 100644 > --- a/arch/powerpc/kernel/eeh_sysfs.c > +++ b/arch/powerpc/kernel/eeh_sysfs.c > @@ -102,7 +102,6 @@ static ssize_t eeh_notify_resume_show(struct device *dev, > if (!edev || !edev->pe) > return -ENODEV; > > - pdn = pci_get_pdn(pdev); > return sprintf(buf, "%d\n", pdn->last_allow_rc); > } > > -- > 2.9.5 >
diff --git a/arch/powerpc/kernel/eeh_sysfs.c b/arch/powerpc/kernel/eeh_sysfs.c index 3adf8cd..c4cc8fc 100644 --- a/arch/powerpc/kernel/eeh_sysfs.c +++ b/arch/powerpc/kernel/eeh_sysfs.c @@ -102,7 +102,6 @@ static ssize_t eeh_notify_resume_show(struct device *dev, if (!edev || !edev->pe) return -ENODEV; - pdn = pci_get_pdn(pdev); return sprintf(buf, "%d\n", pdn->last_allow_rc); }
In eeh_notify_resume_show() the pci_dn for the device is looked up once in the declaration block and then once after checking for a NULL eeh_dev. Remove the second lookup since it's pointless. Signed-off-by: Oliver O'Halloran <oohall@gmail.com> --- arch/powerpc/kernel/eeh_sysfs.c | 1 - 1 file changed, 1 deletion(-)