| Message ID | 20190615152313.26288-1-chunkeey@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3ab3a0689e74e6aa5b41360bc18861040ddef5b1 |
| Headers | show |
| Series | powerpc/4xx/uic: clear pending interrupt after irq type/pol change | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (e610a466d16a086e321f0bd421e2fc75cff28605) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
On Sat, 2019-06-15 at 15:23:13 UTC, Christian Lamparter wrote: > When testing out gpio-keys with a button, a spurious > interrupt (and therefore a key press or release event) > gets triggered as soon as the driver enables the irq > line for the first time. > > This patch clears any potential bogus generated interrupt > that was caused by the switching of the associated irq's > type and polarity. > > Signed-off-by: Christian Lamparter <chunkeey@gmail.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/3ab3a0689e74e6aa5b41360bc18861040ddef5b1 cheers
diff --git a/arch/powerpc/platforms/4xx/uic.c b/arch/powerpc/platforms/4xx/uic.c index 31f12ad37a98..36fb66ce54cf 100644 --- a/arch/powerpc/platforms/4xx/uic.c +++ b/arch/powerpc/platforms/4xx/uic.c @@ -154,6 +154,7 @@ static int uic_set_irq_type(struct irq_data *d, unsigned int flow_type) mtdcr(uic->dcrbase + UIC_PR, pr); mtdcr(uic->dcrbase + UIC_TR, tr); + mtdcr(uic->dcrbase + UIC_SR, ~mask); raw_spin_unlock_irqrestore(&uic->lock, flags);
When testing out gpio-keys with a button, a spurious interrupt (and therefore a key press or release event) gets triggered as soon as the driver enables the irq line for the first time. This patch clears any potential bogus generated interrupt that was caused by the switching of the associated irq's type and polarity. Signed-off-by: Christian Lamparter <chunkeey@gmail.com> --- arch/powerpc/platforms/4xx/uic.c | 1 + 1 file changed, 1 insertion(+)