| Message ID | 20190515090750.30647-1-tobin@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | powerpc: Remove double free | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (8150a153c013aa2dd1ffae43370b89ac1347a7fb) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
kobject_put() released index_dir->kobj but who will release 'index' ? Christophe Le 15/05/2019 à 11:07, Tobin C. Harding a écrit : > kfree() after kobject_put(). Who ever wrote this was on crack. > > Fixes: 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak") > Signed-off-by: Tobin C. Harding <tobin@kernel.org> > --- > > FTR > > git log --pretty=format:"%h%x09%an%x09%ad%x09%s" | grep 7e8039795a80 > 7e8039795a80 Tobin C. Harding Tue Apr 30 11:09:23 2019 +1000 powerpc/cacheinfo: Fix kobject memleak > > arch/powerpc/kernel/cacheinfo.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/kernel/cacheinfo.c b/arch/powerpc/kernel/cacheinfo.c > index f2ed3ef4b129..862e2890bd3d 100644 > --- a/arch/powerpc/kernel/cacheinfo.c > +++ b/arch/powerpc/kernel/cacheinfo.c > @@ -767,7 +767,6 @@ static void cacheinfo_create_index_dir(struct cache *cache, int index, > cache_dir->kobj, "index%d", index); > if (rc) { > kobject_put(&index_dir->kobj); > - kfree(index_dir); > return; > } > >
On Wed, May 15, 2019 at 11:26:03AM +0200, Christophe Leroy wrote: > kobject_put() released index_dir->kobj Yes, but what is that kobject enclosed in? > but who will release 'index' ? The final kobject_put() will do that, see cacheinfo_create_index_dir() for the details. And please do not top-post, you lost all context. greg k-h
diff --git a/arch/powerpc/kernel/cacheinfo.c b/arch/powerpc/kernel/cacheinfo.c index f2ed3ef4b129..862e2890bd3d 100644 --- a/arch/powerpc/kernel/cacheinfo.c +++ b/arch/powerpc/kernel/cacheinfo.c @@ -767,7 +767,6 @@ static void cacheinfo_create_index_dir(struct cache *cache, int index, cache_dir->kobj, "index%d", index); if (rc) { kobject_put(&index_dir->kobj); - kfree(index_dir); return; }
kfree() after kobject_put(). Who ever wrote this was on crack. Fixes: 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak") Signed-off-by: Tobin C. Harding <tobin@kernel.org> --- FTR git log --pretty=format:"%h%x09%an%x09%ad%x09%s" | grep 7e8039795a80 7e8039795a80 Tobin C. Harding Tue Apr 30 11:09:23 2019 +1000 powerpc/cacheinfo: Fix kobject memleak arch/powerpc/kernel/cacheinfo.c | 1 - 1 file changed, 1 deletion(-)