| Message ID | 20190218125644.87448-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 11dd34f3eae5a468013bb161a1dcf1fecd2ca321 |
| Headers | show |
| Series | [-next] powerpc/pseries: Drop pointless static qualifier in vpa_debugfs_init() | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/build-ppc64le | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64be | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64e | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-pmac32 | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
Hi YueHaibing, <yuehaibing@huawei.com> writes: > There is no need to have the 'struct dentry *vpa_dir' variable static > since new value always be assigned before use it. > Much to my surprise this seems to be a correct change. I don't know why the struct was ever static but it seems to have been this way since the commit went in in October 2018. And yes, it is set every time when the function is called (which is exactly once, it's an initcall). I wonder if once upon a time in an earlier spin of the patch there was a method to tear the debugfs down, so it was global, and in the revisions that went away but the static qualifier remained. Anyway, I think your commit message should have: Fixes: c6c26fb55e8e ("powerpc/pseries: Export raw per-CPU VPA data via debugfs") as this is the commit that introduced the issue. With that change: Reviewed-by: Daniel Axtens <dja@axtens.net> Regards, Daniel > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > arch/powerpc/platforms/pseries/lpar.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/pseries/lpar.c b/arch/powerpc/platforms/pseries/lpar.c > index f2a9f0adc2d3..f649c1b652eb 100644 > --- a/arch/powerpc/platforms/pseries/lpar.c > +++ b/arch/powerpc/platforms/pseries/lpar.c > @@ -1263,7 +1263,7 @@ static int __init vpa_debugfs_init(void) > { > char name[16]; > long i; > - static struct dentry *vpa_dir; > + struct dentry *vpa_dir; > > if (!firmware_has_feature(FW_FEATURE_SPLPAR)) > return 0;
On Mon, 2019-02-18 at 12:56:44 UTC, YueHaibing wrote: > There is no need to have the 'struct dentry *vpa_dir' variable static > since new value always be assigned before use it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/11dd34f3eae5a468013bb161a1dcf1fecd2ca321 cheers
diff --git a/arch/powerpc/platforms/pseries/lpar.c b/arch/powerpc/platforms/pseries/lpar.c index f2a9f0adc2d3..f649c1b652eb 100644 --- a/arch/powerpc/platforms/pseries/lpar.c +++ b/arch/powerpc/platforms/pseries/lpar.c @@ -1263,7 +1263,7 @@ static int __init vpa_debugfs_init(void) { char name[16]; long i; - static struct dentry *vpa_dir; + struct dentry *vpa_dir; if (!firmware_has_feature(FW_FEATURE_SPLPAR)) return 0;
There is no need to have the 'struct dentry *vpa_dir' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- arch/powerpc/platforms/pseries/lpar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)