diff mbox series

tracing: Remove PPC32 wart from config TRACING_SUPPORT

Message ID 20180502112948.1747-1-mpe@ellerman.id.au (mailing list archive)
State Accepted
Commit 0ea5ee035133aeb549883ddc604a6507c9493b9e
Headers show
Series tracing: Remove PPC32 wart from config TRACING_SUPPORT | expand

Commit Message

Michael Ellerman May 2, 2018, 11:29 a.m. UTC
config TRACING_SUPPORT has an exception for PPC32, because PPC32
didn't have irqflags tracing support.

But that hasn't been true since commit 5d38902c4838 ("powerpc: Add
irqtrace support for 32-bit powerpc") (Jun 2009).

So remove the exception for PPC32 and the comment.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 kernel/trace/Kconfig | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Steven Rostedt May 2, 2018, 12:50 p.m. UTC | #1
On Wed,  2 May 2018 21:29:48 +1000
Michael Ellerman <mpe@ellerman.id.au> wrote:

> config TRACING_SUPPORT has an exception for PPC32, because PPC32
> didn't have irqflags tracing support.
> 
> But that hasn't been true since commit 5d38902c4838 ("powerpc: Add
> irqtrace support for 32-bit powerpc") (Jun 2009).
> 
> So remove the exception for PPC32 and the comment.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Feel free to take this patch through the PPC tree.

Thanks!

-- Steve

> ---
>  kernel/trace/Kconfig | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index c4f0f2e4126e..dd6c0a2ad969 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -110,11 +110,7 @@ config GENERIC_TRACER
>  #
>  config TRACING_SUPPORT
>  	bool
> -	# PPC32 has no irqflags tracing support, but it can use most of the
> -	# tracers anyway, they were tested to build and work. Note that new
> -	# exceptions to this list aren't welcomed, better implement the
> -	# irqflags tracing for your architecture.
> -	depends on TRACE_IRQFLAGS_SUPPORT || PPC32
> +	depends on TRACE_IRQFLAGS_SUPPORT
>  	depends on STACKTRACE_SUPPORT
>  	default y
>
Michael Ellerman May 8, 2018, 2:52 p.m. UTC | #2
On Wed, 2018-05-02 at 11:29:48 UTC, Michael Ellerman wrote:
> config TRACING_SUPPORT has an exception for PPC32, because PPC32
> didn't have irqflags tracing support.
> 
> But that hasn't been true since commit 5d38902c4838 ("powerpc: Add
> irqtrace support for 32-bit powerpc") (Jun 2009).
> 
> So remove the exception for PPC32 and the comment.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Applied to powerpc next.

https://git.kernel.org/powerpc/c/0ea5ee035133aeb549883ddc604a65

cheers
diff mbox series

Patch

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index c4f0f2e4126e..dd6c0a2ad969 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -110,11 +110,7 @@  config GENERIC_TRACER
 #
 config TRACING_SUPPORT
 	bool
-	# PPC32 has no irqflags tracing support, but it can use most of the
-	# tracers anyway, they were tested to build and work. Note that new
-	# exceptions to this list aren't welcomed, better implement the
-	# irqflags tracing for your architecture.
-	depends on TRACE_IRQFLAGS_SUPPORT || PPC32
+	depends on TRACE_IRQFLAGS_SUPPORT
 	depends on STACKTRACE_SUPPORT
 	default y