| Message ID | 20180115133003.3447-1-msuchanek@suse.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1b689a95ce7427075f9ac9fb4aea1af530742b7f |
| Headers | show |
| Series | powerpc/pseries: include linux/types.h in asm/hvcall.h | expand |
Michal Suchanek <msuchanek@suse.de> writes: > Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush > settings") uses u64 in asm/hvcall.h without including linux/types.h > > This breaks hvcall.h users that do not include the header themselves. > > Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush > settings") > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> > --- > arch/powerpc/include/asm/hvcall.h | 1 + > 1 file changed, 1 insertion(+) Thanks. None of my ~250 defconfig test builds hit this, what config are you using? cheers > diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h > index f0461618bf7b..eca3f9c68907 100644 > --- a/arch/powerpc/include/asm/hvcall.h > +++ b/arch/powerpc/include/asm/hvcall.h > @@ -353,6 +353,7 @@ > #define PROC_TABLE_GTSE 0x01 > > #ifndef __ASSEMBLY__ > +#include <linux/types.h> > > /** > * plpar_hcall_norets: - Make a pseries hypervisor call with no return arguments > -- > 2.13.6
On Tue, Jan 16, 2018 at 02:16:58PM +1100, Michael Ellerman wrote: > Michal Suchanek <msuchanek@suse.de> writes: > > > Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush > > settings") uses u64 in asm/hvcall.h without including linux/types.h > > > > This breaks hvcall.h users that do not include the header themselves. > > > > Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush > > settings") > > > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> > > --- > > arch/powerpc/include/asm/hvcall.h | 1 + > > 1 file changed, 1 insertion(+) > > Thanks. None of my ~250 defconfig test builds hit this, what config are > you using? I also hit this, but only when I backported the change to RH's 3.10 kernel. I assumed something since then had added an indirect include.
On Mon, 2018-01-15 at 13:30:03 UTC, Michal Suchanek wrote: > Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush > settings") uses u64 in asm/hvcall.h without including linux/types.h > > This breaks hvcall.h users that do not include the header themselves. > > Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush > settings") > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/1b689a95ce7427075f9ac9fb4aea1a cheers
diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h index f0461618bf7b..eca3f9c68907 100644 --- a/arch/powerpc/include/asm/hvcall.h +++ b/arch/powerpc/include/asm/hvcall.h @@ -353,6 +353,7 @@ #define PROC_TABLE_GTSE 0x01 #ifndef __ASSEMBLY__ +#include <linux/types.h> /** * plpar_hcall_norets: - Make a pseries hypervisor call with no return arguments
Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush settings") uses u64 in asm/hvcall.h without including linux/types.h This breaks hvcall.h users that do not include the header themselves. Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush settings") Signed-off-by: Michal Suchanek <msuchanek@suse.de> --- arch/powerpc/include/asm/hvcall.h | 1 + 1 file changed, 1 insertion(+)