| Message ID | 20170712164008.GC31223@us.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Em Wed, Jul 12, 2017 at 09:40:08AM -0700, Sukadev Bhattiprolu escreveu: > Arnaldo Carvalho de Melo [acme@kernel.org] wrote: > > Em Wed, Jul 12, 2017 at 10:09:12PM +1000, Michael Ellerman escreveu: > > > So for starters you should probably drop that one and add 0x004e1200 and > > > 0x004e0200. > Yes, thanks. > > Could this check be somehow done automatically? Using whatever is in the > > kernel sources or some IBM released document? > Yes, had a recent discussion offline with Michael Petlan and Jiri about > generalizing/simplifying this. For now, I have added the above PVRs and > will look into the broader fix. > The following changes since commit 07d306c838c5c30196619baae36107d0615e459b: > Merge git://www.linux-watchdog.org/linux-watchdog (2017-07-11 09:59:37 -0700) > are available in the git repository at: > https://github.com/sukadev/linux/ p9-json Can you please base your branches out ouf tip/perf/core or acme/perf/core when you submit it with the fixes discussed here? thanks, - Arnaldo
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> writes: ... > > tools/perf/pmu-events/arch/powerpc/mapfile.csv | 3 + > .../perf/pmu-events/arch/powerpc/power9/cache.json | 176 +++++ > .../arch/powerpc/power9/floating-point.json | 44 ++ > .../pmu-events/arch/powerpc/power9/frontend.json | 446 +++++++++++ > .../pmu-events/arch/powerpc/power9/marked.json | 782 +++++++++++++++++++ > .../pmu-events/arch/powerpc/power9/memory.json | 158 ++++ In the map file we have "power9.json", but the files are power9/x.json. How does that work? cheers
On Thu, Jul 13, 2017 at 01:43:41PM +1000, Michael Ellerman wrote: > Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> writes: > ... > > > > tools/perf/pmu-events/arch/powerpc/mapfile.csv | 3 + > > .../perf/pmu-events/arch/powerpc/power9/cache.json | 176 +++++ > > .../arch/powerpc/power9/floating-point.json | 44 ++ > > .../pmu-events/arch/powerpc/power9/frontend.json | 446 +++++++++++ > > .../pmu-events/arch/powerpc/power9/marked.json | 782 +++++++++++++++++++ > > .../pmu-events/arch/powerpc/power9/memory.json | 158 ++++ > > In the map file we have "power9.json", but the files are power9/x.json. > How does that work? hum, we take just the base name from that string and use it as a map to the directory/struct with events.. so no harm done I guess it's the leftover from when we switched from single file to per topic event files.. x86 arch seems to have it right I'll send the fix thanks, jirka
Jiri Olsa <jolsa@redhat.com> writes: > On Thu, Jul 13, 2017 at 01:43:41PM +1000, Michael Ellerman wrote: >> Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> writes: >> ... >> > >> > tools/perf/pmu-events/arch/powerpc/mapfile.csv | 3 + >> > .../perf/pmu-events/arch/powerpc/power9/cache.json | 176 +++++ >> > .../arch/powerpc/power9/floating-point.json | 44 ++ >> > .../pmu-events/arch/powerpc/power9/frontend.json | 446 +++++++++++ >> > .../pmu-events/arch/powerpc/power9/marked.json | 782 +++++++++++++++++++ >> > .../pmu-events/arch/powerpc/power9/memory.json | 158 ++++ >> >> In the map file we have "power9.json", but the files are power9/x.json. >> How does that work? > > hum, we take just the base name from that string and use it > as a map to the directory/struct with events.. so no harm done I figured it must be working somehow but it's a bit odd :) > I guess it's the leftover from when we switched from single file > to per topic event files.. x86 arch seems to have it right Yep. > I'll send the fix Thanks. cheers