| Message ID | 20160521120353.11023-1-andrea.gelmini@gelma.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote: > Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> > --- This entire comment needs to be rewritten as it's incredibly confusing, but alas Acked-by: Russell Currey <ruscur@russell.cc> > arch/powerpc/include/asm/eeh.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h > index fb9f376..7d34f3d 100644 > --- a/arch/powerpc/include/asm/eeh.h > +++ b/arch/powerpc/include/asm/eeh.h > @@ -57,7 +57,7 @@ struct pci_dn; > /* > * The struct is used to trace PE related EEH functionality. > * In theory, there will have one instance of the struct to > - * be created against particular PE. In nature, PEs corelate > + * be created against particular PE. In nature, PEs correlate > * to each other. the struct has to reflect that hierarchy in > * order to easily pick up those affected PEs when one particular > * PE has EEH errors.
On Mon, 23 May 2016, Russell Currey wrote: > On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote: > > Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> > > --- > > This entire comment needs to be rewritten as it's incredibly confusing, but alas > > Acked-by: Russell Currey <ruscur@russell.cc> > > > arch/powerpc/include/asm/eeh.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h > > index fb9f376..7d34f3d 100644 > > --- a/arch/powerpc/include/asm/eeh.h > > +++ b/arch/powerpc/include/asm/eeh.h > > @@ -57,7 +57,7 @@ struct pci_dn; > > /* > > * The struct is used to trace PE related EEH functionality. > > * In theory, there will have one instance of the struct to "there will have one instance"? rday
On Mon, 2016-05-23 at 03:12 -0400, Robert P. J. Day wrote: > On Mon, 23 May 2016, Russell Currey wrote: > > > On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote: > > > Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> > > > --- > > > > This entire comment needs to be rewritten as it's incredibly confusing, but > > alas > > > > Acked-by: Russell Currey <ruscur@russell.cc> > > > > > arch/powerpc/include/asm/eeh.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/powerpc/include/asm/eeh.h > > > b/arch/powerpc/include/asm/eeh.h > > > index fb9f376..7d34f3d 100644 > > > --- a/arch/powerpc/include/asm/eeh.h > > > +++ b/arch/powerpc/include/asm/eeh.h > > > @@ -57,7 +57,7 @@ struct pci_dn; > > > /* > > > * The struct is used to trace PE related EEH functionality. > > > * In theory, there will have one instance of the struct to > > "there will have one instance"? See "This entire comment needs to be rewritten as it's incredibly confusing" :) EEH documentation, both in source and in Documentation/powerpc/, is very much in need of updates and reworks. I'm working on it. - Russell
On Tue, 2016-05-24 at 10:04 +1000, Russell Currey wrote: > On Mon, 2016-05-23 at 03:12 -0400, Robert P. J. Day wrote: > > On Mon, 23 May 2016, Russell Currey wrote: > > > On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote: > > > > Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> > > > > --- > > > > > > This entire comment needs to be rewritten as it's incredibly confusing, but > > > alas > > > > > > Acked-by: Russell Currey <ruscur@russell.cc> > > > > > > > arch/powerpc/include/asm/eeh.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/arch/powerpc/include/asm/eeh.h > > > > b/arch/powerpc/include/asm/eeh.h > > > > index fb9f376..7d34f3d 100644 > > > > --- a/arch/powerpc/include/asm/eeh.h > > > > +++ b/arch/powerpc/include/asm/eeh.h > > > > @@ -57,7 +57,7 @@ struct pci_dn; > > > > /* > > > > * The struct is used to trace PE related EEH functionality. > > > > * In theory, there will have one instance of the struct to > > > > "there will have one instance"? > > See "This entire comment needs to be rewritten as it's incredibly confusing" :) > > EEH documentation, both in source and in Documentation/powerpc/, is very much in > need of updates and reworks. I'm working on it. Thanks. I'll wait for that, I'm not interested in merging a single byte typo fix to an otherwise badly worded comment. cheers
diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h index fb9f376..7d34f3d 100644 --- a/arch/powerpc/include/asm/eeh.h +++ b/arch/powerpc/include/asm/eeh.h @@ -57,7 +57,7 @@ struct pci_dn; /* * The struct is used to trace PE related EEH functionality. * In theory, there will have one instance of the struct to - * be created against particular PE. In nature, PEs corelate + * be created against particular PE. In nature, PEs correlate * to each other. the struct has to reflect that hierarchy in * order to easily pick up those affected PEs when one particular * PE has EEH errors.
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> --- arch/powerpc/include/asm/eeh.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)