| Message ID | 1605007170-22171-1-git-send-email-kaixuxia@tencent.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 027717a45ca251a7ba67a63db359994836962cd2 |
| Headers | show |
| Series | powerpc/powernv/sriov: fix unsigned int win compared to less than zero | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (80ecbe16c827714ce3741ed1f1d34488b903e717) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On 10/11/20 10:19 pm, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia <kaixuxia@tencent.com> > > Fix coccicheck warning: > > ./arch/powerpc/platforms/powernv/pci-sriov.c:443:7-10: WARNING: Unsigned expression compared with zero: win < 0 > ./arch/powerpc/platforms/powernv/pci-sriov.c:462:7-10: WARNING: Unsigned expression compared with zero: win < 0 > > Reported-by: Tosk Robot <tencent_os_robot@tencent.com> > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com> This seems like the right fix, the value assigned to win can indeed be -1 so it should be signed. Thanks for sending the patch. Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com> > --- > arch/powerpc/platforms/powernv/pci-sriov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/pci-sriov.c b/arch/powerpc/platforms/powernv/pci-sriov.c > index c4434f20f42f..92fc861c528f 100644 > --- a/arch/powerpc/platforms/powernv/pci-sriov.c > +++ b/arch/powerpc/platforms/powernv/pci-sriov.c > @@ -422,7 +422,7 @@ static int pnv_pci_vf_assign_m64(struct pci_dev *pdev, u16 num_vfs) > { > struct pnv_iov_data *iov; > struct pnv_phb *phb; > - unsigned int win; > + int win; > struct resource *res; > int i, j; > int64_t rc; >
Andrew Donnellan <ajd@linux.ibm.com> writes: > On 10/11/20 10:19 pm, xiakaixu1987@gmail.com wrote: >> From: Kaixu Xia <kaixuxia@tencent.com> >> >> Fix coccicheck warning: >> >> ./arch/powerpc/platforms/powernv/pci-sriov.c:443:7-10: WARNING: Unsigned expression compared with zero: win < 0 >> ./arch/powerpc/platforms/powernv/pci-sriov.c:462:7-10: WARNING: Unsigned expression compared with zero: win < 0 >> >> Reported-by: Tosk Robot <tencent_os_robot@tencent.com> >> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com> > > This seems like the right fix, the value assigned to win can indeed be > -1 so it should be signed. Thanks for sending the patch. > > Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com> I'll add: Fixes: 39efc03e3ee8 ("powerpc/powernv/sriov: Move M64 BAR allocation into a helper") Which I think is the culprit as it changed: if (win >= phb->ioda.m64_bar_idx + 1) to: if (win < 0) cheers
On Tue, 10 Nov 2020 19:19:30 +0800, xiakaixu1987@gmail.com wrote: > Fix coccicheck warning: > > ./arch/powerpc/platforms/powernv/pci-sriov.c:443:7-10: WARNING: Unsigned expression compared with zero: win < 0 > ./arch/powerpc/platforms/powernv/pci-sriov.c:462:7-10: WARNING: Unsigned expression compared with zero: win < 0 Applied to powerpc/next. [1/1] powerpc/powernv/sriov: fix unsigned int win compared to less than zero https://git.kernel.org/powerpc/c/027717a45ca251a7ba67a63db359994836962cd2 cheers
diff --git a/arch/powerpc/platforms/powernv/pci-sriov.c b/arch/powerpc/platforms/powernv/pci-sriov.c index c4434f20f42f..92fc861c528f 100644 --- a/arch/powerpc/platforms/powernv/pci-sriov.c +++ b/arch/powerpc/platforms/powernv/pci-sriov.c @@ -422,7 +422,7 @@ static int pnv_pci_vf_assign_m64(struct pci_dev *pdev, u16 num_vfs) { struct pnv_iov_data *iov; struct pnv_phb *phb; - unsigned int win; + int win; struct resource *res; int i, j; int64_t rc;