| Message ID | 1546595897-33291-1-git-send-email-clabbe@baylibre.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | powerpc: build dtb even without COMPILE_TEST | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/build-ppc64le | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64be | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64e | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-pmac32 | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/checkpatch | warning | total: 0 errors, 1 warnings, 0 checks, 10 lines checked |
On Fri, Jan 4, 2019 at 3:58 AM Corentin Labbe <clabbe@baylibre.com> wrote: > > I wanted to test the virtex440-ml507 qemu machine and found that the dtb > for it was not builded. Just do: make virtex440-ml507.dtb > All powerpc DTB are only built when CONFIG_OF_ALL_DTBS is set which depend on > COMPILE_TEST. > But building DTB is not related to a "compile build test". But it is. We normally only build the dtbs for enabled platforms just like we only build platform/driver code for enabled platforms. It's hidden behind COMPILE_TEST so it only gets enabled for allmodconfig/allyesconfig builds. > So this patch made building of DTB independent of COMPILE_TEST (by > depending only on the PPC arch) > A better selection of which DTB to build could be done in the future > like that do the ARM arch. No reason you can't start that now for the platform you care about. You don't have to convert everyone. Rob
Rob Herring <robh+dt@kernel.org> writes: > On Fri, Jan 4, 2019 at 3:58 AM Corentin Labbe <clabbe@baylibre.com> wrote: >> >> I wanted to test the virtex440-ml507 qemu machine and found that the dtb >> for it was not builded. > > Just do: > > make virtex440-ml507.dtb I actually thought you had to do that, so I've never done anything different. >> All powerpc DTB are only built when CONFIG_OF_ALL_DTBS is set which depend on >> COMPILE_TEST. >> But building DTB is not related to a "compile build test". > > But it is. We normally only build the dtbs for enabled platforms just > like we only build platform/driver code for enabled platforms. It's > hidden behind COMPILE_TEST so it only gets enabled for > allmodconfig/allyesconfig builds. > >> So this patch made building of DTB independent of COMPILE_TEST (by >> depending only on the PPC arch) >> A better selection of which DTB to build could be done in the future >> like that do the ARM arch. > > No reason you can't start that now for the platform you care about. > You don't have to convert everyone. Yeah that seems like the best option. I'm happy to take a patch just for that target. cheers
diff --git a/arch/powerpc/boot/dts/Makefile b/arch/powerpc/boot/dts/Makefile index fb335d05aae8..3a73cf41585b 100644 --- a/arch/powerpc/boot/dts/Makefile +++ b/arch/powerpc/boot/dts/Makefile @@ -3,4 +3,4 @@ subdir-y += fsl dtstree := $(srctree)/$(src) -dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts)) +dtb-$(CONFIG_PPC) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts)) diff --git a/arch/powerpc/boot/dts/fsl/Makefile b/arch/powerpc/boot/dts/fsl/Makefile index 3bae982641e9..27c5ca3a35be 100644 --- a/arch/powerpc/boot/dts/fsl/Makefile +++ b/arch/powerpc/boot/dts/fsl/Makefile @@ -1,4 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 dtstree := $(srctree)/$(src) -dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts)) +dtb-$(CONFIG_PPC) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
I wanted to test the virtex440-ml507 qemu machine and found that the dtb for it was not builded. All powerpc DTB are only built when CONFIG_OF_ALL_DTBS is set which depend on COMPILE_TEST. But building DTB is not related to a "compile build test". So this patch made building of DTB independent of COMPILE_TEST (by depending only on the PPC arch) A better selection of which DTB to build could be done in the future like that do the ARM arch. Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- arch/powerpc/boot/dts/Makefile | 2 +- arch/powerpc/boot/dts/fsl/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)