| Message ID | 1479167045-28136-4-git-send-email-bsingharora@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Can you make the subject a bit more descriptive? Currently this prevents node hotplug, so it's required that we remove it to support that IIUIC. Balbir Singh <bsingharora@gmail.com> writes: > We've fixed the memory hotplug issue with memcg, hence > this work around should not be required. > > Fixes: commit 3af229f2071f > ("powerpc/numa: Reset node_possible_map to only node_online_map") I don't think Fixes is right here, that commit wasn't buggy, it was just a workaround for the code at that time. Just say "This is a revert of commit 3af229f2071f ("powerpc/numa: Reset node_possible_map to only node_online_map")". Otherwise LGTM to go via mm. Acked-by: Michael Ellerman <mpe@ellerman.id.au> cheers
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index a51c188..ca8c2ab 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c @@ -916,13 +916,6 @@ void __init initmem_init(void) memblock_dump_all(); - /* - * Reduce the possible NUMA nodes to the online NUMA nodes, - * since we do not support node hotplug. This ensures that we - * lower the maximum NUMA node ID to what is actually present. - */ - nodes_and(node_possible_map, node_possible_map, node_online_map); - for_each_online_node(nid) { unsigned long start_pfn, end_pfn;
We've fixed the memory hotplug issue with memcg, hence this work around should not be required. Fixes: commit 3af229f2071f ("powerpc/numa: Reset node_possible_map to only node_online_map") Signed-off-by: Balbir Singh <bsingharora@gmail.com> --- arch/powerpc/mm/numa.c | 7 ------- 1 file changed, 7 deletions(-)