| Message ID | 1476998874-2089-10-git-send-email-xinhui.pan@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, Oct 20, 2016 at 05:27:54PM -0400, Pan Xinhui wrote: > Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 > preempted" into struct kvm_steal_time. This field tells if one vcpu is > running or not. > > It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is > preempted. Other values means the vcpu has been preempted. ^^^^^^^^^ s/preempted/not preempted And better to fix other typos in the commit log ;-) Maybe you can try aspell? That works for me. Regards, Boqun > > Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> > --- > Documentation/virtual/kvm/msr.txt | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt > index 2a71c8f..3376f13 100644 > --- a/Documentation/virtual/kvm/msr.txt > +++ b/Documentation/virtual/kvm/msr.txt > @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 > __u64 steal; > __u32 version; > __u32 flags; > - __u32 pad[12]; > + __u8 preempted; > + __u32 pad[11]; > } > > whose data will be filled in by the hypervisor periodically. Only one > @@ -232,6 +233,11 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 > nanoseconds. Time during which the vcpu is idle, will not be > reported as steal time. > > + preempted: indicate the VCPU who owns this struct is running or > + not. Non-zero values mean the VCPU has been preempted. Zero > + means the VCPU is not preempted. NOTE, it is always zero if the > + the hypervisor doesn't support this field. > + > MSR_KVM_EOI_EN: 0x4b564d04 > data: Bit 0 is 1 when PV end of interrupt is enabled on the vcpu; 0 > when disabled. Bit 1 is reserved and must be zero. When PV end of > -- > 2.4.11 >
在 2016/10/21 09:23, Boqun Feng 写道: > On Thu, Oct 20, 2016 at 05:27:54PM -0400, Pan Xinhui wrote: >> Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 >> preempted" into struct kvm_steal_time. This field tells if one vcpu is >> running or not. >> >> It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is >> preempted. Other values means the vcpu has been preempted. > ^^^^^^^^^ > s/preempted/not preempted > yes. the less of *not* definitely sould be avoided.. > And better to fix other typos in the commit log ;-) > Maybe you can try aspell? That works for me. > I will try it. :) > Regards, > Boqun > >> >> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> >> --- >> Documentation/virtual/kvm/msr.txt | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt >> index 2a71c8f..3376f13 100644 >> --- a/Documentation/virtual/kvm/msr.txt >> +++ b/Documentation/virtual/kvm/msr.txt >> @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 >> __u64 steal; >> __u32 version; >> __u32 flags; >> - __u32 pad[12]; >> + __u8 preempted; >> + __u32 pad[11]; >> } >> >> whose data will be filled in by the hypervisor periodically. Only one >> @@ -232,6 +233,11 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 >> nanoseconds. Time during which the vcpu is idle, will not be >> reported as steal time. >> >> + preempted: indicate the VCPU who owns this struct is running or >> + not. Non-zero values mean the VCPU has been preempted. Zero >> + means the VCPU is not preempted. NOTE, it is always zero if the >> + the hypervisor doesn't support this field. >> + >> MSR_KVM_EOI_EN: 0x4b564d04 >> data: Bit 0 is 1 when PV end of interrupt is enabled on the vcpu; 0 >> when disabled. Bit 1 is reserved and must be zero. When PV end of >> -- >> 2.4.11 >>
From: Pan Xinhui > Sent: 20 October 2016 22:28 > Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 > preempted" into struct kvm_steal_time. This field tells if one vcpu is > running or not. > > It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is > preempted. Other values means the vcpu has been preempted. > > Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> > --- > Documentation/virtual/kvm/msr.txt | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt > index 2a71c8f..3376f13 100644 > --- a/Documentation/virtual/kvm/msr.txt > +++ b/Documentation/virtual/kvm/msr.txt > @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 > __u64 steal; > __u32 version; > __u32 flags; > - __u32 pad[12]; > + __u8 preempted; > + __u32 pad[11]; > } I think I'd be explicit about the 3 pad bytes you've left. David
2016-10-21 11:27+0000, David Laight: > From: Pan Xinhui >> Sent: 20 October 2016 22:28 >> Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 >> preempted" into struct kvm_steal_time. This field tells if one vcpu is >> running or not. >> >> It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is >> preempted. Other values means the vcpu has been preempted. >> >> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> >> --- >> Documentation/virtual/kvm/msr.txt | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt >> index 2a71c8f..3376f13 100644 >> --- a/Documentation/virtual/kvm/msr.txt >> +++ b/Documentation/virtual/kvm/msr.txt >> @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 >> __u64 steal; >> __u32 version; >> __u32 flags; >> - __u32 pad[12]; >> + __u8 preempted; >> + __u32 pad[11]; >> } > > I think I'd be explicit about the 3 pad bytes you've left. Seconded. With that change are all KVM bits Acked-by: Radim Krčmář <rkrcmar@redhat.com>
On 2016年10月21日 19:27, David Laight wrote: > From: Pan Xinhui >> Sent: 20 October 2016 22:28 >> Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 >> preempted" into struct kvm_steal_time. This field tells if one vcpu is >> running or not. >> >> It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is >> preempted. Other values means the vcpu has been preempted. >> >> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> >> --- >> Documentation/virtual/kvm/msr.txt | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt >> index 2a71c8f..3376f13 100644 >> --- a/Documentation/virtual/kvm/msr.txt >> +++ b/Documentation/virtual/kvm/msr.txt >> @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 >> __u64 steal; >> __u32 version; >> __u32 flags; >> - __u32 pad[12]; >> + __u8 preempted; >> + __u32 pad[11]; >> } > > I think I'd be explicit about the 3 pad bytes you've left. > yes,I will do it in next version. thanks > David >
On 2016年10月22日 02:39, rkrcmar@redhat.com wrote: > 2016-10-21 11:27+0000, David Laight: >> From: Pan Xinhui >>> Sent: 20 October 2016 22:28 >>> Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 >>> preempted" into struct kvm_steal_time. This field tells if one vcpu is >>> running or not. >>> >>> It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is >>> preempted. Other values means the vcpu has been preempted. >>> >>> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> >>> --- >>> Documentation/virtual/kvm/msr.txt | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt >>> index 2a71c8f..3376f13 100644 >>> --- a/Documentation/virtual/kvm/msr.txt >>> +++ b/Documentation/virtual/kvm/msr.txt >>> @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 >>> __u64 steal; >>> __u32 version; >>> __u32 flags; >>> - __u32 pad[12]; >>> + __u8 preempted; >>> + __u32 pad[11]; >>> } >> >> I think I'd be explicit about the 3 pad bytes you've left. > > Seconded. > > With that change are all KVM bits > like below? __u8 preempted; __u8 kvm_pad[3]; > Acked-by: Radim Krčmář <rkrcmar@redhat.com> > thanks!
On 21/10/2016 20:39, rkrcmar@redhat.com wrote: > 2016-10-21 11:27+0000, David Laight: >> From: Pan Xinhui >>> Sent: 20 October 2016 22:28 >>> Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 >>> preempted" into struct kvm_steal_time. This field tells if one vcpu is >>> running or not. >>> >>> It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is >>> preempted. Other values means the vcpu has been preempted. >>> >>> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> >>> --- >>> Documentation/virtual/kvm/msr.txt | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt >>> index 2a71c8f..3376f13 100644 >>> --- a/Documentation/virtual/kvm/msr.txt >>> +++ b/Documentation/virtual/kvm/msr.txt >>> @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 >>> __u64 steal; >>> __u32 version; >>> __u32 flags; >>> - __u32 pad[12]; >>> + __u8 preempted; >>> + __u32 pad[11]; >>> } >> >> I think I'd be explicit about the 3 pad bytes you've left. > > Seconded. > > With that change are all KVM bits > > Acked-by: Radim Krčmář <rkrcmar@redhat.com> Saw this after replying to the previous message. If you need to post v6 of the full series, it would be nice if you removed the kvm_read_guest_cached. But anyway it wasn't my intention to override Radim. Paolo
2016-10-24 16:42+0200, Paolo Bonzini: > On 21/10/2016 20:39, rkrcmar@redhat.com wrote: >> 2016-10-21 11:27+0000, David Laight: >>> From: Pan Xinhui >>>> Sent: 20 October 2016 22:28 >>>> Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 >>>> preempted" into struct kvm_steal_time. This field tells if one vcpu is >>>> running or not. >>>> >>>> It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is >>>> preempted. Other values means the vcpu has been preempted. >>>> >>>> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> >>>> --- >>>> Documentation/virtual/kvm/msr.txt | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt >>>> index 2a71c8f..3376f13 100644 >>>> --- a/Documentation/virtual/kvm/msr.txt >>>> +++ b/Documentation/virtual/kvm/msr.txt >>>> @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 >>>> __u64 steal; >>>> __u32 version; >>>> __u32 flags; >>>> - __u32 pad[12]; >>>> + __u8 preempted; >>>> + __u32 pad[11]; >>>> } >>> >>> I think I'd be explicit about the 3 pad bytes you've left. >> >> Seconded. >> >> With that change are all KVM bits >> >> Acked-by: Radim Krčmář <rkrcmar@redhat.com> > > Saw this after replying to the previous message. If you need to post v6 > of the full series, it would be nice if you removed the > kvm_read_guest_cached. But anyway it wasn't my intention to override Radim. The patch was acceptable to me even now, so I definitely wouldn't mind if it were even nicer. :)
diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt index 2a71c8f..3376f13 100644 --- a/Documentation/virtual/kvm/msr.txt +++ b/Documentation/virtual/kvm/msr.txt @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 __u64 steal; __u32 version; __u32 flags; - __u32 pad[12]; + __u8 preempted; + __u32 pad[11]; } whose data will be filled in by the hypervisor periodically. Only one @@ -232,6 +233,11 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 nanoseconds. Time during which the vcpu is idle, will not be reported as steal time. + preempted: indicate the VCPU who owns this struct is running or + not. Non-zero values mean the VCPU has been preempted. Zero + means the VCPU is not preempted. NOTE, it is always zero if the + the hypervisor doesn't support this field. + MSR_KVM_EOI_EN: 0x4b564d04 data: Bit 0 is 1 when PV end of interrupt is enabled on the vcpu; 0 when disabled. Bit 1 is reserved and must be zero. When PV end of
Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 preempted" into struct kvm_steal_time. This field tells if one vcpu is running or not. It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is preempted. Other values means the vcpu has been preempted. Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com> --- Documentation/virtual/kvm/msr.txt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)