| Message ID | 1441786955-6249-1-git-send-email-mpe@ellerman.id.au (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wed, Sep 09, 2015 at 06:22:35PM +1000, Michael Ellerman wrote: > This code uses FP (floating point), Altivec and VSX (Vector-Scalar > Extension). It can just depend on CONFIG_VSX though, because that > already depends on FP and Altivec. > > Otherwise we get lots of link errors such as: > > drivers/built-in.o: In function `.p8_aes_setkey': > aes.c:(.text+0x2d325c): undefined reference to `.enable_kernel_altivec' > aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx' > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Applied.
On Thu, 2015-09-10 at 17:26 +0800, Herbert Xu wrote: > On Wed, Sep 09, 2015 at 06:22:35PM +1000, Michael Ellerman wrote: > > This code uses FP (floating point), Altivec and VSX (Vector-Scalar > > Extension). It can just depend on CONFIG_VSX though, because that > > already depends on FP and Altivec. > > > > Otherwise we get lots of link errors such as: > > > > drivers/built-in.o: In function `.p8_aes_setkey': > > aes.c:(.text+0x2d325c): undefined reference to `.enable_kernel_altivec' > > aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx' > > > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > > Applied. Thanks. Is that targeted for 4.3 ? cheers
On Fri, Sep 11, 2015 at 10:47:07AM +1000, Michael Ellerman wrote: > > Is that targeted for 4.3 ? Yes I'm only accepting 4.3 patches for the time being. Cheers,
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 07bc7aa6b224..d234719065a5 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -461,7 +461,7 @@ config CRYPTO_DEV_QCE config CRYPTO_DEV_VMX bool "Support for VMX cryptographic acceleration instructions" - depends on PPC64 + depends on PPC64 && VSX help Support for VMX cryptographic acceleration instructions.
This code uses FP (floating point), Altivec and VSX (Vector-Scalar Extension). It can just depend on CONFIG_VSX though, because that already depends on FP and Altivec. Otherwise we get lots of link errors such as: drivers/built-in.o: In function `.p8_aes_setkey': aes.c:(.text+0x2d325c): undefined reference to `.enable_kernel_altivec' aes.c:(.text+0x2d326c): undefined reference to `.enable_kernel_vsx' Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- v2: Spell out VSX, and CC linux-crypto. drivers/crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)