| Message ID | 1436368476-30592-1-git-send-email-jthumshirn@suse.de (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Michael Ellerman |
| Headers | show |
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
We are probably also missing an idr_destroy(&afu->contexts_idr); in
cxl_release_afu() as well if you wanted to send a patch for that.
Cheers,
-Ian
Ian Munsie <imunsie@au1.ibm.com> writes: > Acked-by: Ian Munsie <imunsie@au1.ibm.com> > > We are probably also missing an idr_destroy(&afu->contexts_idr); in > cxl_release_afu() as well if you wanted to send a patch for that. > > Cheers, > -Ian > Correct, patch is going out today. Thanks for the hint.
On Wed, 2015-08-07 at 15:14:36 UTC, Johannes Thumshirn wrote: > Destroy cxl_adapter_idr on module exit, reclaiming the allocated memory. > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> > Acked-by: Ian Munsie <imunsie@au1.ibm.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/b2a02ac65e40fb3900d1 cheers
diff --git a/drivers/misc/cxl/main.c b/drivers/misc/cxl/main.c index 833348e..4e58e0b 100644 --- a/drivers/misc/cxl/main.c +++ b/drivers/misc/cxl/main.c @@ -222,6 +222,7 @@ static void exit_cxl(void) cxl_debugfs_exit(); cxl_file_exit(); unregister_cxl_calls(&cxl_calls); + idr_destroy(&cxl_adapter_idr); } module_init(init_cxl);
Destroy cxl_adapter_idr on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez <mcgrof@suse.com>) <SmPL> @ defines_module_init @ declarer name module_init, module_exit; declarer name DEFINE_IDR; identifier init; @@ module_init(init); @ defines_module_exit @ identifier exit; @@ module_exit(exit); @ declares_idr depends on defines_module_init && defines_module_exit @ identifier idr; @@ DEFINE_IDR(idr); @ on_exit_calls_destroy depends on declares_idr && defines_module_exit @ identifier declares_idr.idr, defines_module_exit.exit; @@ exit(void) { ... idr_destroy(&idr); ... } @ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @ identifier declares_idr.idr, defines_module_exit.exit; @@ exit(void) { ... +idr_destroy(&idr); } </SmPL> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- drivers/misc/cxl/main.c | 1 + 1 file changed, 1 insertion(+)