| Message ID | 1395754915-14534-3-git-send-email-valentin.longchamp@keymile.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Scott Wood |
| Headers | show |
On Tue, 2014-03-25 at 14:41 +0100, Valentin Longchamp wrote: > These are the bindings for 2 MFD devices used on some of the Keymile boards. > The first one is the chassis managmenet bfticu FPGA. > The second one is the board controller (reset, LEDs, GPIOs) QRIO CPDL. > These FPGAs are used in the kmcoge4 board. > > This patch also add KEYMILE to the vendor-prefixes. > > Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com> > > --- > Changes in v3: > - add a patch with the bindings for the KEYMILE FPGAs > > Changes in v2: None > > Documentation/devicetree/bindings/mfd/bfticu.txt | 26 ++++++++++++++++++++++ > Documentation/devicetree/bindings/mfd/qriox.txt | 17 ++++++++++++++ > .../devicetree/bindings/vendor-prefixes.txt | 1 + > 3 files changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/bfticu.txt > create mode 100644 Documentation/devicetree/bindings/mfd/qriox.txt > > diff --git a/Documentation/devicetree/bindings/mfd/bfticu.txt b/Documentation/devicetree/bindings/mfd/bfticu.txt > new file mode 100644 > index 0000000..92de32e > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/bfticu.txt > @@ -0,0 +1,26 @@ > +KEYMILE bfticu Chassis Management FPGA > + > +The bfticu is a multifunction device that manages the whole chassis. > +Its main functionality is to collect IRQs from the whole chassis and signals > +them to a single controller. > + > +Required properties: > +- compatible: "keymile,bfticu" > +- interrupt-controller: the bfticu FPGA is an interrupt controller > +- interrupts: the main IRQ line to signal the collected IRQs > +- #interrupt-cells : is 2 > + - The 1st cell is the local IRQ number on the bfticu > + - The 2nd cell is the type of the IRQ (IRQ_TYPE_xxx) Device tree bindings should not depend on the content of Linux headers. One is stable ABI, and the other isn't. If you want you can make the values the same for convenience, as is done by IPIC, CPM PIC, etc -- but the values need to be explicitly stated in the binding. It'll still break if the Linux values change (so it may not be a good idea to try to keep the values the same), but at least the fix would be in Linux code rather than an ABI change. > diff --git a/Documentation/devicetree/bindings/mfd/qriox.txt b/Documentation/devicetree/bindings/mfd/qriox.txt > new file mode 100644 > index 0000000..f301e2d > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/qriox.txt > @@ -0,0 +1,17 @@ > +KEYMILE qrio Board Control CPLD > + > +The qrio is a multifunction device that controls the KEYMILE boards based on > +the kmp204x design. > +It is consists of a reset controller, watchdog timer, LEDs, and 2 IRQ capable > +GPIO blocks. > + > +Required properties: > +- compatible: "keymile,qriox" > +- reg: access on the parent local bus (chip select, offset in chip select, size) > + > +Example: > + > + board-control@1,0 { > + compatible = "keymile,qriox"; > + reg = <1 0 0x80>; > + }; If it has GPIO blocks, shouldn't it be using the GPIO binding? -Scott
On 04/09/2014 02:44 AM, Scott Wood wrote: > On Tue, 2014-03-25 at 14:41 +0100, Valentin Longchamp wrote: >> These are the bindings for 2 MFD devices used on some of the Keymile boards. >> The first one is the chassis managmenet bfticu FPGA. >> The second one is the board controller (reset, LEDs, GPIOs) QRIO CPDL. >> These FPGAs are used in the kmcoge4 board. >> >> This patch also add KEYMILE to the vendor-prefixes. >> >> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com> >> >> --- >> Changes in v3: >> - add a patch with the bindings for the KEYMILE FPGAs >> >> Changes in v2: None >> >> Documentation/devicetree/bindings/mfd/bfticu.txt | 26 ++++++++++++++++++++++ >> Documentation/devicetree/bindings/mfd/qriox.txt | 17 ++++++++++++++ >> .../devicetree/bindings/vendor-prefixes.txt | 1 + >> 3 files changed, 44 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/bfticu.txt >> create mode 100644 Documentation/devicetree/bindings/mfd/qriox.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/bfticu.txt b/Documentation/devicetree/bindings/mfd/bfticu.txt >> new file mode 100644 >> index 0000000..92de32e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/bfticu.txt >> @@ -0,0 +1,26 @@ >> +KEYMILE bfticu Chassis Management FPGA >> + >> +The bfticu is a multifunction device that manages the whole chassis. >> +Its main functionality is to collect IRQs from the whole chassis and signals >> +them to a single controller. >> + >> +Required properties: >> +- compatible: "keymile,bfticu" >> +- interrupt-controller: the bfticu FPGA is an interrupt controller >> +- interrupts: the main IRQ line to signal the collected IRQs >> +- #interrupt-cells : is 2 >> + - The 1st cell is the local IRQ number on the bfticu >> + - The 2nd cell is the type of the IRQ (IRQ_TYPE_xxx) > > Device tree bindings should not depend on the content of Linux headers. > One is stable ABI, and the other isn't. > > If you want you can make the values the same for convenience, as is done > by IPIC, CPM PIC, etc -- but the values need to be explicitly stated in > the binding. It'll still break if the Linux values change (so it may > not be a good idea to try to keep the values the same), but at least the > fix would be in Linux code rather than an ABI change. OK. I will then explicitly give the list of the values. > >> diff --git a/Documentation/devicetree/bindings/mfd/qriox.txt b/Documentation/devicetree/bindings/mfd/qriox.txt >> new file mode 100644 >> index 0000000..f301e2d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/qriox.txt >> @@ -0,0 +1,17 @@ >> +KEYMILE qrio Board Control CPLD >> + >> +The qrio is a multifunction device that controls the KEYMILE boards based on >> +the kmp204x design. >> +It is consists of a reset controller, watchdog timer, LEDs, and 2 IRQ capable >> +GPIO blocks. >> + >> +Required properties: >> +- compatible: "keymile,qriox" >> +- reg: access on the parent local bus (chip select, offset in chip select, size) >> + >> +Example: >> + >> + board-control@1,0 { >> + compatible = "keymile,qriox"; >> + reg = <1 0 0x80>; >> + }; > > If it has GPIO blocks, shouldn't it be using the GPIO binding? > You are right it should. But this is currently being reworked (also in HW) and that's why I left it out completely, instead of submitting something subject to change. Valentin
On Tue, Apr 8, 2014 at 7:44 PM, Scott Wood <scottwood@freescale.com> wrote: > On Tue, 2014-03-25 at 14:41 +0100, Valentin Longchamp wrote: >> These are the bindings for 2 MFD devices used on some of the Keymile boards. >> The first one is the chassis managmenet bfticu FPGA. >> The second one is the board controller (reset, LEDs, GPIOs) QRIO CPDL. >> These FPGAs are used in the kmcoge4 board. >> >> This patch also add KEYMILE to the vendor-prefixes. You can drop the keymile addition. I have that queued up. [snip] >> +Required properties: >> +- compatible: "keymile,bfticu" >> +- interrupt-controller: the bfticu FPGA is an interrupt controller >> +- interrupts: the main IRQ line to signal the collected IRQs >> +- #interrupt-cells : is 2 >> + - The 1st cell is the local IRQ number on the bfticu >> + - The 2nd cell is the type of the IRQ (IRQ_TYPE_xxx) > > Device tree bindings should not depend on the content of Linux headers. > One is stable ABI, and the other isn't. > > If you want you can make the values the same for convenience, as is done > by IPIC, CPM PIC, etc -- but the values need to be explicitly stated in > the binding. It'll still break if the Linux values change (so it may > not be a good idea to try to keep the values the same), but at least the > fix would be in Linux code rather than an ABI change. You can simply refer to Documentation/devicetree/bindings/interrupt-controller/interrupts.txt. Rob
diff --git a/Documentation/devicetree/bindings/mfd/bfticu.txt b/Documentation/devicetree/bindings/mfd/bfticu.txt new file mode 100644 index 0000000..92de32e --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/bfticu.txt @@ -0,0 +1,26 @@ +KEYMILE bfticu Chassis Management FPGA + +The bfticu is a multifunction device that manages the whole chassis. +Its main functionality is to collect IRQs from the whole chassis and signals +them to a single controller. + +Required properties: +- compatible: "keymile,bfticu" +- interrupt-controller: the bfticu FPGA is an interrupt controller +- interrupts: the main IRQ line to signal the collected IRQs +- #interrupt-cells : is 2 + - The 1st cell is the local IRQ number on the bfticu + - The 2nd cell is the type of the IRQ (IRQ_TYPE_xxx) +- interrupt-parent: the parent IRQ ctrl the main IRQ is connected to +- reg: access on the parent local bus (chip select, offset in chip select, size) + +Example: + + chassis-mgmt@3,0 { + compatible = "keymile,bfticu"; + interrupt-controller; + #interrupt-cells = <2>; + reg = <3 0 0x100>; + interrupt-parent = <&mpic>; + interrupts = <6 1 0 0>; + }; diff --git a/Documentation/devicetree/bindings/mfd/qriox.txt b/Documentation/devicetree/bindings/mfd/qriox.txt new file mode 100644 index 0000000..f301e2d --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/qriox.txt @@ -0,0 +1,17 @@ +KEYMILE qrio Board Control CPLD + +The qrio is a multifunction device that controls the KEYMILE boards based on +the kmp204x design. +It is consists of a reset controller, watchdog timer, LEDs, and 2 IRQ capable +GPIO blocks. + +Required properties: +- compatible: "keymile,qriox" +- reg: access on the parent local bus (chip select, offset in chip select, size) + +Example: + + board-control@1,0 { + compatible = "keymile,qriox"; + reg = <1 0 0x80>; + }; diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 4a6eba0..913a007 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -49,6 +49,7 @@ img Imagination Technologies Ltd. intercontrol Inter Control Group isl Intersil karo Ka-Ro electronics GmbH +keymile KEYMILE GmbH lg LG Corporation linux Linux-specific binding lsi LSI Corp. (LSI Logic)
These are the bindings for 2 MFD devices used on some of the Keymile boards. The first one is the chassis managmenet bfticu FPGA. The second one is the board controller (reset, LEDs, GPIOs) QRIO CPDL. These FPGAs are used in the kmcoge4 board. This patch also add KEYMILE to the vendor-prefixes. Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com> --- Changes in v3: - add a patch with the bindings for the KEYMILE FPGAs Changes in v2: None Documentation/devicetree/bindings/mfd/bfticu.txt | 26 ++++++++++++++++++++++ Documentation/devicetree/bindings/mfd/qriox.txt | 17 ++++++++++++++ .../devicetree/bindings/vendor-prefixes.txt | 1 + 3 files changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/bfticu.txt create mode 100644 Documentation/devicetree/bindings/mfd/qriox.txt