| Message ID | 1392964293-13687-2-git-send-email-alistair@popple.id.au (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Friday 21 February 2014 17:31:27 Alistair Popple wrote: > > +config MMC_SDHCI_OF_476GTR > + tristate "SDHCI OF support for the IBM PPC476GTR SoC" > + depends on MMC_SDHCI_PLTFM > + depends on PPC_OF > + help > + This selects the Secure Digital Host Controller Interface (SDHCI) > + found on the PPC476GTR SoC. > + > + If you have a controller with this interface, say Y or M here. > + > + If unsure, say N. Your driver doesn't actually do anything beyond what is in the common sdhci-pltfm.c infrastructure. IMHO you really shoulnd't need a SoC specific abstraction for it at all and instead add a generic platform driver registration into sdhci-pltfm.c. I'd suggest you use "generic-sdhci" (similar to what we do for usb-ohci and usb-ehci now) as the compatible string and change your device tree to claim compatibility with that and your soc-specific string. Arnd
On Fri, 21 Feb 2014 15:14:30 Arnd Bergmann wrote: > On Friday 21 February 2014 17:31:27 Alistair Popple wrote: > > +config MMC_SDHCI_OF_476GTR > > + tristate "SDHCI OF support for the IBM PPC476GTR SoC" > > + depends on MMC_SDHCI_PLTFM > > + depends on PPC_OF > > + help > > + This selects the Secure Digital Host Controller Interface (SDHCI) > > + found on the PPC476GTR SoC. > > + > > + If you have a controller with this interface, say Y or M here. > > + > > + If unsure, say N. > > Your driver doesn't actually do anything beyond what is in the common > sdhci-pltfm.c infrastructure. IMHO you really shoulnd't need a SoC > specific abstraction for it at all and instead add a generic > platform driver registration into sdhci-pltfm.c. I'd suggest > you use "generic-sdhci" (similar to what we do for usb-ohci and usb-ehci > now) as the compatible string and change your device tree to claim > compatibility with that and your soc-specific string. That's a reasonable point. I guess I was just following the example set by the other sdhci-* drivers. However on review they're not as generic as this one so I will merge this into sdhci-pltfm.c as suggested. - Alistair > Arnd
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 7fc5099..14210df 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -130,6 +130,18 @@ config MMC_SDHCI_OF_HLWD If unsure, say N. +config MMC_SDHCI_OF_476GTR + tristate "SDHCI OF support for the IBM PPC476GTR SoC" + depends on MMC_SDHCI_PLTFM + depends on PPC_OF + help + This selects the Secure Digital Host Controller Interface (SDHCI) + found on the PPC476GTR SoC. + + If you have a controller with this interface, say Y or M here. + + If unsure, say N. + config MMC_SDHCI_CNS3XXX tristate "SDHCI support on the Cavium Networks CNS3xxx SoC" depends on ARCH_CNS3XXX diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile index c41d0c3..92beff3 100644 --- a/drivers/mmc/host/Makefile +++ b/drivers/mmc/host/Makefile @@ -59,6 +59,7 @@ obj-$(CONFIG_MMC_SDHCI_DOVE) += sdhci-dove.o obj-$(CONFIG_MMC_SDHCI_TEGRA) += sdhci-tegra.o obj-$(CONFIG_MMC_SDHCI_OF_ESDHC) += sdhci-of-esdhc.o obj-$(CONFIG_MMC_SDHCI_OF_HLWD) += sdhci-of-hlwd.o +obj-$(CONFIG_MMC_SDHCI_OF_476GTR) += sdhci-of-476gtr.o obj-$(CONFIG_MMC_SDHCI_BCM_KONA) += sdhci-bcm-kona.o obj-$(CONFIG_MMC_SDHCI_BCM2835) += sdhci-bcm2835.o diff --git a/drivers/mmc/host/sdhci-of-476gtr.c b/drivers/mmc/host/sdhci-of-476gtr.c new file mode 100644 index 0000000..1310f8c --- /dev/null +++ b/drivers/mmc/host/sdhci-of-476gtr.c @@ -0,0 +1,60 @@ +/* + * drivers/mmc/host/sdhci-of-476gtr.c + * + * Copyright © 2013 Alistair Popple <alistair@popple.id.au> IBM Corporation + * + * Based on sdhci-of-hlwd.c + * + * Copyright (C) 2009 The GameCube Linux Team + * Copyright (C) 2009 Albert Herranz + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or (at + * your option) any later version. + */ + +#include <linux/delay.h> +#include <linux/module.h> +#include <linux/mmc/host.h> +#include "sdhci-pltfm.h" + +static const struct sdhci_ops sdhci_476gtr_ops = { +}; + +static const struct sdhci_pltfm_data sdhci_476gtr_pdata = { + .ops = &sdhci_476gtr_ops, +}; + +static int sdhci_476gtr_probe(struct platform_device *pdev) +{ + return sdhci_pltfm_register(pdev, &sdhci_476gtr_pdata, 0); +} + +static int sdhci_476gtr_remove(struct platform_device *pdev) +{ + return sdhci_pltfm_unregister(pdev); +} + +static const struct of_device_id sdhci_476gtr_of_match[] = { + { .compatible = "ibm,476gtr-sdhci" }, + { } +}; +MODULE_DEVICE_TABLE(of, sdhci_476gtr_of_match); + +static struct platform_driver sdhci_476gtr_driver = { + .driver = { + .name = "sdhci-476gtr", + .owner = THIS_MODULE, + .of_match_table = sdhci_476gtr_of_match, + .pm = SDHCI_PLTFM_PMOPS, + }, + .probe = sdhci_476gtr_probe, + .remove = sdhci_476gtr_remove, +}; + +module_platform_driver(sdhci_476gtr_driver); + +MODULE_DESCRIPTION("PPC476GTR SDHCI OF driver"); +MODULE_AUTHOR("Alistair Popple"); +MODULE_LICENSE("GPL v2");
This patch adds a SDHCI platform driver for the new IBM PPC476GTR SoC which is on the Akebono board. Signed-off-by: Alistair Popple <alistair@popple.id.au> --- drivers/mmc/host/Kconfig | 12 ++++++++ drivers/mmc/host/Makefile | 1 + drivers/mmc/host/sdhci-of-476gtr.c | 60 ++++++++++++++++++++++++++++++++++++ 3 files changed, 73 insertions(+) create mode 100644 drivers/mmc/host/sdhci-of-476gtr.c