| Message ID | 1333085936-8977-1-git-send-email-shawn.guo@linaro.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 6d4ae2ddfeb6e361569bf0f4a477157113e8a74a |
| Delegated to: | Kumar Gala |
| Headers | show |
Kumar, Gentle ping ... Regards, Shawn On Fri, Mar 30, 2012 at 01:38:56PM +0800, Shawn Guo wrote: > Freescale PowerPC SoCs share a number of IP blocks with Freescale > ARM/IMX SoCs, FlexCAN, SSI, FEC, eSDHC, USB, etc. There are some > effort consolidating those drivers to make them work for both > architectures. > > One outstanding difference between two architectures is ARM/IMX will > turn off module clocks during platform initialization for power saving > and expects drivers manage clocks using clk API, while PowerPC > mostly does not do that, and thus does not always build in clk API. > > Listing all those driver Kconfig options in "select PPC_CLOCK if" seems > not scalable for long term maintenance, and could easily introduce > Kconfig recursive dependency. This patch chooses to select PPC_CLOCK > unconditionally for FSL_SOC to always build clk API for PowerPC in. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > arch/powerpc/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index feab3ba..63fa7fb 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -661,7 +661,7 @@ config SBUS > config FSL_SOC > bool > select HAVE_CAN_FLEXCAN if NET && CAN > - select PPC_CLOCK if CAN_FLEXCAN > + select PPC_CLOCK > > config FSL_PCI > bool > -- > 1.7.5.4 >
On Apr 4, 2012, at 8:32 AM, Shawn Guo wrote: > Kumar, > > Gentle ping ... > > Regards, > Shawn Was on a bit of travel to nowhere, but that's a different story. What timeframe are you looking for this to go in? 3.4 or 3.5? - k > > On Fri, Mar 30, 2012 at 01:38:56PM +0800, Shawn Guo wrote: >> Freescale PowerPC SoCs share a number of IP blocks with Freescale >> ARM/IMX SoCs, FlexCAN, SSI, FEC, eSDHC, USB, etc. There are some >> effort consolidating those drivers to make them work for both >> architectures. >> >> One outstanding difference between two architectures is ARM/IMX will >> turn off module clocks during platform initialization for power saving >> and expects drivers manage clocks using clk API, while PowerPC >> mostly does not do that, and thus does not always build in clk API. >> >> Listing all those driver Kconfig options in "select PPC_CLOCK if" seems >> not scalable for long term maintenance, and could easily introduce >> Kconfig recursive dependency. This patch chooses to select PPC_CLOCK >> unconditionally for FSL_SOC to always build clk API for PowerPC in. >> >> Signed-off-by: Shawn Guo <shawn.guo@linaro.org> >> --- >> arch/powerpc/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig >> index feab3ba..63fa7fb 100644 >> --- a/arch/powerpc/Kconfig >> +++ b/arch/powerpc/Kconfig >> @@ -661,7 +661,7 @@ config SBUS >> config FSL_SOC >> bool >> select HAVE_CAN_FLEXCAN if NET && CAN >> - select PPC_CLOCK if CAN_FLEXCAN >> + select PPC_CLOCK >> >> config FSL_PCI >> bool >> -- >> 1.7.5.4 >>
On 4 April 2012 23:00, Kumar Gala <galak@kernel.crashing.org> wrote: ... > What timeframe are you looking for this to go in? 3.4 or 3.5? > 3.5 Thanks, Shawn
On Mar 30, 2012, at 12:38 AM, Shawn Guo wrote: > Freescale PowerPC SoCs share a number of IP blocks with Freescale > ARM/IMX SoCs, FlexCAN, SSI, FEC, eSDHC, USB, etc. There are some > effort consolidating those drivers to make them work for both > architectures. > > One outstanding difference between two architectures is ARM/IMX will > turn off module clocks during platform initialization for power saving > and expects drivers manage clocks using clk API, while PowerPC > mostly does not do that, and thus does not always build in clk API. > > Listing all those driver Kconfig options in "select PPC_CLOCK if" seems > not scalable for long term maintenance, and could easily introduce > Kconfig recursive dependency. This patch chooses to select PPC_CLOCK > unconditionally for FSL_SOC to always build clk API for PowerPC in. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > arch/powerpc/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) applied to next - k
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index feab3ba..63fa7fb 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -661,7 +661,7 @@ config SBUS config FSL_SOC bool select HAVE_CAN_FLEXCAN if NET && CAN - select PPC_CLOCK if CAN_FLEXCAN + select PPC_CLOCK config FSL_PCI bool
Freescale PowerPC SoCs share a number of IP blocks with Freescale ARM/IMX SoCs, FlexCAN, SSI, FEC, eSDHC, USB, etc. There are some effort consolidating those drivers to make them work for both architectures. One outstanding difference between two architectures is ARM/IMX will turn off module clocks during platform initialization for power saving and expects drivers manage clocks using clk API, while PowerPC mostly does not do that, and thus does not always build in clk API. Listing all those driver Kconfig options in "select PPC_CLOCK if" seems not scalable for long term maintenance, and could easily introduce Kconfig recursive dependency. This patch chooses to select PPC_CLOCK unconditionally for FSL_SOC to always build clk API for PowerPC in. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> --- arch/powerpc/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)