| Message ID | 1321099352-21462-4-git-send-email-Gang.Liu@freescale.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Kumar Gala |
| Headers | show |
On 11/12/2011 06:02 AM, Liu Gang wrote: > From: Kai Jiang <Kai.Jiang@freescale.com> > > Update of_platform_bus_probe() RapidIO node to be compitable with > new RapidIO dts compatible property. > > Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com> > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > --- > arch/powerpc/platforms/85xx/corenet_ds.c | 2 +- > arch/powerpc/platforms/85xx/mpc85xx_mds.c | 2 +- > arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/platforms/85xx/corenet_ds.c b/arch/powerpc/platforms/85xx/corenet_ds.c > index 802ad11..c48b661 100644 > --- a/arch/powerpc/platforms/85xx/corenet_ds.c > +++ b/arch/powerpc/platforms/85xx/corenet_ds.c > @@ -112,7 +112,7 @@ static const struct of_device_id of_device_ids[] __devinitconst = { > .compatible = "simple-bus" > }, > { > - .compatible = "fsl,rapidio-delta", > + .compatible = "fsl,srio", fsl,srio is too vague. We need to identify the specific hardware (or at least a concrete programming interface document), not just the bus that the hardware implements. -Scott
On 11/14/2011 11:35 AM, Scott Wood wrote: > On 11/12/2011 06:02 AM, Liu Gang wrote: >> From: Kai Jiang <Kai.Jiang@freescale.com> >> >> Update of_platform_bus_probe() RapidIO node to be compitable with >> new RapidIO dts compatible property. >> >> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com> >> Signed-off-by: Kumar Gala <galak@kernel.crashing.org> >> --- >> arch/powerpc/platforms/85xx/corenet_ds.c | 2 +- >> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 2 +- >> arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/powerpc/platforms/85xx/corenet_ds.c b/arch/powerpc/platforms/85xx/corenet_ds.c >> index 802ad11..c48b661 100644 >> --- a/arch/powerpc/platforms/85xx/corenet_ds.c >> +++ b/arch/powerpc/platforms/85xx/corenet_ds.c >> @@ -112,7 +112,7 @@ static const struct of_device_id of_device_ids[] __devinitconst = { >> .compatible = "simple-bus" >> }, >> { >> - .compatible = "fsl,rapidio-delta", >> + .compatible = "fsl,srio", > > fsl,srio is too vague. We need to identify the specific hardware (or at > least a concrete programming interface document), not just the bus that > the hardware implements. Never mind, I see that the binding is more specific about what this string means. Next time have the binding come first. :-) -Scott
Yeah, send binding first should be better for reviewing entire set of patches. Thanks! -----Original Message----- From: Wood Scott-B07421 Sent: Tuesday, November 15, 2011 1:37 AM To: Liu Gang-B34182 Cc: Li Yang-R58472; Jiang Kai-B18973; linux-kernel@vger.kernel.org; Zang Roy-R61911; Alexandre.Bounine@idt.com; akpm@linux-foundation.org; linuxppc-dev@lists.ozlabs.org; Gala Kumar-B11780 Subject: Re: [PATCH 4/5, v3] powerpc/8xxx: Update device tree bus probe for new RapidIO node binding On 11/14/2011 11:35 AM, Scott Wood wrote: > On 11/12/2011 06:02 AM, Liu Gang wrote: >> From: Kai Jiang <Kai.Jiang@freescale.com> >> >> Update of_platform_bus_probe() RapidIO node to be compitable with new >> RapidIO dts compatible property. >> >> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com> >> Signed-off-by: Kumar Gala <galak@kernel.crashing.org> >> --- >> arch/powerpc/platforms/85xx/corenet_ds.c | 2 +- >> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 2 +- >> arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/powerpc/platforms/85xx/corenet_ds.c >> b/arch/powerpc/platforms/85xx/corenet_ds.c >> index 802ad11..c48b661 100644 >> --- a/arch/powerpc/platforms/85xx/corenet_ds.c >> +++ b/arch/powerpc/platforms/85xx/corenet_ds.c >> @@ -112,7 +112,7 @@ static const struct of_device_id of_device_ids[] __devinitconst = { >> .compatible = "simple-bus" >> }, >> { >> - .compatible = "fsl,rapidio-delta", >> + .compatible = "fsl,srio", > > fsl,srio is too vague. We need to identify the specific hardware (or > at least a concrete programming interface document), not just the bus > that the hardware implements. Never mind, I see that the binding is more specific about what this string means. Next time have the binding come first. :-) -Scott
On Nov 16, 2011, at 7:48 AM, Bounine, Alexandre wrote: >> -----Original Message----- >> From: Liu Gang [mailto:Gang.Liu@freescale.com] >> Sent: Saturday, November 12, 2011 7:03 AM >> To: linuxppc-dev@lists.ozlabs.org; Bounine, Alexandre >> Cc: akpm@linux-foundation.org; linux-kernel@vger.kernel.org; >> r58472@freescale.com; B11780@freescale.com; r61911@freescale.com; Kai >> Jiang; Kumar Gala >> Subject: [PATCH 4/5,v3] powerpc/8xxx: Update device tree bus probe for >> new RapidIO node binding >> >> From: Kai Jiang <Kai.Jiang@freescale.com> >> >> Update of_platform_bus_probe() RapidIO node to be compitable with >> new RapidIO dts compatible property. >> >> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com> >> Signed-off-by: Kumar Gala <galak@kernel.crashing.org> >> --- >> arch/powerpc/platforms/85xx/corenet_ds.c | 2 +- >> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 2 +- >> arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> > > Acked-by: Alexandre Bounine <alexandre.bounine@idt.com> applied to 'next' - k
diff --git a/arch/powerpc/platforms/85xx/corenet_ds.c b/arch/powerpc/platforms/85xx/corenet_ds.c index 802ad11..c48b661 100644 --- a/arch/powerpc/platforms/85xx/corenet_ds.c +++ b/arch/powerpc/platforms/85xx/corenet_ds.c @@ -112,7 +112,7 @@ static const struct of_device_id of_device_ids[] __devinitconst = { .compatible = "simple-bus" }, { - .compatible = "fsl,rapidio-delta", + .compatible = "fsl,srio", }, { .compatible = "fsl,p4080-pcie", diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c index a23a3ff..7968ced 100644 --- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c +++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c @@ -433,7 +433,7 @@ static struct of_device_id mpc85xx_ids[] = { { .compatible = "soc", }, { .compatible = "simple-bus", }, { .compatible = "gianfar", }, - { .compatible = "fsl,rapidio-delta", }, + { .compatible = "fsl,srio", }, { .compatible = "fsl,mpc8548-guts", }, { .compatible = "gpio-leds", }, {}, diff --git a/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c b/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c index b11c353..569262c 100644 --- a/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c +++ b/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c @@ -161,7 +161,7 @@ mpc86xx_time_init(void) static __initdata struct of_device_id of_bus_ids[] = { { .compatible = "simple-bus", }, - { .compatible = "fsl,rapidio-delta", }, + { .compatible = "fsl,srio", }, { .compatible = "gianfar", }, {}, };