Message ID | 1301984051-18413-3-git-send-email-benh@kernel.crashing.org (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
On Tue, 2011-04-05 at 16:13 +1000, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > --- > arch/powerpc/kernel/rtas.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c > index 2097f2b..c2bfc4d 100644 > --- a/arch/powerpc/kernel/rtas.c > +++ b/arch/powerpc/kernel/rtas.c > @@ -591,6 +591,8 @@ bool rtas_indicator_present(int token, int *maxindex) > u32 maxindex; > } *indicators; > > + if (!rtas.dev) > + return false; > indicators = of_get_property(rtas.dev, "rtas-indicators", &proplen); > if (!indicators) > return false; Why? of_get_property() returns NULL if np is NULL, implemented in of_find_property(). It doesn't look like a fast path. cheers
> Why? of_get_property() returns NULL if np is NULL, implemented in > of_find_property(). It doesn't look like a fast path. Fun... not sure, I though I had a problem but maybe I don't remember properly :-) Cheers, Ben.
diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c index 2097f2b..c2bfc4d 100644 --- a/arch/powerpc/kernel/rtas.c +++ b/arch/powerpc/kernel/rtas.c @@ -591,6 +591,8 @@ bool rtas_indicator_present(int token, int *maxindex) u32 maxindex; } *indicators; + if (!rtas.dev) + return false; indicators = of_get_property(rtas.dev, "rtas-indicators", &proplen); if (!indicators) return false;
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- arch/powerpc/kernel/rtas.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)