| Message ID | 1241640919-4650-6-git-send-email-wd@denx.de (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | Grant Likely |
| Headers | show |
On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk <wd@denx.de> wrote: > From: Piotr Ziecik <kosmo@semihalf.com> > > Signed-off-by: Piotr Ziecik <kosmo@semihalf.com> > Signed-off-by: Wolfgang Denk <wd@denx.de> > Cc: Grant Likely <grant.likely@secretlab.ca> > Cc: John Rigby <jcrigby@gmail.com> Missing patch description. Otherwise looks okay. g. > --- > arch/powerpc/boot/dts/mpc5121ads.dts | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts b/arch/powerpc/boot/dts/mpc5121ads.dts > index c2b8dbf..1b83a9d 100644 > --- a/arch/powerpc/boot/dts/mpc5121ads.dts > +++ b/arch/powerpc/boot/dts/mpc5121ads.dts > @@ -166,6 +166,11 @@ > interrupt-parent = < &ipic >; > }; > > + reset@e00 { // Reset module > + compatible = "fsl,mpc5121-reset"; > + reg = <0xe00 0x100>; > + }; > + > clock@f00 { // Clock control > compatible = "fsl,mpc5121-clock"; > reg = <0xf00 0x100>; > -- > 1.6.0.6 > >
Dear Grant Likely, In message <fa686aa40905061340s212385b1r8be4e2f7505bd0a0@mail.gmail.com> you wrote: > On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk <wd@denx.de> wrote: > > From: Piotr Ziecik <kosmo@semihalf.com> > > > > Signed-off-by: Piotr Ziecik <kosmo@semihalf.com> > > Signed-off-by: Wolfgang Denk <wd@denx.de> > > Cc: Grant Likely <grant.likely@secretlab.ca> > > Cc: John Rigby <jcrigby@gmail.com> > > Missing patch description. Otherwise looks okay. This is a repeating complaint. Do I really need an extra description for a trivial patch that does exactly what the Subject: says? What is recommended practice in such a case? Best regards, Wolfgang Denk
On Wed, May 6, 2009 at 4:16 PM, Wolfgang Denk <wd@denx.de> wrote: > Dear Grant Likely, > > In message <fa686aa40905061340s212385b1r8be4e2f7505bd0a0@mail.gmail.com> you wrote: >> On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk <wd@denx.de> wrote: >> > From: Piotr Ziecik <kosmo@semihalf.com> >> > >> > Signed-off-by: Piotr Ziecik <kosmo@semihalf.com> >> > Signed-off-by: Wolfgang Denk <wd@denx.de> >> > Cc: Grant Likely <grant.likely@secretlab.ca> >> > Cc: John Rigby <jcrigby@gmail.com> >> >> Missing patch description. Otherwise looks okay. > > This is a repeating complaint. Do I really need an extra description > for a trivial patch that does exactly what the Subject: says? Fair enough. I was going through your series pretty quickly and this one doesn't really need it. However, in this particular case, I think I would rather see both .dts rework patches put into the same patch so it can be reviewed all at once. g.
diff --git a/arch/powerpc/boot/dts/mpc5121ads.dts b/arch/powerpc/boot/dts/mpc5121ads.dts index c2b8dbf..1b83a9d 100644 --- a/arch/powerpc/boot/dts/mpc5121ads.dts +++ b/arch/powerpc/boot/dts/mpc5121ads.dts @@ -166,6 +166,11 @@ interrupt-parent = < &ipic >; }; + reset@e00 { // Reset module + compatible = "fsl,mpc5121-reset"; + reg = <0xe00 0x100>; + }; + clock@f00 { // Clock control compatible = "fsl,mpc5121-clock"; reg = <0xf00 0x100>;