mbox series

[RFC,0/8] Remove unneccessary included headers

Message ID cover.1527697995.git.christophe.leroy@c-s.fr (mailing list archive)
Headers show
Series Remove unneccessary included headers | expand

Message

Christophe Leroy May 30, 2018, 4:41 p.m. UTC 
The purpose of this serie is to limit the number of includes to
only the necessary ones in order to reduce the number of files
recompiled everytime a header file is modified.

This is the start of the work, please provide feedback if any so
that I don't go in the wrong direction.

Christophe Leroy (8):
  powerpc: remove kdump.h from page.h
  powerpc: remove unneeded inclusions of cpu_has_feature.h
  powerpc: remove superflous inclusions of asm-compat.h
  powerpc: remove superflous inclusions of asm/feature-fixups.h
  powerpc: remove superflous inclusions of asm/fixmap.h
  powerpc: declare set_breakpoint() static
  powerpc/book3s: Remove PPC_PIN_SIZE
  powerpc: fix includes in asm/processor.h

 arch/powerpc/include/asm/book3s/32/pgtable.h |  5 -----
 arch/powerpc/include/asm/cacheflush.h        |  1 -
 arch/powerpc/include/asm/cputable.h          |  2 --
 arch/powerpc/include/asm/cputime.h           |  1 -
 arch/powerpc/include/asm/dbell.h             |  1 -
 arch/powerpc/include/asm/debug.h             |  1 -
 arch/powerpc/include/asm/dt_cpu_ftrs.h       |  3 ---
 arch/powerpc/include/asm/feature-fixups.h    |  2 ++
 arch/powerpc/include/asm/firmware.h          |  1 -
 arch/powerpc/include/asm/fixmap.h            |  2 --
 arch/powerpc/include/asm/hw_breakpoint.h     |  1 +
 arch/powerpc/include/asm/mmu.h               |  1 -
 arch/powerpc/include/asm/nohash/32/pgtable.h |  2 +-
 arch/powerpc/include/asm/page.h              |  1 -
 arch/powerpc/include/asm/ppc-opcode.h        |  1 -
 arch/powerpc/include/asm/processor.h         |  5 ++---
 arch/powerpc/include/asm/reg.h               |  1 +
 arch/powerpc/kernel/head_8xx.S               |  1 -
 arch/powerpc/kernel/process.c                | 14 +++++++-------
 arch/powerpc/kernel/setup_32.c               |  1 +
 arch/powerpc/kernel/vdso.c                   |  1 -
 arch/powerpc/mm/dump_hashpagetable.c         |  1 -
 arch/powerpc/sysdev/cpm_common.c             |  1 -
 23 files changed, 15 insertions(+), 35 deletions(-)

Comments

Michael Ellerman May 31, 2018, 9:55 a.m. UTC | #1 
Christophe Leroy <christophe.leroy@c-s.fr> writes:

> The purpose of this serie is to limit the number of includes to
> only the necessary ones in order to reduce the number of files
> recompiled everytime a header file is modified.
>
> This is the start of the work, please provide feedback if any so
> that I don't go in the wrong direction.

Thanks for starting on this.

There's a few build errors, summary below.

  http://kisskb.ellerman.id.au/kisskb/head/14031/

cheers

arch/powerpc/kernel/machine_kexec.c:140:26: error: 'KDUMP_KERNELBASE' undeclared (first use in this function):
  corenet32_smp_defconfig powerpc
  corenet32_smp_defconfig powerpc-5.3
  g5_defconfig powerpc
  g5_defconfig powerpc-5.3
  gamecube_defconfig powerpc
  gamecube_defconfig powerpc-5.3
  maple_defconfig powerpc
  maple_defconfig powerpc-5.3
  mpc85xx_defconfig powerpc
  mpc85xx_defconfig powerpc-5.3
  mpc85xx_smp_defconfig powerpc
  mpc85xx_smp_defconfig powerpc-5.3
  mpc86xx_defconfig powerpc
  mpc86xx_defconfig powerpc-5.3
  powernv_defconfig+NO_NUMA ppc64le
  powernv_defconfig+NO_PERF ppc64le
  powernv_defconfig+NO_RADIX ppc64le
  powernv_defconfig+STRICT_RWX ppc64le
  powernv_defconfig+THIN ppc64le
  powerpc-randconfig powerpc-5.3
  ppc64e_defconfig+KEXEC powerpc
  ppc64e_defconfig+KEXEC powerpc-5.3
  ps3_defconfig powerpc
  ps3_defconfig powerpc-5.3
  pseries_defconfig powerpc
  pseries_defconfig powerpc-5.3
  pseries_defconfig+NO_MEMORY_HOTPLUG powerpc
  pseries_defconfig+NO_MEMORY_HOTPLUG powerpc-5.3
  pseries_defconfig+NO_MEMORY_HOTREMOVE powerpc
  pseries_defconfig+NO_SPLPAR powerpc
  pseries_defconfig+NO_SPLPAR powerpc-5.3
  pseries_le_defconfig ppc64le
  pseries_le_defconfig+NO_NUMA ppc64le
  pseries_le_defconfig+NO_SPLPAR ppc64le
  skiroot_defconfig ppc64le
  wii_defconfig powerpc
  wii_defconfig powerpc-5.3

arch/powerpc/include/asm/cputable.h:146:23: error: implicit declaration of function 'ASM_CONST' [-Werror=implicit-function-declaration]:
  amigaone_defconfig powerpc-5.3
  corenet_basic_defconfig powerpc-5.3
  holly_defconfig powerpc-5.3
  mpc85xx_basic_defconfig powerpc-5.3
  pmac32_defconfig powerpc-5.3
  pmac32_defconfig+KVM powerpc-5.3
  pmac32_defconfig+kexec powerpc-5.3

arch/powerpc/include/asm/cputable.h:538:6: error: enumerator value for 'CPU_FTRS_POSSIBLE' is not an integer constant:
  44x/akebono_defconfig powerpc
  44x/akebono_defconfig powerpc-5.3
  44x/currituck_defconfig powerpc
  44x/currituck_defconfig powerpc-5.3
  amigaone_defconfig powerpc
  amigaone_defconfig powerpc-5.3
  chrp32_defconfig powerpc
  chrp32_defconfig powerpc-5.3
  corenet_basic_defconfig powerpc
  corenet_basic_defconfig powerpc-5.3
  holly_defconfig powerpc
  holly_defconfig powerpc-5.3
  mpc85xx_basic_defconfig powerpc
  mpc85xx_basic_defconfig powerpc-5.3
  pmac32_defconfig powerpc
  pmac32_defconfig powerpc-5.3
  pmac32_defconfig+KVM powerpc
  pmac32_defconfig+KVM powerpc-5.3
  pmac32_defconfig+SMP powerpc
  pmac32_defconfig+SMP powerpc-5.3
  pmac32_defconfig+kexec powerpc
  pmac32_defconfig+kexec powerpc-5.3
  ppc6xx_defconfig powerpc
  ppc6xx_defconfig powerpc-5.3

arch/powerpc/include/asm/cputable.h:614:6: error: enumerator value for 'CPU_FTRS_ALWAYS' is not an integer constant:
  44x/akebono_defconfig powerpc
  44x/akebono_defconfig powerpc-5.3
  44x/currituck_defconfig powerpc
  44x/currituck_defconfig powerpc-5.3
  amigaone_defconfig powerpc
  amigaone_defconfig powerpc-5.3
  chrp32_defconfig powerpc
  chrp32_defconfig powerpc-5.3
  corenet_basic_defconfig powerpc
  corenet_basic_defconfig powerpc-5.3
  holly_defconfig powerpc
  holly_defconfig powerpc-5.3
  mpc85xx_basic_defconfig powerpc
  mpc85xx_basic_defconfig powerpc-5.3
  pmac32_defconfig powerpc
  pmac32_defconfig powerpc-5.3
  pmac32_defconfig+KVM powerpc
  pmac32_defconfig+KVM powerpc-5.3
  pmac32_defconfig+SMP powerpc
  pmac32_defconfig+SMP powerpc-5.3
  pmac32_defconfig+kexec powerpc
  pmac32_defconfig+kexec powerpc-5.3
  ppc6xx_defconfig powerpc
  ppc6xx_defconfig powerpc-5.3

arch/powerpc/include/asm/cputable.h:505:6: error: implicit declaration of function 'ASM_CONST' [-Werror=implicit-function-declaration]:
  amigaone_defconfig powerpc
  chrp32_defconfig powerpc
  corenet_basic_defconfig powerpc
  holly_defconfig powerpc
  mpc85xx_basic_defconfig powerpc
  pmac32_defconfig powerpc
  pmac32_defconfig+KVM powerpc
  pmac32_defconfig+SMP powerpc
  pmac32_defconfig+kexec powerpc
  ppc6xx_defconfig powerpc

arch/powerpc/kernel/machine_kexec.c:155:22: error: 'KDUMP_KERNELBASE' undeclared (first use in this function):
  44x/fsp2_defconfig powerpc-5.3

arch/powerpc/include/asm/cputable.h:158:32: error: implicit declaration of function 'ASM_CONST' [-Werror=implicit-function-declaration]:
  44x/akebono_defconfig powerpc-5.3
  44x/currituck_defconfig powerpc-5.3
  chrp32_defconfig powerpc-5.3
  pmac32_defconfig+SMP powerpc-5.3
  ppc6xx_defconfig powerpc-5.3

arch/powerpc/include/asm/cputable.h:515:6: error: implicit declaration of function 'ASM_CONST' [-Werror=implicit-function-declaration]:
  44x/akebono_defconfig powerpc
  44x/currituck_defconfig powerpc