| Message ID | 20220415190817.842864-1-helgaas@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Remove unused SLOW_DOWN_IO | expand |
On Fri, 15 Apr 2022 14:08:10 -0500 Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > Only alpha, ia64, powerpc, and sh define SLOW_DOWN_IO, and there are no > actual uses of it. The few references to it are in situations that are > themselves unused. Remove them all. > > It should be safe to apply these independently and in any order. The only > place SLOW_DOWN_IO is used at all is the lmc_var.h definition of DELAY, > which is itself never used. Hi Bojrn! Would you mind reposting just patches 1 and 3 for networking? LMC got removed in net-next (commit a5b116a0fa90 ("net: wan: remove the lanmedia (lmc) driver")) so the entire series fails to apply and therefore defeats all of our patch handling scripts :S
On Fri, Apr 22, 2022 at 10:48:28AM -0700, Jakub Kicinski wrote: > On Fri, 15 Apr 2022 14:08:10 -0500 Bjorn Helgaas wrote: > > From: Bjorn Helgaas <bhelgaas@google.com> > > > > Only alpha, ia64, powerpc, and sh define SLOW_DOWN_IO, and there are no > > actual uses of it. The few references to it are in situations that are > > themselves unused. Remove them all. > > > > It should be safe to apply these independently and in any order. The only > > place SLOW_DOWN_IO is used at all is the lmc_var.h definition of DELAY, > > which is itself never used. > > Hi Bojrn! Would you mind reposting just patches 1 and 3 for networking? > LMC got removed in net-next (commit a5b116a0fa90 ("net: wan: remove the > lanmedia (lmc) driver")) so the entire series fails to apply and therefore > defeats all of our patch handling scripts :S Sure, coming up, with reduced cc: list.
On Fri, 15 Apr 2022 14:08:10 -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > Only alpha, ia64, powerpc, and sh define SLOW_DOWN_IO, and there are no > actual uses of it. The few references to it are in situations that are > themselves unused. Remove them all. > > It should be safe to apply these independently and in any order. The only > place SLOW_DOWN_IO is used at all is the lmc_var.h definition of DELAY, > which is itself never used. > > [...] Applied to powerpc/next. [5/7] powerpc: Remove unused SLOW_DOWN_IO definition https://git.kernel.org/powerpc/c/755a9d44e6e2a217cceaab9fe2c8bac55ee7f8b2 cheers
From: Bjorn Helgaas <bhelgaas@google.com> Only alpha, ia64, powerpc, and sh define SLOW_DOWN_IO, and there are no actual uses of it. The few references to it are in situations that are themselves unused. Remove them all. It should be safe to apply these independently and in any order. The only place SLOW_DOWN_IO is used at all is the lmc_var.h definition of DELAY, which is itself never used. Bjorn Helgaas (7): net: wan: atp: remove unused eeprom_delay() net: wan: lmc: remove unused DELAY() net: remove comments that mention obsolete __SLOW_DOWN_IO sh: remove unused SLOW_DOWN_IO powerpc: Remove unused SLOW_DOWN_IO definition ia64: remove unused __SLOW_DOWN_IO and SLOW_DOWN_IO definitions alpha: remove unused __SLOW_DOWN_IO and SLOW_DOWN_IO definitions arch/alpha/include/asm/io.h | 4 ---- arch/ia64/include/asm/io.h | 4 ---- arch/powerpc/include/asm/io.h | 2 -- arch/sh/include/asm/io.h | 17 ++--------------- drivers/atm/nicstarmac.c | 5 ----- drivers/net/ethernet/dec/tulip/winbond-840.c | 2 -- drivers/net/ethernet/natsemi/natsemi.c | 2 -- drivers/net/ethernet/realtek/atp.h | 4 ---- drivers/net/wan/lmc/lmc_main.c | 8 -------- drivers/net/wan/lmc/lmc_var.h | 8 -------- 10 files changed, 2 insertions(+), 54 deletions(-)