mbox series

[v4,0/4] ocxl: OpenCAPI Cleanup

Message ID 20190325053456.14599-1-alastair@au1.ibm.com (mailing list archive)
Headers show
Series ocxl: OpenCAPI Cleanup | expand

Message

Alastair D'Silva March 25, 2019, 5:34 a.m. UTC
From: Alastair D'Silva <alastair@d-silva.org>

Some minor cleanups for the OpenCAPI driver as a prerequisite
for an ocxl driver refactoring to allow the driver core to
be utilised by external drivers.

Changelog:
V4:
  - Drop printf format changes as they omit the format indicator for '0'
V3:
  - Add missed header in 'ocxl: Remove some unused exported symbols'.
    This addresses the introduced sparse warnings
V2:
  - remove intermediate assignment of 'link' var in
                'Rename struct link to ocxl_link'
  - Don't shift definition of ocxl_context_attach in
                'Remove some unused exported symbols'


Alastair D'Silva (4):
  ocxl: Rename struct link to ocxl_link
  ocxl: read_pasid never returns an error, so make it void
  ocxl: Remove superfluous 'extern' from headers
  ocxl: Remove some unused exported symbols

 drivers/misc/ocxl/config.c        | 13 ++---
 drivers/misc/ocxl/file.c          |  5 +-
 drivers/misc/ocxl/link.c          | 36 ++++++-------
 drivers/misc/ocxl/ocxl_internal.h | 85 +++++++++++++++++++------------
 include/misc/ocxl.h               | 53 ++++++-------------
 5 files changed, 91 insertions(+), 101 deletions(-)

Comments

Greg Kurz March 25, 2019, 4:49 p.m. UTC | #1
Hi Alastair,

I forgot to mention it during v3 but please don't link new version
of a patchset to the previous one with --in-reply-to. This is to
ensure I can see them in my email client without having to scroll
back many days in the past (which likely means a fair number of
e-mails on linuxppc-dev).

Cheers,

--
Greg

On Mon, 25 Mar 2019 16:34:51 +1100
"Alastair D'Silva" <alastair@au1.ibm.com> wrote:

> From: Alastair D'Silva <alastair@d-silva.org>
> 
> Some minor cleanups for the OpenCAPI driver as a prerequisite
> for an ocxl driver refactoring to allow the driver core to
> be utilised by external drivers.
> 
> Changelog:
> V4:
>   - Drop printf format changes as they omit the format indicator for '0'
> V3:
>   - Add missed header in 'ocxl: Remove some unused exported symbols'.
>     This addresses the introduced sparse warnings
> V2:
>   - remove intermediate assignment of 'link' var in
>                 'Rename struct link to ocxl_link'
>   - Don't shift definition of ocxl_context_attach in
>                 'Remove some unused exported symbols'
> 
> 
> Alastair D'Silva (4):
>   ocxl: Rename struct link to ocxl_link
>   ocxl: read_pasid never returns an error, so make it void
>   ocxl: Remove superfluous 'extern' from headers
>   ocxl: Remove some unused exported symbols
> 
>  drivers/misc/ocxl/config.c        | 13 ++---
>  drivers/misc/ocxl/file.c          |  5 +-
>  drivers/misc/ocxl/link.c          | 36 ++++++-------
>  drivers/misc/ocxl/ocxl_internal.h | 85 +++++++++++++++++++------------
>  include/misc/ocxl.h               | 53 ++++++-------------
>  5 files changed, 91 insertions(+), 101 deletions(-)
>
Frederic Barrat March 25, 2019, 5:34 p.m. UTC | #2
Le 25/03/2019 à 17:49, Greg Kurz a écrit :
> Hi Alastair,
> 
> I forgot to mention it during v3 but please don't link new version
> of a patchset to the previous one with --in-reply-to. This is to
> ensure I can see them in my email client without having to scroll
> back many days in the past (which likely means a fair number of
> e-mails on linuxppc-dev).


I'm also seeing the other series (ocxl refactoring) somehow under the 
same thread. I haven't checked why, and there may be some mail client 
bug in the way, I just mention it in case you see a reason for it in the 
way you submit the patch set.

   Fred


> 
> Cheers,
> 
> --
> Greg
> 
> On Mon, 25 Mar 2019 16:34:51 +1100
> "Alastair D'Silva" <alastair@au1.ibm.com> wrote:
> 
>> From: Alastair D'Silva <alastair@d-silva.org>
>>
>> Some minor cleanups for the OpenCAPI driver as a prerequisite
>> for an ocxl driver refactoring to allow the driver core to
>> be utilised by external drivers.
>>
>> Changelog:
>> V4:
>>    - Drop printf format changes as they omit the format indicator for '0'
>> V3:
>>    - Add missed header in 'ocxl: Remove some unused exported symbols'.
>>      This addresses the introduced sparse warnings
>> V2:
>>    - remove intermediate assignment of 'link' var in
>>                  'Rename struct link to ocxl_link'
>>    - Don't shift definition of ocxl_context_attach in
>>                  'Remove some unused exported symbols'
>>
>>
>> Alastair D'Silva (4):
>>    ocxl: Rename struct link to ocxl_link
>>    ocxl: read_pasid never returns an error, so make it void
>>    ocxl: Remove superfluous 'extern' from headers
>>    ocxl: Remove some unused exported symbols
>>
>>   drivers/misc/ocxl/config.c        | 13 ++---
>>   drivers/misc/ocxl/file.c          |  5 +-
>>   drivers/misc/ocxl/link.c          | 36 ++++++-------
>>   drivers/misc/ocxl/ocxl_internal.h | 85 +++++++++++++++++++------------
>>   include/misc/ocxl.h               | 53 ++++++-------------
>>   5 files changed, 91 insertions(+), 101 deletions(-)
>>
>
Alastair D'Silva March 25, 2019, 9:45 p.m. UTC | #3
> -----Original Message-----
> From: Frederic Barrat <fbarrat@linux.ibm.com>
> Sent: Tuesday, 26 March 2019 4:34 AM
> To: Greg Kurz <groug@kaod.org>; Alastair D'Silva <alastair@au1.ibm.com>
> Cc: alastair@d-silva.org; Arnd Bergmann <arnd@arndb.de>; Greg Kroah-
> Hartman <gregkh@linuxfoundation.org>; linux-kernel@vger.kernel.org;
> Andrew Donnellan <andrew.donnellan@au1.ibm.com>; linuxppc-
> dev@lists.ozlabs.org
> Subject: Re: [PATCH v4 0/4] ocxl: OpenCAPI Cleanup
> 
> 
> 
> Le 25/03/2019 à 17:49, Greg Kurz a écrit :
> > Hi Alastair,
> >
> > I forgot to mention it during v3 but please don't link new version of
> > a patchset to the previous one with --in-reply-to. This is to ensure I
> > can see them in my email client without having to scroll back many
> > days in the past (which likely means a fair number of e-mails on
> > linuxppc-dev).
> 
> 
> I'm also seeing the other series (ocxl refactoring) somehow under the same
> thread. I haven't checked why, and there may be some mail client bug in the
> way, I just mention it in case you see a reason for it in the way you submit
> the patch set.
> 

I probably grabbed the wrong message-id.