| Message ID | 20210329194602.17049-3-digetx@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | NVIDIA Tegra memory improvements | expand |
On Mon, Mar 29, 2021 at 10:45:58PM +0300, Dmitry Osipenko wrote: > Power domain fits much better than a voltage regulator in regards to > a proper hardware description and from a software perspective as well. > Hence replace the core regulator with the power domain. Note that this > doesn't affect any existing DTBs because we haven't started to use the > regulator yet, and thus, it's okay to change it. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > .../bindings/memory-controllers/nvidia,tegra30-emc.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml > index 0a2e2c0d0fdd..4a2edb9b8bdc 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml > @@ -39,9 +39,10 @@ properties: > description: > Phandle of the Memory Controller node. > > - core-supply: > + power-domains: > + $ref: /schemas/types.yaml#/definitions/phandle 'power-domains' already has a type. We need to know how many (maxItems). > description: > - Phandle of voltage regulator of the SoC "core" power domain. > + Phandle of the SoC "core" power domain. > > operating-points-v2: > description: > @@ -241,7 +242,7 @@ examples: > > nvidia,memory-controller = <&mc>; > operating-points-v2 = <&dvfs_opp_table>; > - core-supply = <&vdd_core>; > + power-domains = <&domain>; > > #interconnect-cells = <0>; > > -- > 2.30.2 >
31.03.2021 01:23, Rob Herring пишет: > On Mon, Mar 29, 2021 at 10:45:58PM +0300, Dmitry Osipenko wrote: >> Power domain fits much better than a voltage regulator in regards to >> a proper hardware description and from a software perspective as well. >> Hence replace the core regulator with the power domain. Note that this >> doesn't affect any existing DTBs because we haven't started to use the >> regulator yet, and thus, it's okay to change it. >> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> .../bindings/memory-controllers/nvidia,tegra30-emc.yaml | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml >> index 0a2e2c0d0fdd..4a2edb9b8bdc 100644 >> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml >> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml >> @@ -39,9 +39,10 @@ properties: >> description: >> Phandle of the Memory Controller node. >> >> - core-supply: >> + power-domains: >> + $ref: /schemas/types.yaml#/definitions/phandle > > 'power-domains' already has a type. We need to know how many (maxItems). Alright, I see now what makes the difference. Thank you and Krzysztof for the suggestion.
diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml index 0a2e2c0d0fdd..4a2edb9b8bdc 100644 --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra30-emc.yaml @@ -39,9 +39,10 @@ properties: description: Phandle of the Memory Controller node. - core-supply: + power-domains: + $ref: /schemas/types.yaml#/definitions/phandle description: - Phandle of voltage regulator of the SoC "core" power domain. + Phandle of the SoC "core" power domain. operating-points-v2: description: @@ -241,7 +242,7 @@ examples: nvidia,memory-controller = <&mc>; operating-points-v2 = <&dvfs_opp_table>; - core-supply = <&vdd_core>; + power-domains = <&domain>; #interconnect-cells = <0>;
Power domain fits much better than a voltage regulator in regards to a proper hardware description and from a software perspective as well. Hence replace the core regulator with the power domain. Note that this doesn't affect any existing DTBs because we haven't started to use the regulator yet, and thus, it's okay to change it. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- .../bindings/memory-controllers/nvidia,tegra30-emc.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)