| Message ID | 20240320083602.81592-1-wigyori@uid0.hu |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: img: fix pwm clock lookup | expand |
Hello Zoltan, On Wed, Mar 20, 2024 at 09:36:02AM +0100, Zoltan HERPAI wrote: > 22e8e19 has introduced a regression in the imgchip->pwm_clk lookup, whereas > the clock name has also been renamed to "imgchip". This causes the driver > failing to load: > > [ 0.546905] img-pwm 18101300.pwm: failed to get imgchip clock > [ 0.553418] img-pwm: probe of 18101300.pwm failed with error -2 > > Fix this lookup by reverting the clock name back to "pwm". > > Signed-off-by: Zoltan HERPAI <wigyori@uid0.hu> Oh indeed. Thanks. I applied it to my for-next branch at https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next and will care to get it into -rc2. Best regards Uwe
diff --git a/drivers/pwm/pwm-img.c b/drivers/pwm/pwm-img.c index d79a96679a26..d6596583ed4e 100644 --- a/drivers/pwm/pwm-img.c +++ b/drivers/pwm/pwm-img.c @@ -284,9 +284,9 @@ static int img_pwm_probe(struct platform_device *pdev) return PTR_ERR(imgchip->sys_clk); } - imgchip->pwm_clk = devm_clk_get(&pdev->dev, "imgchip"); + imgchip->pwm_clk = devm_clk_get(&pdev->dev, "pwm"); if (IS_ERR(imgchip->pwm_clk)) { - dev_err(&pdev->dev, "failed to get imgchip clock\n"); + dev_err(&pdev->dev, "failed to get pwm clock\n"); return PTR_ERR(imgchip->pwm_clk); }
22e8e19 has introduced a regression in the imgchip->pwm_clk lookup, whereas the clock name has also been renamed to "imgchip". This causes the driver failing to load: [ 0.546905] img-pwm 18101300.pwm: failed to get imgchip clock [ 0.553418] img-pwm: probe of 18101300.pwm failed with error -2 Fix this lookup by reverting the clock name back to "pwm". Signed-off-by: Zoltan HERPAI <wigyori@uid0.hu> --- drivers/pwm/pwm-img.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)